[v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module

Message ID 1514988151-12248-1-git-send-email-eric.auger@redhat.com
State New
Headers show
Series
  • [v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module
Related show

Commit Message

Eric Auger Jan. 3, 2018, 2:02 p.m.
If I2C is built as a module, ACPI_I2C_OPREGION cannot be set
and any ACPI opregion calls targeting I2C fail with no opregion found.

This patch allows ACPI_I2C_OPREGION to be enabled both if I2C is
built into the kernel or built as a module.

Signed-off-by: Eric Auger <eric.auger@redhat.com>

---

v1 -> v2:
- reword the commit message
---
 drivers/i2c/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sinan Kaya Jan. 8, 2018, 4:22 p.m. | #1
On 1/3/2018 9:02 AM, Eric Auger wrote:
> If I2C is built as a module, ACPI_I2C_OPREGION cannot be set
> and any ACPI opregion calls targeting I2C fail with no opregion found.
> 
> This patch allows ACPI_I2C_OPREGION to be enabled both if I2C is
> built into the kernel or built as a module.
> 
> Signed-off-by: Eric Auger <eric.auger@redhat.com>

Hoping this makes to 4.16.

Tested-by: Sinan Kaya <okaya@codeaurora.org>

Patch

diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
index efc3354..5951e9d 100644
--- a/drivers/i2c/Kconfig
+++ b/drivers/i2c/Kconfig
@@ -26,7 +26,7 @@  config I2C
 
 config ACPI_I2C_OPREGION
 	bool "ACPI I2C Operation region support"
-	depends on I2C=y && ACPI
+	depends on I2C && ACPI
 	default y
 	help
 	  Say Y here if you want to enable ACPI I2C operation region support.