Patchwork remove an unnecessary field in struct tcp_skb_cb

login
register
mail settings
Submitter Petr Tesarik
Date Nov. 13, 2008, 10:21 a.m.
Message ID <1226571707.18006.23.camel@nathan.suse.cz>
Download mbox | patch
Permalink /patch/8548/
State Accepted
Delegated to: David Miller
Headers show

Comments

Petr Tesarik - Nov. 13, 2008, 10:21 a.m.
The urg_ptr field is not used anywhere and is merely confusing.

Signed-off-by: Petr Tesarik <ptesarik@suse.cz>

--
 include/net/tcp.h     |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Saikiran Madugula - Nov. 13, 2008, 6:10 p.m.
Petr Tesarik wrote:
> The urg_ptr field is not used anywhere and is merely confusing.
> 
grep -r "urg_ptr" on my linux tree says otherwise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andi Kleen - Nov. 13, 2008, 7:57 p.m.
Saikiran Madugula <hummerbliss@gmail.com> writes:

> Petr Tesarik wrote:
>> The urg_ptr field is not used anywhere and is merely confusing.
>> 
> grep -r "urg_ptr" on my linux tree says otherwise.

I think you're confusing it with tcphdr's field of the same name.
Petr's patch is correct as far as I can see.

-Andi
David Miller - Nov. 14, 2008, 6:55 a.m.
From: Andi Kleen <andi@firstfloor.org>
Date: Thu, 13 Nov 2008 20:57:53 +0100

> Saikiran Madugula <hummerbliss@gmail.com> writes:
> 
> > Petr Tesarik wrote:
> >> The urg_ptr field is not used anywhere and is merely confusing.
> >> 
> > grep -r "urg_ptr" on my linux tree says otherwise.
> 
> I think you're confusing it with tcphdr's field of the same name.
> Petr's patch is correct as far as I can see.

Right, patch applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/net/tcp.h b/include/net/tcp.h
index 438014d..8f26b28 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -590,7 +590,6 @@  struct tcp_skb_cb {
 #define TCPCB_EVER_RETRANS	0x80	/* Ever retransmitted frame	*/
 #define TCPCB_RETRANS		(TCPCB_SACKED_RETRANS|TCPCB_EVER_RETRANS)
 
-	__u16		urg_ptr;	/* Valid w/URG flags is set.	*/
 	__u32		ack_seq;	/* Sequence number ACK'd	*/
 };