From patchwork Sat Mar 5 07:33:58 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralf Wildenhues X-Patchwork-Id: 85465 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A63321007D8 for ; Sat, 5 Mar 2011 18:34:58 +1100 (EST) Received: (qmail 3713 invoked by alias); 5 Mar 2011 07:34:51 -0000 Received: (qmail 3570 invoked by uid 22791); 5 Mar 2011 07:34:49 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mailout-de.gmx.net (HELO mailout-de.gmx.net) (213.165.64.23) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sat, 05 Mar 2011 07:34:44 +0000 Received: (qmail invoked by alias); 05 Mar 2011 07:34:31 -0000 Received: from xdsl-89-0-69-173.netcologne.de (EHLO localhost.localdomain) [89.0.69.173] by mail.gmx.net (mp071) with SMTP; 05 Mar 2011 08:34:31 +0100 Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1Pvlzy-0004HD-Vy; Sat, 05 Mar 2011 08:33:58 +0100 Date: Sat, 5 Mar 2011 08:33:58 +0100 From: Ralf Wildenhues To: gcc-patches@gcc.gnu.org, binutils@sourceware.org, gdb-patches@sourceware.org Cc: Mike Stump , Peter O'Gorman , Pedro Alves , Alexandre Oliva , eblake@redhat.com Subject: Re: configure oddity Message-ID: <20110305073358.GB27451@gmx.de> Mail-Followup-To: Ralf Wildenhues , gcc-patches@gcc.gnu.org, binutils@sourceware.org, gdb-patches@sourceware.org, Mike Stump , Peter O'Gorman , Pedro Alves , Alexandre Oliva , eblake@redhat.com References: <2082591D-43B2-4CFC-B8FE-1651137FF1AA@comcast.net> <20110222053236.GA9035@gmx.de> <017DD05A-4121-42EF-AD02-08CB1C811B2A@comcast.net> <201102221307.42204.pedro@codesourcery.com> <513C7C86-C0AD-4131-BF7B-AC8E7B05F8E9@comcast.net> <4D640EDD.5050902@pogma.com> <20110226120740.GE15829@gmx.de> <20110228063850.GA954@gmx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110228063850.GA954@gmx.de> User-Agent: Mutt/1.5.20 (2010-08-04) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org [ http://gcc.gnu.org/ml/gcc-patches/2011-02/msg01716.html ] * Ralf Wildenhues wrote on Mon, Feb 28, 2011 at 07:38:50AM CET: > This patch doesn't change at all the semantics of whether you need to > run autoconf or not. Only when you run it, no matter whether triggered > by make or run manually, it diagnoses buggy m4 versions. Nobody complained about the patch, so I'm committing it to GCC and syncing to src, with recommendations updated. If you get a runtime failure from m4 when running any of autoconf, aclocal, or automake, in the GCC or src trees, then that means you have a buggy m4 and should update to a fixed version. I am specifically _not_ testing for the other bug Eric found (see http://lists.gnu.org/archive/html/autoconf-patches/2011-02/msg00035.html) because we don't yet have evidence that the bug causes differing output in practice, and I'm guessing that m4 versions with that particular bug are so widespread that it would upset people to see their --enable-maintainer-mode builds fail due to the check. Thanks, Ralf 2011-03-05 Ralf Wildenhues Eric Blake * override.m4: Error out if a buggy M4 was detected, to avoid spurious diffs in generated files. diff --git a/config/override.m4 b/config/override.m4 index fc2d527..52bd1c3 100644 --- a/config/override.m4 +++ b/config/override.m4 @@ -48,6 +48,12 @@ _GCC_AUTOCONF_VERSION_CHECK ]) +dnl Ensure we do not use a buggy M4. +m4_if(m4_index([..wi.d.], [.d.]), [-1], + [m4_fatal(m4_do([m4 with buggy strstr detected. Please install +GNU M4 1.4.16 or newer and set the M4 environment variable]))]) + + dnl Fix 2.64 cross compile detection for AVR and RTEMS dnl by not trying to compile fopen. m4_if(m4_defn([m4_PACKAGE_VERSION]), [2.64],