diff mbox series

[U-Boot] armv8: ls1088: Add USB and PCI configs in SD-BOOT defconfig

Message ID 1514870765-26519-1-git-send-email-Ashish.Kumar@nxp.com
State Accepted
Commit 134200a5efffcbba56bdb6954d5b3527ea1fa09c
Delegated to: York Sun
Headers show
Series [U-Boot] armv8: ls1088: Add USB and PCI configs in SD-BOOT defconfig | expand

Commit Message

Ashish Kumar Jan. 2, 2018, 5:26 a.m. UTC
Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
---
depends on: https://patchwork.ozlabs.org/patch/853615/

Tested on 2018.01-rc3

 configs/ls1088aqds_sdcard_qspi_defconfig | 12 ++++++++++++
 configs/ls1088ardb_sdcard_qspi_defconfig | 12 ++++++++++++
 2 files changed, 24 insertions(+)

Comments

York Sun Jan. 8, 2018, 5:44 p.m. UTC | #1
On 01/01/2018 09:24 PM, Ashish Kumar wrote:
> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> ---
> depends on: https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F853615%2F&data=02%7C01%7Cyork.sun%40nxp.com%7C71f45df66ff84071f9c808d551a1227d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636504674867120576&sdata=Qupa0iJaMMXN%2BHVOsCkYL8Y0IycNRSxULBG2NFsWyww%3D&reserved=0

Your dependency is to increase the CONFIG_SYS_MONITOR_LEN. Why are you
still using raw U-Boot image. If you use FIT image, the size should be
correct. Please try.

York
Ashish Kumar Jan. 11, 2018, 9:30 a.m. UTC | #2
> -----Original Message-----
> From: York Sun
> Sent: Monday, January 08, 2018 11:15 PM
> To: Ashish Kumar <ashish.kumar@nxp.com>; u-boot@lists.denx.de
> Subject: Re: [PATCH] armv8: ls1088: Add USB and PCI configs in SD-BOOT
> defconfig
> 
> On 01/01/2018 09:24 PM, Ashish Kumar wrote:
> > Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> > ---
> > depends on:
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> >
> chwork.ozlabs.org%2Fpatch%2F853615%2F&data=02%7C01%7Cyork.sun%40
> nxp.co
> >
> m%7C71f45df66ff84071f9c808d551a1227d%7C686ea1d3bc2b4c6fa92cd99c5c
> 30163
> >
> 5%7C0%7C0%7C636504674867120576&sdata=Qupa0iJaMMXN%2BHVOsCkYL
> 8Y0IycNRSx
> > ULBG2NFsWyww%3D&reserved=0
> 
> Your dependency is to increase the CONFIG_SYS_MONITOR_LEN. Why are
> you still using raw U-Boot image. If you use FIT image, the size should be
> correct. Please try.
> 
By FIT image you mean, image that has header in starting, this header contains size information?
I did this in patch http://patchwork.ozlabs.org/patch/794217/. But It was not accepted. So, I had to drop this patch and change length of CONFIG_SYS_MONITOR_LEN

Regards
Ashish
> York
York Sun Jan. 11, 2018, 5:22 p.m. UTC | #3
On 01/11/2018 01:30 AM, Ashish Kumar wrote:
> 
> 
>> -----Original Message-----
>> From: York Sun
>> Sent: Monday, January 08, 2018 11:15 PM
>> To: Ashish Kumar <ashish.kumar@nxp.com>; u-boot@lists.denx.de
>> Subject: Re: [PATCH] armv8: ls1088: Add USB and PCI configs in SD-BOOT
>> defconfig
>>
>> On 01/01/2018 09:24 PM, Ashish Kumar wrote:
>>> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
>>> ---
>>> depends on:
>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
>>>
>> chwork.ozlabs.org%2Fpatch%2F853615%2F&data=02%7C01%7Cyork.sun%40
>> nxp.co
>>>
>> m%7C71f45df66ff84071f9c808d551a1227d%7C686ea1d3bc2b4c6fa92cd99c5c
>> 30163
>>>
>> 5%7C0%7C0%7C636504674867120576&sdata=Qupa0iJaMMXN%2BHVOsCkYL
>> 8Y0IycNRSx
>>> ULBG2NFsWyww%3D&reserved=0
>>
>> Your dependency is to increase the CONFIG_SYS_MONITOR_LEN. Why are
>> you still using raw U-Boot image. If you use FIT image, the size should be
>> correct. Please try.
>>
> By FIT image you mean, image that has header in starting, this header contains size information?
> I did this in patch http://patchwork.ozlabs.org/patch/794217/. But It was not accepted. So, I had to drop this patch and change length of CONFIG_SYS_MONITOR_LEN
> 

OK. If you are using raw image, this length adjustment is needed.

York
York Sun Jan. 19, 2018, 12:57 a.m. UTC | #4
On 01/01/2018 09:24 PM, Ashish Kumar wrote:
> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> ---

Applied to fsl-qoriq master. Thanks.

York
diff mbox series

Patch

diff --git a/configs/ls1088aqds_sdcard_qspi_defconfig b/configs/ls1088aqds_sdcard_qspi_defconfig
index 0ba6981..659bc4f 100644
--- a/configs/ls1088aqds_sdcard_qspi_defconfig
+++ b/configs/ls1088aqds_sdcard_qspi_defconfig
@@ -23,6 +23,7 @@  CONFIG_HUSH_PARSER=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y
@@ -35,6 +36,17 @@  CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
+CONFIG_PCI=y
+CONFIG_DM_PCI=y
+CONFIG_DM_PCI_COMPAT=y
+CONFIG_PCIE_LAYERSCAPE=y
 CONFIG_SYS_NS16550=y
 CONFIG_DM_SPI=y
 CONFIG_FSL_DSPI=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_STORAGE=y
+CONFIG_USB_GADGET=y
diff --git a/configs/ls1088ardb_sdcard_qspi_defconfig b/configs/ls1088ardb_sdcard_qspi_defconfig
index 77e6f0a..2e3c287 100644
--- a/configs/ls1088ardb_sdcard_qspi_defconfig
+++ b/configs/ls1088ardb_sdcard_qspi_defconfig
@@ -24,6 +24,7 @@  CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_MMC=y
@@ -34,6 +35,17 @@  CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
+CONFIG_PCI=y
+CONFIG_DM_PCI=y
+CONFIG_DM_PCI_COMPAT=y
+CONFIG_PCIE_LAYERSCAPE=y
 CONFIG_SYS_NS16550=y
 CONFIG_DM_SPI=y
 CONFIG_FSL_DSPI=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_STORAGE=y
+CONFIG_USB_GADGET=y