| Message ID | 20180101203158.18701-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | d2f715802833d636513dcd3c156632e35bd04454 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,1/1] fs/fat: remove distractive message in file_fat_read_at() | expand |
On 1 January 2018 at 13:31, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > The message "reading %s\n" may be interesting when > debugging but otherwise it is superfluous. > > Only output the message when debugging. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > fs/fat/fat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Mon, Jan 01, 2018 at 09:31:58PM +0100, Heinrich Schuchardt wrote: > The message "reading %s\n" may be interesting when > debugging but otherwise it is superfluous. > > Only output the message when debugging. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/fs/fat/fat.c b/fs/fat/fat.c index d16883fa10..1283818761 100644 --- a/fs/fat/fat.c +++ b/fs/fat/fat.c @@ -1106,7 +1106,7 @@ int file_fat_read_at(const char *filename, loff_t pos, void *buffer, if (ret) goto out_free_both; - printf("reading %s\n", filename); + debug("reading %s\n", filename); ret = get_contents(&fsdata, itr->dent, pos, buffer, maxsize, actread); out_free_both:
The message "reading %s\n" may be interesting when debugging but otherwise it is superfluous. Only output the message when debugging. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- fs/fat/fat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)