Message ID | 20171231161513.25785-7-idosch@mellanox.com |
---|---|
State | RFC, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="PIZyjUN8"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3z8lqZ6v6Wz9s84 for <patchwork-incoming@ozlabs.org>; Mon, 1 Jan 2018 03:18:18 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751298AbdLaQSR (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Sun, 31 Dec 2017 11:18:17 -0500 Received: from mail-eopbgr30047.outbound.protection.outlook.com ([40.107.3.47]:24032 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750989AbdLaQQf (ORCPT <rfc822;netdev@vger.kernel.org>); Sun, 31 Dec 2017 11:16:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vx8ORDzOVa1Q2yBT0MEneD0pzi6IH1dSG2Piny+Vwok=; b=PIZyjUN8N937YT3C6tTR0Pb6HhpSR2H6o6WM7zhWZztDN7fKloEOVsR4ZrHIT6nQRErKrkwXUuaGm5W9bKDXs3+sS/ud4iEXz6aWUY1+Vv6vGmLwAoEBZ0GGgUoHNyIJVcTXFRIYIkk/L2DRguOyiK6Z7sgHSCPg4N4q6tIYTE0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; Received: from splinter.mtl.com (193.47.165.251) by AM5PR0501MB2001.eurprd05.prod.outlook.com (2603:10a6:203:1a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Sun, 31 Dec 2017 16:16:27 +0000 From: Ido Schimmel <idosch@mellanox.com> To: netdev@vger.kernel.org Cc: davem@davemloft.net, dsahern@gmail.com, roopa@cumulusnetworks.com, nicolas.dichtel@6wind.com, mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com> Subject: [RFC PATCH net-next 06/19] ipv6: Set nexthop flags during route creation Date: Sun, 31 Dec 2017 18:15:00 +0200 Message-Id: <20171231161513.25785-7-idosch@mellanox.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171231161513.25785-1-idosch@mellanox.com> References: <20171231161513.25785-1-idosch@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM5PR0502CA0020.eurprd05.prod.outlook.com (2603:10a6:203:91::30) To AM5PR0501MB2001.eurprd05.prod.outlook.com (2603:10a6:203:1a::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31244325-0002-44bf-f33c-08d55069d8b1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(48565401081)(2017052603307)(7153060); SRVR:AM5PR0501MB2001; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2001; 3:bCl9tClTwqJSnqZ7K7X+5506lEkYXmRtHiaU2DAe6UDkwgyTil+AQ6yXPoYKb05JA9kqQXXXZiXkeIdK2ejHNKREBNK9aoBEbmf2oFv9Q1Lst/2SHe9aCKFPzr9mc/fBa5BFgm5bscCqMv+FBGRyTV176VI8quXH+R7pWrHiEYK9YAygt8oui5uMOHH9BsAD1fpVqFW6rsJRNqziMHmXFjTzJyF+1aPm+fggm93u+60mzlg4uTVY7w5Ku+/MDDYP; 25:FIDCJs5oKzcqZ9Z7UwsBzSf1hRxWhRQR3m6FebjoTjjx1AmuufVZF2pT71pSANdDvUtJ4xoccO6tNjzlHnw9WJfJqoGPuDTX+9RLOevwhQIwCIIJ4iMShn2qs/2XjyBg1WbaZCv+7r21LbLM2XkstDdEHteTNKphGiku9lWw0pBkf0rBJ5krqB7iOOjcGExvcNKtJ2z1TCYCYQzV2PNsnEljxHe+MOiidSIIWjrNKmaJGQYP2D+rN1kjxCAzDroZyXSDnIRgomVgvf8V/x3h+oOqqKakhPYo0wtsrBgZwYndGVMik5QSSSq95M4XyNYKk6T7BNA35BmhcOit+rnLNQ==; 31:x7QcbSTY6dNE37oWkCt9j3JsnuVDRIalJSiHUU7+EitXqKyB8s92EYJqJBlYVidkv7sKGowjbVMvw8SfFBOfFCXhtJSM41K78YC/aUi4F5zJa+oXhIHYlKNi/DYujg1IEPbSW3DA+BZ2WeGKWfbR6zK18NCIpoiGlKgrM3RIOcI3C0c0ZPifXAB46dhEELdiU67pTUbPN9XyWCLkgXU46+HW96N9D+fHIg+nOCYQqrw= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2001: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2001; 20:Txevm5LRJ0LOVcI3Rw53n+CtFgSvs6wRbDo3MjMvvVv+D/iH/TlZLJeSKN1QxPZt6zg4EHA0bmaJ7jU08wV4aODEW2Al+En9NACXWr/Pt8/Di4Za0DAof/68he2jzyKUuNrUVVmLBq0NFJSqqRnq+sQnT5PrHk2Pt2Q3wuCxhUeUwm8OCqDjrOgN3CsxTly3UnwdMxzDo5Pv3bF9Zj9yXkVG+tprajHCuBvx7XYxFTnQ2GaSHtD/Gl069NZ2ZSU26vobXuGFWSuNdXc94ESVPLiSTm5philfqcLU5viLg05fNHHNf6HT7NWOH1I5Wy2omJVRH3IUnvLNFYwB0C77b6ugN6MZbgkt4KsX8T85B6sKjyKrgyEqt3/ssqmCOB5PPBidDiIe5AcVy6lSpEbmlCmS4pIc/E6iykZ0VddxrywtSjtAmnAXu5qv/6/qKwZ2rBX52tjBQGl/8Aq16nIEVMp/OTCdQxkcyz7sCDXGAtCZvOecUS9IxkYlKVKydI80; 4:2/y3O3GJyVsp7LXheLfqalNTyDi8f5/1Mikf4G2fEc/sCfjVM2CUTczL8TnurEHFZFqUdgW9BRMIiahWGbkISgTwXTi5JK+AY7CspJ8QtTcZ6c5xDh3MC3K/wvOckQEXE3Hpugrg51dBy5pC7T9cNKP3n2v/pAor64jH90ArEorr1/9u0zoc8R0iZxVfylD8hh561SMqh9fB7NS5qtbVrP446TlgVlCetCbxsxhXYNCJhTiYegmbMKouHRd3qcEeOKiYDVLcrLNmJYeI/h1+9w== X-Microsoft-Antispam-PRVS: <AM5PR0501MB2001CAB9B3824B247A8B37BCBF1B0@AM5PR0501MB2001.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231023)(944501075)(6055026)(6041268)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:AM5PR0501MB2001; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM5PR0501MB2001; X-Forefront-PRVS: 0538A71254 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(346002)(396003)(39860400002)(376002)(199004)(189003)(106356001)(86362001)(305945005)(6512007)(6486002)(1076002)(316002)(81156014)(2906002)(6116002)(3846002)(16526018)(16586007)(8676002)(5660300001)(47776003)(66066001)(25786009)(6916009)(2361001)(39060400002)(68736007)(105586002)(6666003)(36756003)(51416003)(97736004)(48376002)(8936002)(4326008)(52116002)(2351001)(7736002)(53936002)(478600001)(386003)(107886003)(50226002)(50466002)(2950100002)(53416004)(81166006)(76176011)(6506007)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2001; H:splinter.mtl.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2001; 23:HsmaeKABTt7qEn/D1t58W1NG9Q1iXBlCDfuhtk1Op4IuM4b5YY8t1XRkoR8Yan8lq6dBF4aWHbQTpTRcmAthbf3O4jkCn0Km97uX7k6KSA9D3ZG7qRJ/J7RavsVtlpU+QqKnV+HE7Xd2tnBMEJ2jZGtFd9MDv3S/3Fh3SDmDLVDsw4ZXb0b6dufrsH7f1P51uGYe/N7Wj/Qz+p8ei7jgf0Cj2SivDaAsFoQ2sGHLTTCB7U8t+ofWacir/YWZtIC+0Tbv9WG0TGjR8xEGM3RwRIutPLVgvw29hiYu2jBqK0omWaQ8cWLNE9ILYEx02KlkphzX1AO4Snz8XdkmypnblWZBrpSQdlgOA5RozDNoonmmwVQOvCfhLhElN1L+JvE14WuAwVKtRPc+S9umR0KGgEZgtLDEpcjuCtXC64W7aivXxnWXYVV6J7A5rZHklbgAC05ORDC3vlL6WJPe3zV7HyB8xi0zu0h60cif8wzsCj4s221z9zqU/FajTTFgJfGldTD2REQ3NeOf3XSTUmDF6qFsRbNpq3UHfi94sn3Hdv1NpbIYLfyEvI/DCD6CLj2LLFOGf+mpZfG4sCW3v94jV4/gJT48pgZH2/BIgd/n6V9+qhIO4f2MsHVNWZyu1WBby5zPnt6JvVYlqcgEmmyL5Q+cezx6QdT4Y7to3T8Gq3AyUlSlzJeBiS1sIFuxpihE62oF4ifoswgG0g7GWwGZNW5+3U5A/oOMB+aJcuIpobwUeIAG1urlQWLktJsgxcnGs/rVVfrciemge2Ywyx5ZrPoh0QiCeqDXznT5mGmSrMSj2Gma9xDazkFDb40dH6YXL+W3sdgT2tZPx6y+KF3ngBJNlk+1BUg6oh46IjmxyWxU5mtKsuHoNbuBQmdINmjVbTLTUhDBCx/17a4FE20tZMpBeqDzOEW7n2X9sjVewlBC2uTFEGRrG2+vh8vDPdxQc6F69cn4ZlItYfiEyX1rAMuIwtjTg9ry2QYsaKSINWjjXsmAijRwI/P8X/Ukf2dmKp7sCAfbaVXxxxCGDLvFHJRaHI7K922x3A/QeNHHAKRnaIhNPOKwYdYtSHKYKEF5iluLrAGD6+G0Ahr8OEN56PShS2RvhrH3REdlL7toAoHWftN838fpEES0oVHpG3TNW9n4C/O8+KNEVI96+gdYXznZYYc4NUahj5nnojbaRFOu9tkXgkF/ST1cgjU5OH+RZK8M1UoHANFQxaMJ1I7vEg== X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2001; 6:Gk4/zns+HMti7AOe96M/b4XJK3ou/UY/60ToxC9OXRRNclLSfUw5kQq5SAkjQTAVFixZlLKASZRcpLqbugdxI6oIao9oG/OmspHozflw62AbrAy7TqahNOu9AyiDPs5aRT3uaz62bRxVEPzrTgNLRkJcM32aCwrYpUNz/NZelh3+gbaX9jt3ixWlynYwghogx8imqAOps4gzOYiRCVcmI8XY9kZAtYsCelxMGqywxlld3zcpUO0DjyuLMK4+7LQpWdf5X1qtsWCWtQkxk/uh5TsHq0zoNjOjcAL5apxAYFCo+J3Xm0CCnfYIfiNvfNyx9cmHS13v9L+MH4ilSaJjlyCdHL4yWz0lqGtgWwVxDk8=; 5:LHTvmEjZz8agOPLPK0Z7AUMUhx2xXt/kx3olh9tbgwSY/iN5gDL/l4JbPxFa2bZsFZbXbXO7bIALPHP79VpAcf4HlWVt/OP5H0Vx3mDtEUbsbtw497bBpRUUs53lsv9X6L8PyCq/yrvxE2WlaeVDAvuKACoIkmwRnnMXO6Y93aI=; 24:2grQ/8BOGlhCKntSXLptLZBacZGbvGm/aeRVCuBXfzNBsarQzBahhVDre03y8+0q9P1bAAYJi8l6cTA7HYxwcYjWcR5G6vNK6wb4mgM5HYc=; 7:16IQdD4tJ2bwKkk36M4GtOnWa8Pj0r9sgM2y5y93DXJzTWc6do6pJ6lalXRZvRl+//0JBe4Eq+9gD2hhTnOy8MfqhMOdm8ThZ5k5uL2az/FDpcngdyIS8yHKJ/3gdYU2HoVz0GMOvN5nSncPF8jG05k/5u3neg2I9ibFZop/b16nVtv8AgCLT886SJn17cTcdTEgFamys8Vlbi8rd1gahps9D0RN/Q9MirLPvguekdG6UI73LfAY0Ml9msyQzCCA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2017 16:16:27.4340 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31244325-0002-44bf-f33c-08d55069d8b1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2001 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series |
[RFC,net-next,01/19] ipv6: Remove redundant route flushing during namespace dismantle
|
expand
|
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 1f331f332491..13238c4e76cc 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2746,6 +2746,9 @@ static struct rt6_info *ip6_route_info_create(struct fib6_config *cfg, rt->rt6i_flags = cfg->fc_flags; install_route: + if (!(rt->rt6i_flags & (RTF_LOCAL | RTF_ANYCAST)) && + !netif_carrier_ok(dev)) + rt->rt6i_nh_flags |= RTNH_F_LINKDOWN; rt->dst.dev = dev; rt->rt6i_idev = idev; rt->rt6i_table = table;
It is valid to install routes with a nexthop device that does not have a carrier, so we need to make sure they're marked accordingly. As explained in the previous patch, host and anycast routes are never marked with the 'linkdown' flag. Note that reject routes are unaffected, as these use the loopback device which always has a carrier. Signed-off-by: Ido Schimmel <idosch@mellanox.com> --- net/ipv6/route.c | 3 +++ 1 file changed, 3 insertions(+)