From patchwork Sat Dec 30 15:57:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Mukhin X-Patchwork-Id: 854127 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XQMwo0XA"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z87Qv4vrdz9sBZ for ; Sun, 31 Dec 2017 02:58:15 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C887E85945; Sat, 30 Dec 2017 15:58:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cSwA-94Q9UTk; Sat, 30 Dec 2017 15:58:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id B03D585805; Sat, 30 Dec 2017 15:58:11 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 007AA1C0EC7 for ; Sat, 30 Dec 2017 15:58:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id F049F84C03 for ; Sat, 30 Dec 2017 15:58:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IycSgkkzZWl7 for ; Sat, 30 Dec 2017 15:58:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by whitealder.osuosl.org (Postfix) with ESMTPS id 357AD84922 for ; Sat, 30 Dec 2017 15:58:05 +0000 (UTC) Received: by mail-lf0-f67.google.com with SMTP id m20so37443768lfi.6 for ; Sat, 30 Dec 2017 07:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iXH5TZtPvmC4Nt8bJb71Gn5+FtDKpaKmjCDTqVr3Ajw=; b=XQMwo0XAvb8be19Jdm2DP2TvV/AiZQIXXWa5sRsXUXmr2xBcpQSgr5XPaDFQQl3Oqr CskFRTfD47IypotV1KJ8bXv3mTC4TsSuCy/7HpQaS4A31/neMdujTc6tzUZFJA90sp1o j54Yt9kBW7HS2szUTaCkD82/GFzTbJp+pXH5UvRnl4IkiTX9l60sWkcv8oRjVQFjJhR8 POIVA29Cem0RDxrOL0jNK7VeI4fpJeIBwMxR0s1wCT5tKzLylI/7SZ39IJXZALi7MHEM r/n94w514MPX7FXDrwo7ojn3u24YONerHYusK8LiksLmTOwEa65GLumFvqREX9fpPPzP C1UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iXH5TZtPvmC4Nt8bJb71Gn5+FtDKpaKmjCDTqVr3Ajw=; b=aEsJ8nWRvilAXEwf9OPm2zpAnML3iY7Rcp3Rv7xiOu3aH4e4p3x80BUPGxe4KoPOIK SUUvZYFiubSwTgLHlag48yIajpJsfnjqX1BjNF5RYfGZellBF9fLC5mu5zsNMBNo3ZIn 5iIlGaLSv/lAS4Zlmfe1fVUeDChjm8t/CrLaBWlW1a6OJEeSKdc3FI5dysA30RSzVFk6 OMj/S6WWGzdNaQA8t2S9uV/6RVsRex5cATr8ltaUHZMEmbiO7RvRDflj6OWEHWLySo28 vagfgdM5ORJFQ7Kz0WQQhsi1GaxMDaHIXNEEjwwHOJInBEWQ45KtJbYGEP9/DZFGkY+/ Ya5Q== X-Gm-Message-State: AKGB3mILgqGgSa0psNzLoQK8gjFaYcyTo9eRYbNYKchwgh+pfs5gllaN dhQ5XdxpDGcQzpySDvAFjcWz2Q== X-Google-Smtp-Source: ACJfBovSS6ykdsJNZ/LkJCP/2HGXBjXG0BvcbwF5UUrVMRiCKiFdqclHGbJ7QH4dpot/lUsf7PlPXA== X-Received: by 10.46.69.67 with SMTP id s64mr22973707lja.94.1514649483317; Sat, 30 Dec 2017 07:58:03 -0800 (PST) Received: from localhost.localdomain ([2a00:1838:30:a00:626d:c7ff:fecc:a711]) by smtp.gmail.com with ESMTPSA id 79sm7774704ljq.5.2017.12.30.07.58.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Dec 2017 07:58:02 -0800 (PST) From: Alexander Mukhin To: buildroot@busybox.net Date: Sat, 30 Dec 2017 18:57:35 +0300 Message-Id: <20171230155736.1668-3-alexander.i.mukhin@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171230155736.1668-1-alexander.i.mukhin@gmail.com> References: <20171230155736.1668-1-alexander.i.mukhin@gmail.com> Subject: [Buildroot] [PATCH 2/3] hostapd: make ACS dependent on nl80211 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thomas.petazzoni@free-electrons.com, Alexander Mukhin MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" According to hostapd's defconfig file, ACS is currently only supported through the nl80211 driver. Search through the source code also confirms that ACS machinery is present in the nl80211 driver only. Although hostapd can be built with ACS enabled and nl80211 disabled, an attempt to use ACS with other drivers by setting a wireless channel to 0 results in a runtime failure (driver doesn't accept this value). So we might save a user from selecting a meaningless combination by making ACS dependent on nl80211. Signed-off-by: Alexander Mukhin Reviewed-by: Sam Voss --- package/hostapd/Config.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in index f6182a9268..d23e5e1dca 100644 --- a/package/hostapd/Config.in +++ b/package/hostapd/Config.in @@ -53,6 +53,7 @@ config BR2_PACKAGE_HOSTAPD_HAS_WIFI_DRIVERS config BR2_PACKAGE_HOSTAPD_ACS bool "Enable ACS" default y + depends on BR2_PACKAGE_HOSTAPD_DRIVER_NL80211 help Enable support for standard ACS (Automatic Channel Selection). Some propietary drivers use a custom algorithm which requires @@ -60,6 +61,9 @@ config BR2_PACKAGE_HOSTAPD_ACS causing hostapd to use the standard one which doesn't work for those cases. +comment "ACS is currently only supported through the nl80211 driver" + depends on !BR2_PACKAGE_HOSTAPD_DRIVER_NL80211 + config BR2_PACKAGE_HOSTAPD_EAP bool "Enable EAP" depends on !BR2_STATIC_LIBS