| Message ID | 20171227180229.1926-4-eric@regit.org |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | libbpf: add function to setup XDP | expand |
On Wed, Dec 27, 2017 at 07:02:28PM +0100, Eric Leblond wrote: > Get out of the loop when we have a match. > > Signed-off-by: Eric Leblond <eric@regit.org> > --- > tools/lib/bpf/libbpf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 5fe8aaa2123e..d263748aa341 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -412,6 +412,7 @@ bpf_object__init_prog_names(struct bpf_object *obj) > prog->section_name); > return -LIBBPF_ERRNO__LIBELF; > } > + break; why this is needed? The top of the loop is: for (si = 0; si < symbols->d_size / sizeof(GElf_Sym) && !name; so as soon as name is found the loop will exit. I agree that the loop structure is non-standard is confusing, but adding break here will make it even more so. If 'break' is added then '&& !name' should be removed.
Hello, On Wed, 2017-12-27 at 11:00 -0800, Alexei Starovoitov wrote: > On Wed, Dec 27, 2017 at 07:02:28PM +0100, Eric Leblond wrote: > > Get out of the loop when we have a match. > > > > Signed-off-by: Eric Leblond <eric@regit.org> > > --- > > tools/lib/bpf/libbpf.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > > index 5fe8aaa2123e..d263748aa341 100644 > > --- a/tools/lib/bpf/libbpf.c > > +++ b/tools/lib/bpf/libbpf.c > > @@ -412,6 +412,7 @@ bpf_object__init_prog_names(struct bpf_object > > *obj) > > prog->section_name); > > return -LIBBPF_ERRNO__LIBELF; > > } > > + break; > > why this is needed? It was just cosmetic, no related bug. > The top of the loop is: > for (si = 0; si < symbols->d_size / sizeof(GElf_Sym) && !name; > > so as soon as name is found the loop will exit. OK, I've missed that. Please disregard this patch. BR,
On 12/27/2017 09:30 PM, Eric Leblond wrote: > On Wed, 2017-12-27 at 11:00 -0800, Alexei Starovoitov wrote: >> On Wed, Dec 27, 2017 at 07:02:28PM +0100, Eric Leblond wrote: >>> Get out of the loop when we have a match. >>> >>> Signed-off-by: Eric Leblond <eric@regit.org> >>> --- >>> tools/lib/bpf/libbpf.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c >>> index 5fe8aaa2123e..d263748aa341 100644 >>> --- a/tools/lib/bpf/libbpf.c >>> +++ b/tools/lib/bpf/libbpf.c >>> @@ -412,6 +412,7 @@ bpf_object__init_prog_names(struct bpf_object >>> *obj) >>> prog->section_name); >>> return -LIBBPF_ERRNO__LIBELF; >>> } >>> + break; >> >> why this is needed? > > It was just cosmetic, no related bug. > >> The top of the loop is: >> for (si = 0; si < symbols->d_size / sizeof(GElf_Sym) && !name; >> >> so as soon as name is found the loop will exit. > > OK, I've missed that. Please disregard this patch. Ok, please respin the series one last time w/o this patch then. Please also keep the already given ACKs on the other patches. Thanks, Eric!
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 5fe8aaa2123e..d263748aa341 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -412,6 +412,7 @@ bpf_object__init_prog_names(struct bpf_object *obj) prog->section_name); return -LIBBPF_ERRNO__LIBELF; } + break; } if (!name) {
Get out of the loop when we have a match. Signed-off-by: Eric Leblond <eric@regit.org> --- tools/lib/bpf/libbpf.c | 1 + 1 file changed, 1 insertion(+)