| Message ID | 1514281725-47488-1-git-send-email-yuvalm@mellanox.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute] qdisc: Print offload indication | expand |
Tue, Dec 26, 2017 at 10:48:45AM CET, yuvalm@mellanox.com wrote: >Use the newly added TCA_HW_OFFLOAD indication from kernel >to print a consistent 'offloaded' message to user when listing qdiscs. > >Signed-off-by: Yuval Mintz <yuvalm@mellanox.com> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
> >Use the newly added TCA_HW_OFFLOAD indication from kernel > >to print a consistent 'offloaded' message to user when listing qdiscs. > > > >Signed-off-by: Yuval Mintz <yuvalm@mellanox.com> > > Reviewed-by: Jiri Pirko <jiri@mellanox.com> Just now saw the Stephen's e-mail regarding iproute's net-next branch. In this case the new uapi needed was pushed to 'net'. Does this mean you're Going to take it to the master or net-next branch? If the latter, it doesn't apply cleanly on David's branch since he already updated the kernel headers in include/uapi/linux/rtnetlink.h. It's trivial, but tell me if you want a re-spin.
On Tue, 26 Dec 2017 11:48:45 +0200 Yuval Mintz <yuvalm@mellanox.com> wrote: > Use the newly added TCA_HW_OFFLOAD indication from kernel > to print a consistent 'offloaded' message to user when listing qdiscs. > > Signed-off-by: Yuval Mintz <yuvalm@mellanox.com> Applied to master (since TCA_HW_OFFLOAD is already present).
diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index b8335b5..13bf56f 100644 --- a/include/uapi/linux/rtnetlink.h +++ b/include/uapi/linux/rtnetlink.h @@ -557,6 +557,7 @@ enum { TCA_PAD, TCA_DUMP_INVISIBLE, TCA_CHAIN, + TCA_HW_OFFLOAD, __TCA_MAX }; diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c index 4431d5f..70279b9 100644 --- a/tc/tc_qdisc.c +++ b/tc/tc_qdisc.c @@ -266,6 +266,10 @@ int print_qdisc(const struct sockaddr_nl *who, if (t->tcm_info != 1) print_uint(PRINT_ANY, "refcnt", "refcnt %u ", t->tcm_info); + if (tb[TCA_HW_OFFLOAD] && + (rta_getattr_u8(tb[TCA_HW_OFFLOAD]))) + print_bool(PRINT_ANY, "offloaded", "offloaded ", true); + /* pfifo_fast is generic enough to warrant the hardcoding --JHS */ if (strcmp("pfifo_fast", RTA_DATA(tb[TCA_KIND])) == 0) q = get_qdisc_kind("prio");
Use the newly added TCA_HW_OFFLOAD indication from kernel to print a consistent 'offloaded' message to user when listing qdiscs. Signed-off-by: Yuval Mintz <yuvalm@mellanox.com> --- include/uapi/linux/rtnetlink.h | 1 + tc/tc_qdisc.c | 4 ++++ 2 files changed, 5 insertions(+)