| Message ID | 20171223190617.3981-4-alexander.i.mukhin@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | hostapd: new configuration options | expand |
Hello, On Sat, 23 Dec 2017 22:06:16 +0300, Alexander Mukhin wrote: > ACS is supported for nl80211 driver only. > > Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com> Could you add more details here? Do you see a build failure? Runtime failure? If CONFIG_ACS=y doesn't build when CONFIG_DRIVER_NL80211 is disabled, then this fix should be part of PATCH 2/4, otherwise PATCH 2/4 introduces a build regression. Thanks! Thomas
Hello, > > ACS is supported for nl80211 driver only. > > > Could you add more details here? Do you see a build failure? Runtime > failure? > > If CONFIG_ACS=y doesn't build when CONFIG_DRIVER_NL80211 is disabled, > then this fix should be part of PATCH 2/4, otherwise PATCH 2/4 > introduces a build regression. My guide here is hostapd's defconfig, where it's stated that "ACS is currently only supported through the nl80211 driver". Search through the source code also reveals ACS machinery in the nl80211 driver only. hostapd builds successively with ACS enabled and nl80211 disabled, but an attempt to use ACS by setting a wireless channel to 0 results in a runtime failure (driver doesn't accept this value).
Hello, On Sat, 30 Dec 2017 12:50:00 +0300, Alexander Mukhin wrote: > > > ACS is supported for nl80211 driver only. > > > > > Could you add more details here? Do you see a build failure? Runtime > > failure? > > > > If CONFIG_ACS=y doesn't build when CONFIG_DRIVER_NL80211 is disabled, > > then this fix should be part of PATCH 2/4, otherwise PATCH 2/4 > > introduces a build regression. > > My guide here is hostapd's defconfig, where it's stated that "ACS is > currently only supported through the nl80211 driver". Search through the > source code also reveals ACS machinery in the nl80211 driver only. > > hostapd builds successively with ACS enabled and nl80211 disabled, but > an attempt to use ACS by setting a wireless channel to 0 results in a > runtime failure (driver doesn't accept this value). Thanks for this additional explanation. Could you include this in the commit log in the next iteration of this patch series ? Thanks! Thomas
Hello, On Sat, Dec 30, 2017 at 11:18:56AM +0100, Thomas Petazzoni wrote: > > Thanks for this additional explanation. Could you include this in the > commit log in the next iteration of this patch series ? > Yes, I'll surely do.
diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in index 509797a44a..57cec469c6 100644 --- a/package/hostapd/Config.in +++ b/package/hostapd/Config.in @@ -39,6 +39,7 @@ comment "at least one driver must be selected" config BR2_PACKAGE_HOSTAPD_ACS bool "Enable ACS" default y + depends on BR2_PACKAGE_HOSTAPD_DRIVER_NL80211 help Enable support for standard ACS (Automatic Channel Selection). Some propietary drivers use a custom algorithm which requires @@ -46,6 +47,9 @@ config BR2_PACKAGE_HOSTAPD_ACS causing hostapd to use the standard one which doesn't work for those cases. +comment "ACS is currently only supported through the nl80211 driver" + depends on !BR2_PACKAGE_HOSTAPD_DRIVER_NL80211 + config BR2_PACKAGE_HOSTAPD_EAP bool "Enable EAP" depends on !BR2_STATIC_LIBS
ACS is supported for nl80211 driver only. Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com> --- package/hostapd/Config.in | 4 ++++ 1 file changed, 4 insertions(+)