Patchwork [i386,AVX] Type error in vpmaddubsw instruction pattern

login
register
mail settings
Submitter Jia Liu
Date March 3, 2011, 11:11 a.m.
Message ID <AANLkTinC40YjGC5Bs-P2n+BSK9z5KsVCmOztxiU8tE0A@mail.gmail.com>
Download mbox | patch
Permalink /patch/85255/
State New
Headers show

Comments

Jia Liu - March 3, 2011, 11:11 a.m.
Hi,

When I read sse.md, I find there is a type error in vpmaddubsw
define_insn pattern.
Attached is the patch that fix the type error.
Is it OK to commit to 4.6 trunk?

Thanks,
Uros Bizjak - March 3, 2011, 2:29 p.m.
On Thu, Mar 3, 2011 at 12:11 PM, Liu <proljc@gmail.com> wrote:

> When I read sse.md, I find there is a type error in vpmaddubsw
> define_insn pattern.
> Attached is the patch that fix the type error.
> Is it OK to commit to 4.6 trunk?

The same problem is with ssse3_pmadddubsw128 pattern.  Can you also
provide the ChangeLog for the patch and how you test the change?

Thanks,
Uros.
Jia Liu - March 4, 2011, 1:26 a.m.
On Thursday, March 3, 2011, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Thu, Mar 3, 2011 at 12:11 PM, Liu <proljc@gmail.com> wrote:
>
>> When I read sse.md, I find there is a type error in vpmaddubsw
>> define_insn pattern.
>> Attached is the patch that fix the type error.
>> Is it OK to commit to 4.6 trunk?
>
> The same problem is with ssse3_pmadddubsw128 pattern.  Can you also
> provide the ChangeLog for the patch and how you test the change?
>
> Thanks,
> Uros.
>

Hi Uros,
When I get my office this morning, run "svn up" in gcc tree, I see
that you have fixed it yesterday:)

Thanks,
Liu.

Patch

Index: gcc/config/i386/sse.md
===================================================================
--- gcc/config/i386/sse.md	(revision 170646)
+++ gcc/config/i386/sse.md	(working copy)
@@ -8885,7 +8885,7 @@ 
 	(ss_plus:V8HI
 	  (mult:V8HI
 	    (zero_extend:V8HI
-	      (vec_select:V4QI
+	      (vec_select:V8QI
 		(match_operand:V16QI 1 "register_operand" "x")
 		(parallel [(const_int 0)
 			   (const_int 2)