Patchwork [U-Boot] ARM: Don't grab memory for LCD if FB address is defined

login
register
mail settings
Submitter Minkyu Kang
Date March 3, 2011, 8:49 a.m.
Message ID <4D6F5611.40802@samsung.com>
Download mbox | patch
Permalink /patch/85247/
State Changes Requested
Headers show

Comments

Minkyu Kang - March 3, 2011, 8:49 a.m.
If FB address is defined as specific address then don't grab memory for LCD

Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
---
 arch/arm/lib/board.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Wolfgang Denk - March 3, 2011, 11:07 p.m.
Dear Minkyu Kang,

In message <4D6F5611.40802@samsung.com> you wrote:
> If FB address is defined as specific address then don't grab memory for LCD
> 
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  arch/arm/lib/board.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)

Sorry, but NAK.

You cannot make this change for ARM only.  It needs to be implemented
for all architectures.

Best regards,

Wolfgang Denk

Patch

diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
index c620d2c..5a4d2bd 100644
--- a/arch/arm/lib/board.c
+++ b/arch/arm/lib/board.c
@@ -356,9 +356,13 @@  void board_init_f (ulong bootflag)
 #endif /* CONFIG_VFD */
 
 #ifdef CONFIG_LCD
+#ifdef CONFIG_FB_ADDR
+	gd->fb_base = CONFIG_FB_ADDR;
+#else
 	/* reserve memory for LCD display (always full pages) */
 	addr = lcd_setmem (addr);
 	gd->fb_base = addr;
+#endif /* CONFIG_FB_ADDR */
 #endif /* CONFIG_LCD */
 
 	/*