diff mbox series

tcp: make function tcp_recv_timestamp static

Message ID 20171222010135.12204-1-colin.king@canonical.com
State Changes Requested, archived
Delegated to: David Miller
Headers show
Series tcp: make function tcp_recv_timestamp static | expand

Commit Message

Colin Ian King Dec. 22, 2017, 1:01 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The function tcp_recv_timestamp is local to the source and does not
need to be in global scope, so make it static.

Cleans up sparse warning:
symbol 'tcp_recv_timestamp' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/ipv4/tcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Dec. 26, 2017, 10:42 p.m. UTC | #1 
From: Colin King <colin.king@canonical.com>
Date: Fri, 22 Dec 2017 01:01:35 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> The function tcp_recv_timestamp is local to the source and does not
> need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'tcp_recv_timestamp' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This doesn't apply cleanly to any of my trees, please be explicit about
which tree you are targetting once you fix this up, also:

> @@ -1729,7 +1729,7 @@ static void tcp_update_recv_tstamps(struct sk_buff *skb,
>  }
>  
>  /* Similar to __sock_recv_timestamp, but does not require an skb */
> -void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk,
> +static void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk,
>  			       struct scm_timestamping *tss)

If you change where the openning parenthesis of a function definition
occurs, you have to adjust the indentation of the second line of
arguments so that it starts precisely at the first column after the
openning parenthesis.

Thank you.
diff mbox series

Patch

diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index ca042cdf8496..3d93ae649bbd 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1729,7 +1729,7 @@  static void tcp_update_recv_tstamps(struct sk_buff *skb,
 }
 
 /* Similar to __sock_recv_timestamp, but does not require an skb */
-void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk,
+static void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk,
 			       struct scm_timestamping *tss)
 {
 	struct timeval tv;