| Message ID | 20171221164817.32302-1-romain.naour@gmail.com |
|---|---|
| State | Accepted |
| Commit | 103d283c445ea518cd4529e91c957fc6d2ffdf96 |
| Headers | show |
| Series | package/libcue: is not parallel-safe | expand |
Romain, All, On 2017-12-21 17:48 +0100, Romain Naour spake thusly: > The last commit before the 1.4.0 release was to disable parallel build [1] > > [1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40 > > Fixes: > http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e > http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5 > > Signed-off-by: Romain Naour <romain.naour@gmail.com> Reviewed-by: ME However, isn't it time to update? 1.4.0 was released in 2010, and there have been new releases since then, the most recent, 2.2.0, in November 2017, and they switched to cmake. Regards, Yann E. MORIN. > --- > package/libcue/libcue.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/libcue/libcue.mk b/package/libcue/libcue.mk > index 3aa3b4815f..7f8e45ecec 100644 > --- a/package/libcue/libcue.mk > +++ b/package/libcue/libcue.mk > @@ -12,6 +12,8 @@ LIBCUE_DEPENDENCIES = host-bison host-flex flex > LIBCUE_INSTALL_STAGING = YES > LIBCUE_AUTORECONF = YES > > +LIBCUE_MAKE = $(MAKE1) > + > # Needed for autoreconf > define LIBCUE_MAKE_CONFIG_DIR > mkdir $(@D)/config > -- > 2.14.3 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
On 2017-12-21 18:02 +0100, Yann E. MORIN spake thusly: > Romain, All, > > On 2017-12-21 17:48 +0100, Romain Naour spake thusly: > > The last commit before the 1.4.0 release was to disable parallel build [1] > > > > [1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40 > > > > Fixes: > > http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e > > http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5 > > > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > > Reviewed-by: ME Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> (It seems that I have a hard time with autocompletion, be it on IRC or in email bodies... Sigh...) Regards, Yann E. MORIN. > However, isn't it time to update? 1.4.0 was released in 2010, and there > have been new releases since then, the most recent, 2.2.0, in November > 2017, and they switched to cmake. > > Regards, > Yann E. MORIN. > > > --- > > package/libcue/libcue.mk | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/package/libcue/libcue.mk b/package/libcue/libcue.mk > > index 3aa3b4815f..7f8e45ecec 100644 > > --- a/package/libcue/libcue.mk > > +++ b/package/libcue/libcue.mk > > @@ -12,6 +12,8 @@ LIBCUE_DEPENDENCIES = host-bison host-flex flex > > LIBCUE_INSTALL_STAGING = YES > > LIBCUE_AUTORECONF = YES > > > > +LIBCUE_MAKE = $(MAKE1) > > + > > # Needed for autoreconf > > define LIBCUE_MAKE_CONFIG_DIR > > mkdir $(@D)/config > > -- > > 2.14.3 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes: > The last commit before the 1.4.0 release was to disable parallel build [1] > [1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40 > Fixes: > http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e > http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5 > Signed-off-by: Romain Naour <romain.naour@gmail.com> Committed, thanks.
Hi Peter, Le 22/12/2017 à 10:17, Peter Korsgaard a écrit : >>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes: > > > The last commit before the 1.4.0 release was to disable parallel build [1] > > [1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40 > > > Fixes: > > http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e > > http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5 > > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > > Committed, thanks. > This patch needs to be backported to 2017.08 and 2017.02 branches. http://autobuild.buildroot.net/results/51d/51d585cbf387fb514d04304aa0ea38324a02362e/build-end.log Best regards, Romain
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes: > The last commit before the 1.4.0 release was to disable parallel build [1] > [1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40 > Fixes: > http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e > http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5 > Signed-off-by: Romain Naour <romain.naour@gmail.com> Committed to 2017.11.x, thanks.
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes: > The last commit before the 1.4.0 release was to disable parallel build [1] > [1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40 > Fixes: > http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e > http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5 > Signed-off-by: Romain Naour <romain.naour@gmail.com> Committed to 2017.02.x, thanks.
diff --git a/package/libcue/libcue.mk b/package/libcue/libcue.mk index 3aa3b4815f..7f8e45ecec 100644 --- a/package/libcue/libcue.mk +++ b/package/libcue/libcue.mk @@ -12,6 +12,8 @@ LIBCUE_DEPENDENCIES = host-bison host-flex flex LIBCUE_INSTALL_STAGING = YES LIBCUE_AUTORECONF = YES +LIBCUE_MAKE = $(MAKE1) + # Needed for autoreconf define LIBCUE_MAKE_CONFIG_DIR mkdir $(@D)/config
The last commit before the 1.4.0 release was to disable parallel build [1] [1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40 Fixes: http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5 Signed-off-by: Romain Naour <romain.naour@gmail.com> --- package/libcue/libcue.mk | 2 ++ 1 file changed, 2 insertions(+)