[v4] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings

Message ID 1513768543-7943-1-git-send-email-fabrizio.castro@bp.renesas.com
State Accepted
Headers show
Series
  • [v4] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
Related show

Commit Message

Fabrizio Castro Dec. 20, 2017, 11:15 a.m.
This patch adds compatible strings specific to r8a774[35], no driver
change is needed as the fallback compatible string will activate the
right code.

Also, this patch replaces the example with a DT snippet used
for adding PWM0 support to an r8a7743 based platform as the r8a7743 is
now the first platform fully compatible with this driver and its PWM DT
nodes refer to up-to-date code.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v3->v4:
* The changelog now explains why the patch is replacing the example.

 Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Simon Horman Dec. 20, 2017, 11:47 a.m. | #1
On Wed, Dec 20, 2017 at 11:15:43AM +0000, Fabrizio Castro wrote:
> This patch adds compatible strings specific to r8a774[35], no driver
> change is needed as the fallback compatible string will activate the
> right code.
> 
> Also, this patch replaces the example with a DT snippet used
> for adding PWM0 support to an r8a7743 based platform as the r8a7743 is
> now the first platform fully compatible with this driver and its PWM DT
> nodes refer to up-to-date code.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Fabrizio Castro Jan. 24, 2018, 5:14 p.m. | #2
Hello Thierry,

I am sorry to bother you,  just wondering if this patch has any chance to end up in v4.16?

Thanks,
Fabrizio

> Subject: [PATCH v4] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
>
> This patch adds compatible strings specific to r8a774[35], no driver
> change is needed as the fallback compatible string will activate the
> right code.
>
> Also, this patch replaces the example with a DT snippet used
> for adding PWM0 support to an r8a7743 based platform as the r8a7743 is
> now the first platform fully compatible with this driver and its PWM DT
> nodes refer to up-to-date code.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3->v4:
> * The changelog now explains why the patch is replacing the example.
>
>  Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
> b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
> index 74c1180..f3bba59 100644
> --- a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
> +++ b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
> @@ -2,6 +2,8 @@
>
>  Required Properties:
>  - compatible: should be "renesas,pwm-rcar" and one of the following.
> + - "renesas,pwm-r8a7743": for RZ/G1M
> + - "renesas,pwm-r8a7745": for RZ/G1E
>   - "renesas,pwm-r8a7778": for R-Car M1A
>   - "renesas,pwm-r8a7779": for R-Car H1
>   - "renesas,pwm-r8a7790": for R-Car H2
> @@ -17,13 +19,15 @@ Required Properties:
>  - pinctrl-0: phandle, referring to a default pin configuration node.
>  - pinctrl-names: Set to "default".
>
> -Example: R8A7790 (R-Car H2) PWM Timer node
> +Example: R8A7743 (RZ/G1M) PWM Timer node
>
>  pwm0: pwm@e6e30000 {
> -compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> +compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
>  reg = <0 0xe6e30000 0 0x8>;
> +clocks = <&cpg CPG_MOD 523>;
> +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> +resets = <&cpg 523>;
>  #pwm-cells = <2>;
> -clocks = <&mstp5_clks R8A7790_CLK_PWM>;
>  pinctrl-0 = <&pwm0_pins>;
>  pinctrl-names = "default";
>  };
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Fabrizio Castro March 6, 2018, 4:49 p.m. | #3
Dear All,

I am very sorry to bother you, just wondering if someone can take this patch?

Thanks,
Fab

> -----Original Message-----
> From: Fabrizio Castro
> Sent: 24 January 2018 17:14
> To: Thierry Reding <thierry.reding@gmail.com>
> Cc: linux-pwm@vger.kernel.org; devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>; Geert Uytterhoeven
> <geert+renesas@glider.be>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das <biju.das@bp.renesas.com>; linux-renesas-
> soc@vger.kernel.org; Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>
> Subject: RE: [PATCH v4] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
>
> Hello Thierry,
>
> I am sorry to bother you,  just wondering if this patch has any chance to end up in v4.16?
>
> Thanks,
> Fabrizio
>
> > Subject: [PATCH v4] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
> >
> > This patch adds compatible strings specific to r8a774[35], no driver
> > change is needed as the fallback compatible string will activate the
> > right code.
> >
> > Also, this patch replaces the example with a DT snippet used
> > for adding PWM0 support to an r8a7743 based platform as the r8a7743 is
> > now the first platform fully compatible with this driver and its PWM DT
> > nodes refer to up-to-date code.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v3->v4:
> > * The changelog now explains why the patch is replacing the example.
> >
> >  Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
> > b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
> > index 74c1180..f3bba59 100644
> > --- a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
> > +++ b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
> > @@ -2,6 +2,8 @@
> >
> >  Required Properties:
> >  - compatible: should be "renesas,pwm-rcar" and one of the following.
> > + - "renesas,pwm-r8a7743": for RZ/G1M
> > + - "renesas,pwm-r8a7745": for RZ/G1E
> >   - "renesas,pwm-r8a7778": for R-Car M1A
> >   - "renesas,pwm-r8a7779": for R-Car H1
> >   - "renesas,pwm-r8a7790": for R-Car H2
> > @@ -17,13 +19,15 @@ Required Properties:
> >  - pinctrl-0: phandle, referring to a default pin configuration node.
> >  - pinctrl-names: Set to "default".
> >
> > -Example: R8A7790 (R-Car H2) PWM Timer node
> > +Example: R8A7743 (RZ/G1M) PWM Timer node
> >
> >  pwm0: pwm@e6e30000 {
> > -compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> > +compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
> >  reg = <0 0xe6e30000 0 0x8>;
> > +clocks = <&cpg CPG_MOD 523>;
> > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> > +resets = <&cpg 523>;
> >  #pwm-cells = <2>;
> > -clocks = <&mstp5_clks R8A7790_CLK_PWM>;
> >  pinctrl-0 = <&pwm0_pins>;
> >  pinctrl-names = "default";
> >  };
> > --
> > 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thierry Reding March 27, 2018, 9:52 p.m. | #4
On Wed, Dec 20, 2017 at 11:15:43AM +0000, Fabrizio Castro wrote:
> This patch adds compatible strings specific to r8a774[35], no driver
> change is needed as the fallback compatible string will activate the
> right code.
> 
> Also, this patch replaces the example with a DT snippet used
> for adding PWM0 support to an r8a7743 based platform as the r8a7743 is
> now the first platform fully compatible with this driver and its PWM DT
> nodes refer to up-to-date code.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3->v4:
> * The changelog now explains why the patch is replacing the example.
> 
>  Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

Applied, thanks.

Thierry

Patch

diff --git a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
index 74c1180..f3bba59 100644
--- a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
+++ b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
@@ -2,6 +2,8 @@ 
 
 Required Properties:
 - compatible: should be "renesas,pwm-rcar" and one of the following.
+ - "renesas,pwm-r8a7743": for RZ/G1M
+ - "renesas,pwm-r8a7745": for RZ/G1E
  - "renesas,pwm-r8a7778": for R-Car M1A
  - "renesas,pwm-r8a7779": for R-Car H1
  - "renesas,pwm-r8a7790": for R-Car H2
@@ -17,13 +19,15 @@  Required Properties:
 - pinctrl-0: phandle, referring to a default pin configuration node.
 - pinctrl-names: Set to "default".
 
-Example: R8A7790 (R-Car H2) PWM Timer node
+Example: R8A7743 (RZ/G1M) PWM Timer node
 
 	pwm0: pwm@e6e30000 {
-		compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
+		compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
 		reg = <0 0xe6e30000 0 0x8>;
+		clocks = <&cpg CPG_MOD 523>;
+		power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+		resets = <&cpg 523>;
 		#pwm-cells = <2>;
-		clocks = <&mstp5_clks R8A7790_CLK_PWM>;
 		pinctrl-0 = <&pwm0_pins>;
 		pinctrl-names = "default";
 	};