diff mbox series

[U-Boot,4/4] ARM: tegra: use CONFIG_SYS_INIT_SP_BSS_OFFSET

Message ID 20171220013037.24485-4-swarren@wwwdotorg.org
State Accepted
Commit f097532d279dd7a6ab2d579425d1318051ac1f8d
Delegated to: Tom Warren
Headers show
Series [U-Boot,1/4] ARM: tegra: don't use CONFIG_SPL_TEXT_BASE when no SPL | expand

Commit Message

Stephen Warren Dec. 20, 2017, 1:30 a.m. UTC
From: Stephen Warren <swarren@nvidia.com>

Enable CONFIG_SYS_INIT_SP_BSS_OFFSET for all 64-bit Tegra boards. Place
the stack/... 512KiB from the end of the U-Boot binary. This should be
plenty to accommodate the current DTBs (max 64 KiB), early malloc region
(6KiB), stack usage, and plenty of slack, while still not placing it too
far away from the U-Boot binary.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 arch/arm/mach-tegra/tegra186/Kconfig | 3 +++
 arch/arm/mach-tegra/tegra210/Kconfig | 3 +++
 include/configs/tegra-common.h       | 2 ++
 include/configs/tegra186-common.h    | 5 -----
 include/configs/tegra210-common.h    | 5 -----
 5 files changed, 8 insertions(+), 10 deletions(-)

Comments

Simon Glass Jan. 8, 2018, 3:42 a.m. UTC | #1
On 19 December 2017 at 18:30, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Enable CONFIG_SYS_INIT_SP_BSS_OFFSET for all 64-bit Tegra boards. Place
> the stack/... 512KiB from the end of the U-Boot binary. This should be
> plenty to accommodate the current DTBs (max 64 KiB), early malloc region
> (6KiB), stack usage, and plenty of slack, while still not placing it too
> far away from the U-Boot binary.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  arch/arm/mach-tegra/tegra186/Kconfig | 3 +++
>  arch/arm/mach-tegra/tegra210/Kconfig | 3 +++
>  include/configs/tegra-common.h       | 2 ++
>  include/configs/tegra186-common.h    | 5 -----
>  include/configs/tegra210-common.h    | 5 -----
>  5 files changed, 8 insertions(+), 10 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/arch/arm/mach-tegra/tegra186/Kconfig b/arch/arm/mach-tegra/tegra186/Kconfig
index b2e53b58caf8..479c0955eec6 100644
--- a/arch/arm/mach-tegra/tegra186/Kconfig
+++ b/arch/arm/mach-tegra/tegra186/Kconfig
@@ -21,6 +21,9 @@  endchoice
 config SYS_SOC
 	default "tegra186"
 
+config SYS_INIT_SP_BSS_OFFSET
+	default 524288
+
 source "board/nvidia/p2771-0000/Kconfig"
 
 endif
diff --git a/arch/arm/mach-tegra/tegra210/Kconfig b/arch/arm/mach-tegra/tegra210/Kconfig
index 3637473051b8..250738aed312 100644
--- a/arch/arm/mach-tegra/tegra210/Kconfig
+++ b/arch/arm/mach-tegra/tegra210/Kconfig
@@ -40,6 +40,9 @@  endchoice
 config SYS_SOC
 	default "tegra210"
 
+config SYS_INIT_SP_BSS_OFFSET
+	default 524288
+
 source "board/nvidia/e2220-1170/Kconfig"
 source "board/nvidia/p2371-0000/Kconfig"
 source "board/nvidia/p2371-2180/Kconfig"
diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h
index 75e36c0b759d..2d98a6fa64a7 100644
--- a/include/configs/tegra-common.h
+++ b/include/configs/tegra-common.h
@@ -78,11 +78,13 @@ 
 
 #define CONFIG_SYS_BOOTMAPSZ	(256 << 20)	/* 256M */
 
+#ifndef CONFIG_ARM64
 #define CONFIG_SYS_INIT_RAM_ADDR	CONFIG_STACKBASE
 #define CONFIG_SYS_INIT_RAM_SIZE	CONFIG_SYS_MALLOC_LEN
 #define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_INIT_RAM_ADDR + \
 						CONFIG_SYS_INIT_RAM_SIZE - \
 						GENERATED_GBL_DATA_SIZE)
+#endif
 
 #ifndef CONFIG_ARM64
 /* Defines for SPL */
diff --git a/include/configs/tegra186-common.h b/include/configs/tegra186-common.h
index 495d18555f3f..1c8772a117e4 100644
--- a/include/configs/tegra186-common.h
+++ b/include/configs/tegra186-common.h
@@ -14,11 +14,6 @@ 
  */
 #define V_NS16550_CLK		408000000	/* 408MHz (pllp_out0) */
 
-/*
- * Miscellaneous configurable options
- */
-#define CONFIG_STACKBASE	0x82800000	/* 40MB */
-
 /*-----------------------------------------------------------------------
  * Physical Memory Map
  */
diff --git a/include/configs/tegra210-common.h b/include/configs/tegra210-common.h
index 93c9455e8ff3..35735f3b78e4 100644
--- a/include/configs/tegra210-common.h
+++ b/include/configs/tegra210-common.h
@@ -15,11 +15,6 @@ 
  */
 #define V_NS16550_CLK		408000000	/* 408MHz (pllp_out0) */
 
-/*
- * Miscellaneous configurable options
- */
-#define CONFIG_STACKBASE	0x82800000	/* 40MB */
-
 /*-----------------------------------------------------------------------
  * Physical Memory Map
  */