[v3,2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings

Message ID 1513690500-12165-3-git-send-email-fabrizio.castro@bp.renesas.com
State Superseded
Headers show
Series
  • Add PWM and TPU support to r8a7743
Related show

Commit Message

Fabrizio Castro Dec. 19, 2017, 1:34 p.m.
This patch adds compatible strings specific to r8a774[35], no driver
change is needed as the fallback compatible string will activate the
right code. Also, this patch replaces the example with a DT snippet used
for adding PWM0 support to an r8a7743 based platform.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2->v3:
* No change

 Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Simon Horman Dec. 20, 2017, 8:31 a.m. | #1
On Tue, Dec 19, 2017 at 01:34:57PM +0000, Fabrizio Castro wrote:
> This patch adds compatible strings specific to r8a774[35], no driver
> change is needed as the fallback compatible string will activate the
> right code. Also, this patch replaces the example with a DT snippet used
> for adding PWM0 support to an r8a7743 based platform.

What is the motivation for updating the example?
Could it be stated here?
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Fabrizio Castro Dec. 20, 2017, 9:54 a.m. | #2
Hello Simon,

> Subject: Re: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
>
> On Tue, Dec 19, 2017 at 01:34:57PM +0000, Fabrizio Castro wrote:
> > This patch adds compatible strings specific to r8a774[35], no driver
> > change is needed as the fallback compatible string will activate the
> > right code. Also, this patch replaces the example with a DT snippet used
> > for adding PWM0 support to an r8a7743 based platform.
>
> What is the motivation for updating the example?

I am sorry I forgot to copy the explanation across from the first version of the patch:
https://patchwork.kernel.org/patch/10111831/

"the reason for replacing the example with one of a different SoC is that
the new example refers to recent code from a real use case. I hope that's ok."

Basically the r8a7743 will be the first platform with full upstream support, and I believe it is better to have up-to-date examples proven to work in the documentation.

> Could it be stated here?

Shall I send a new version for this?


Thanks,
Fab


[https://www2.renesas.eu/media/email/unicef_2017.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Dec. 20, 2017, 10:12 a.m. | #3
On Wed, Dec 20, 2017 at 09:54:14AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> > Subject: Re: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
> >
> > On Tue, Dec 19, 2017 at 01:34:57PM +0000, Fabrizio Castro wrote:
> > > This patch adds compatible strings specific to r8a774[35], no driver
> > > change is needed as the fallback compatible string will activate the
> > > right code. Also, this patch replaces the example with a DT snippet used
> > > for adding PWM0 support to an r8a7743 based platform.
> >
> > What is the motivation for updating the example?
> 
> I am sorry I forgot to copy the explanation across from the first version of the patch:
> https://patchwork.kernel.org/patch/10111831/
> 
> "the reason for replacing the example with one of a different SoC is that
> the new example refers to recent code from a real use case. I hope that's ok."
> 
> Basically the r8a7743 will be the first platform with full upstream support, and I believe it is better to have up-to-date examples proven to work in the documentation.

Thanks, that sounds reasonable.

> 
> > Could it be stated here?
> 
> Shall I send a new version for this?

That would be best in my opinion.
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Fabrizio Castro Dec. 20, 2017, 11:15 a.m. | #4
Hello Simon,

> Subject: Re: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
>
> On Wed, Dec 20, 2017 at 09:54:14AM +0000, Fabrizio Castro wrote:
> > Hello Simon,
> >
> > > Subject: Re: [PATCH v3 2/5] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings
> > >
> > > On Tue, Dec 19, 2017 at 01:34:57PM +0000, Fabrizio Castro wrote:
> > > > This patch adds compatible strings specific to r8a774[35], no driver
> > > > change is needed as the fallback compatible string will activate the
> > > > right code. Also, this patch replaces the example with a DT snippet used
> > > > for adding PWM0 support to an r8a7743 based platform.
> > >
> > > What is the motivation for updating the example?
> >
> > I am sorry I forgot to copy the explanation across from the first version of the patch:
> > https://patchwork.kernel.org/patch/10111831/
> >
> > "the reason for replacing the example with one of a different SoC is that
> > the new example refers to recent code from a real use case. I hope that's ok."
> >
> > Basically the r8a7743 will be the first platform with full upstream support, and I believe it is better to have up-to-date examples
> proven to work in the documentation.
>
> Thanks, that sounds reasonable.
>
> >
> > > Could it be stated here?
> >
> > Shall I send a new version for this?
>
> That would be best in my opinion.

Thank you for your feedback, I'll send a new version separately (not in the context of this series anymore as the pending patches from this series are dt-bindings related) to enhance the changelog.

Cheers,
Fab


[https://www2.renesas.eu/media/email/unicef_2017.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
index 74c1180..f3bba59 100644
--- a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
+++ b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
@@ -2,6 +2,8 @@ 
 
 Required Properties:
 - compatible: should be "renesas,pwm-rcar" and one of the following.
+ - "renesas,pwm-r8a7743": for RZ/G1M
+ - "renesas,pwm-r8a7745": for RZ/G1E
  - "renesas,pwm-r8a7778": for R-Car M1A
  - "renesas,pwm-r8a7779": for R-Car H1
  - "renesas,pwm-r8a7790": for R-Car H2
@@ -17,13 +19,15 @@  Required Properties:
 - pinctrl-0: phandle, referring to a default pin configuration node.
 - pinctrl-names: Set to "default".
 
-Example: R8A7790 (R-Car H2) PWM Timer node
+Example: R8A7743 (RZ/G1M) PWM Timer node
 
 	pwm0: pwm@e6e30000 {
-		compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
+		compatible = "renesas,pwm-r8a7743", "renesas,pwm-rcar";
 		reg = <0 0xe6e30000 0 0x8>;
+		clocks = <&cpg CPG_MOD 523>;
+		power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+		resets = <&cpg 523>;
 		#pwm-cells = <2>;
-		clocks = <&mstp5_clks R8A7790_CLK_PWM>;
 		pinctrl-0 = <&pwm0_pins>;
 		pinctrl-names = "default";
 	};