| Message ID | 1513623248-7689-3-git-send-email-serhe.popovych@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | Improve iplink index, alias and name parameters handling | expand |
diff --git a/ip/iplink.c b/ip/iplink.c index 4f9c169..4c96711 100644 --- a/ip/iplink.c +++ b/ip/iplink.c @@ -770,11 +770,12 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req, argc--; argv++; break; } else if (matches(*argv, "alias") == 0) { + len = strlen(*argv); + if (len >= IFALIASZ) + invarg("alias too long\n", *argv); NEXT_ARG(); addattr_l(&req->n, sizeof(*req), IFLA_IFALIAS, - *argv, strlen(*argv)); - argc--; argv++; - break; + *argv, len); } else if (strcmp(*argv, "group") == 0) { NEXT_ARG(); if (*group != -1)
Do not stop parameters processing after "alias" parameter: it might not be a last one. Seems copy pasted from "type" parameter code. Check it's length does not exceed IFALIASZ - 1. Better we warn than get RTNL error. Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> --- ip/iplink.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)