[RFC,linux-next] CIFS: SMBD: _smbd_get_connection() can be static

Message ID 20171218133006.GA79761@cairo
State New
Headers show
Series
  • [RFC,linux-next] CIFS: SMBD: _smbd_get_connection() can be static
Related show

Commit Message

kbuild test robot Dec. 18, 2017, 1:30 p.m.
Fixes: 07495ff5d9bc ("CIFS: SMBD: Establish SMB Direct connection")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 smbdirect.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Long Li Dec. 18, 2017, 9:44 p.m. | #1
> Fixes: 07495ff5d9bc ("CIFS: SMBD: Establish SMB Direct connection")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Acked-by: Long Li <longli@microsoft.com>

Thanks.

> ---
>  smbdirect.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c index 2ecd5c1..62a5c3f
> 100644
> --- a/fs/cifs/smbdirect.c
> +++ b/fs/cifs/smbdirect.c
> @@ -1462,7 +1462,7 @@ static int allocate_caches_and_workqueue(struct
> smbd_connection *info)  }
> 
>  /* Create a SMBD connection, called by upper layer */ -struct
> smbd_connection *_smbd_get_connection(
> +static struct smbd_connection *_smbd_get_connection(
>  	struct TCP_Server_Info *server, struct sockaddr *dstaddr, int port)  {
>  	int rc;
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steve French Jan. 3, 2018, 11:15 p.m. | #2
merged into cifs-2.6.git for-next thx

On Mon, Dec 18, 2017 at 7:30 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:
>
> Fixes: 07495ff5d9bc ("CIFS: SMBD: Establish SMB Direct connection")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  smbdirect.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c
> index 2ecd5c1..62a5c3f 100644
> --- a/fs/cifs/smbdirect.c
> +++ b/fs/cifs/smbdirect.c
> @@ -1462,7 +1462,7 @@ static int allocate_caches_and_workqueue(struct smbd_connection *info)
>  }
>
>  /* Create a SMBD connection, called by upper layer */
> -struct smbd_connection *_smbd_get_connection(
> +static struct smbd_connection *_smbd_get_connection(
>         struct TCP_Server_Info *server, struct sockaddr *dstaddr, int port)
>  {
>         int rc;

Patch

diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c
index 2ecd5c1..62a5c3f 100644
--- a/fs/cifs/smbdirect.c
+++ b/fs/cifs/smbdirect.c
@@ -1462,7 +1462,7 @@  static int allocate_caches_and_workqueue(struct smbd_connection *info)
 }
 
 /* Create a SMBD connection, called by upper layer */
-struct smbd_connection *_smbd_get_connection(
+static struct smbd_connection *_smbd_get_connection(
 	struct TCP_Server_Info *server, struct sockaddr *dstaddr, int port)
 {
 	int rc;