Patchwork NAND: DaVinci: Removed header file that is not required

login
register
mail settings
Submitter Sandeep Paulraj
Date March 1, 2011, 10:40 p.m.
Message ID <1299019251-19518-1-git-send-email-s-paulraj@ti.com>
Download mbox | patch
Permalink /patch/84996/
State Accepted
Commit f43272c482661bc88347bba237976eecfc1dbf5b
Headers show

Comments

Sandeep Paulraj - March 1, 2011, 10:40 p.m.
From: Sandeep Paulraj <s-paulraj@ti.com>

The DaVinci NAND driver was including the mach-types.h header
file.
This prevented the DaVinci NAND driver from getting used
in a DSP only device. The linux port on c6x devices can make
use of the same driver and does not define a corresponding
header file; so removing it.

Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
---
 drivers/mtd/nand/davinci_nand.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
Artem Bityutskiy - March 7, 2011, 9:01 a.m.
On Tue, 2011-03-01 at 17:40 -0500, s-paulraj@ti.com wrote:
> From: Sandeep Paulraj <s-paulraj@ti.com>
> 
> The DaVinci NAND driver was including the mach-types.h header
> file.
> This prevented the DaVinci NAND driver from getting used
> in a DSP only device. The linux port on c6x devices can make
> use of the same driver and does not define a corresponding
> header file; so removing it.
> 
> Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>

Hi,

you explain why this include is bad for DSP. Buy you do not explain why
this include is there and why removing it is harmless for Linux.
Sandeep Paulraj - March 7, 2011, 2:57 p.m.
> 
> On Tue, 2011-03-01 at 17:40 -0500, s-paulraj@ti.com wrote:
> > From: Sandeep Paulraj <s-paulraj@ti.com>
> >
> > The DaVinci NAND driver was including the mach-types.h header
> > file.
> > This prevented the DaVinci NAND driver from getting used
> > in a DSP only device. The linux port on c6x devices can make
> > use of the same driver and does not define a corresponding
> > header file; so removing it.
> >
> > Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
> 
> Hi,
> 
> you explain why this include is bad for DSP. Buy you do not explain why
> this include is there and why removing it is harmless for Linux.
> 

Hi,

This header file was required in the driver because earlier there was code dependent on a machine_* check. This piece of code has now been factored out and is in /arch/arm/mach-davinci/aemif.c.

Thus removing it is harmless.

Please do let me know if you need an updated patch.

Regards,
Sandeep
Artem Bityutskiy - March 7, 2011, 5:57 p.m.
On Mon, 2011-03-07 at 08:57 -0600, Paulraj, Sandeep wrote:
> > 
> > On Tue, 2011-03-01 at 17:40 -0500, s-paulraj@ti.com wrote:
> > > From: Sandeep Paulraj <s-paulraj@ti.com>
> > >
> > > The DaVinci NAND driver was including the mach-types.h header
> > > file.
> > > This prevented the DaVinci NAND driver from getting used
> > > in a DSP only device. The linux port on c6x devices can make
> > > use of the same driver and does not define a corresponding
> > > header file; so removing it.
> > >
> > > Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
> > 
> > Hi,
> > 
> > you explain why this include is bad for DSP. Buy you do not explain
> why
> > this include is there and why removing it is harmless for Linux.
> > 
> 
> Hi,
> 
> This header file was required in the driver because earlier there was
> code dependent on a machine_* check. This piece of code has now been
> factored out and is in /arch/arm/mach-davinci/aemif.c.
> 
> Thus removing it is harmless.
> 
> Please do let me know if you need an updated patch.

Yes, please, patch description should contain this important
information.

Patch

diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index a90fde3..aff3468 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -37,9 +37,6 @@ 
 #include <mach/nand.h>
 #include <mach/aemif.h>
 
-#include <asm/mach-types.h>
-
-
 /*
  * This is a device driver for the NAND flash controller found on the
  * various DaVinci family chips.  It handles up to four SoC chipselects,