diff mbox series

io: fix QIONetListener memory leak

Message ID 20171218085308.23241-1-pbonzini@redhat.com
State New
Headers show
Series io: fix QIONetListener memory leak | expand

Commit Message

Paolo Bonzini Dec. 18, 2017, 8:53 a.m. UTC 
The sources array does not escape out of qio_net_listener_wait_client, so
we have to free it.

Reported by Coverity.

Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 io/net-listener.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniel P. Berrangé Dec. 18, 2017, 9:32 a.m. UTC | #1 
On Mon, Dec 18, 2017 at 09:53:08AM +0100, Paolo Bonzini wrote:
> The sources array does not escape out of qio_net_listener_wait_client, so
> we have to free it.
> 
> Reported by Coverity.
> 
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  io/net-listener.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks, queued.


Regards,
Daniel
diff mbox series

Patch

diff --git a/io/net-listener.c b/io/net-listener.c
index 77a4e2831c..de38dfae99 100644
--- a/io/net-listener.c
+++ b/io/net-listener.c
@@ -234,6 +234,7 @@  QIOChannelSocket *qio_net_listener_wait_client(QIONetListener *listener)
     for (i = 0; i < listener->nsioc; i++) {
         g_source_unref(sources[i]);
     }
+    g_free(sources);
     g_main_loop_unref(loop);
     g_main_context_unref(ctxt);