From patchwork Mon Dec 18 08:43:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 849882 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z0ZLl0nwyz9s82 for ; Mon, 18 Dec 2017 19:43:27 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 28B6E86D7E; Mon, 18 Dec 2017 08:43:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VpXq8Ub5+zGl; Mon, 18 Dec 2017 08:43:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id E3DED86DA6; Mon, 18 Dec 2017 08:43:21 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 239231C104C for ; Mon, 18 Dec 2017 08:43:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1E32A2EB94 for ; Mon, 18 Dec 2017 08:43:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eCPmUjFuL87K for ; Mon, 18 Dec 2017 08:43:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by silver.osuosl.org (Postfix) with ESMTP id 994882480E for ; Mon, 18 Dec 2017 08:43:19 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 110) id 64E00206A6; Mon, 18 Dec 2017 09:43:17 +0100 (CET) Received: from localhost (unknown [88.128.81.165]) by mail.free-electrons.com (Postfix) with ESMTPSA id B432C203B4; Mon, 18 Dec 2017 09:43:06 +0100 (CET) From: Thomas Petazzoni To: buildroot@buildroot.org Date: Mon, 18 Dec 2017 09:43:03 +0100 Message-Id: <20171218084303.12472-1-thomas.petazzoni@free-electrons.com> X-Mailer: git-send-email 2.14.3 Subject: [Buildroot] [PATCH] utils/checkpackagelib: exclude two files from Config.in indentation check X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , Ricardo Martincoski MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" package/x11r7/Config.in and package/kodi/Config.in do not comply with the normal Config.in indentation rules. However, this violation of the rule is legitimate, so let's skip them in check-package for this specific indentation check. This removes the last 314 remaining warnings on Config.in files. Signed-off-by: Thomas Petazzoni --- Note: I am not totally sure about this patch. Indeed package/Config.in uses the same rule as package/{x11r7,kodi}/Config.in, but check-package doesn't report warnings about it. Perhaps I'm missing something in the check-package logic. --- utils/checkpackagelib/lib_config.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/utils/checkpackagelib/lib_config.py b/utils/checkpackagelib/lib_config.py index 26ebb393d1..fb39182b91 100644 --- a/utils/checkpackagelib/lib_config.py +++ b/utils/checkpackagelib/lib_config.py @@ -133,6 +133,10 @@ class Indent(_CheckFunction): text] elif entry in entries_that_should_not_be_indented: if not text.startswith(entry): + # two Config.in files have a special but legitimate indentation rule + if self.filename in [ "./package/x11r7/Config.in", + "./package/kodi/Config.in" ]: + return return ["{}:{}: should not be indented" .format(self.filename, lineno), text]