[v2,4/4] usb: host: ehci-tegra: Remove USB_PHY dependencies from Kconfig

Message ID 73bed692785827e01d11859f721e07c29a41510b.1513528011.git.digetx@gmail.com
State New
Headers show
Series
  • [v2,1/4] usb: phy: tegra: Cleanup error messages
Related show

Commit Message

Dmitry Osipenko Dec. 17, 2017, 5:07 p.m.
Previously tegra-phy driver was built only when ehci-tegra was, now
tegra-phy has its own Kconfig entry. Remove the USB_PHY dependencies
from ehci-tegra's Kconfig since they aren't useful anymore.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/usb/host/Kconfig | 3 ---
 1 file changed, 3 deletions(-)

Comments

Alan Stern Dec. 19, 2017, 5:52 p.m. | #1
On Sun, 17 Dec 2017, Dmitry Osipenko wrote:

> Previously tegra-phy driver was built only when ehci-tegra was, now
> tegra-phy has its own Kconfig entry. Remove the USB_PHY dependencies
> from ehci-tegra's Kconfig since they aren't useful anymore.

Are you sure they aren't useful?  Does this mean it is now
possible/useful to configure a kernel with USB_EHCI_TEGRA enabled and
USB_PHY disabled?

> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/usb/host/Kconfig | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 6150bed7cfa8..5042e72c1b76 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -234,9 +234,6 @@ config USB_EHCI_TEGRA
>         tristate "NVIDIA Tegra HCD support"
>         depends on ARCH_TEGRA
>         select USB_EHCI_ROOT_HUB_TT
> -       select USB_PHY
> -	select USB_ULPI
> -	select USB_ULPI_VIEWPORT

Maybe you should add

	select USB_TEGRA_PHY

here.  Also, what happened to USB_ULPI_VIEWPORT?  Is it still 
important?  If not, then what changed?

Alan Stern

>         help
>           This driver enables support for the internal USB Host Controllers
>           found in NVIDIA Tegra SoCs. The controllers are EHCI compliant.
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dmitry Osipenko Dec. 19, 2017, 6:32 p.m. | #2
On 19.12.2017 20:52, Alan Stern wrote:
> On Sun, 17 Dec 2017, Dmitry Osipenko wrote:
> 
>> Previously tegra-phy driver was built only when ehci-tegra was, now
>> tegra-phy has its own Kconfig entry. Remove the USB_PHY dependencies
>> from ehci-tegra's Kconfig since they aren't useful anymore.
> 
> Are you sure they aren't useful?  Does this mean it is now
> possible/useful to configure a kernel with USB_EHCI_TEGRA enabled and
> USB_PHY disabled?

I'm not entirely sure that USB_TEGRA_PHY isn't useful because initially (in V1)
I proposed to do the other way around, to select PHY when ehci-tegra / chipidea
drivers are enabled. But that proposal wasn't very successful [0][1]. Yes, it
means that ehci-tegra could be built without the tegra-phy.

The USB_ULPI option isn't needed for compiling ehci-tegra, but for tegra-phy
driver. I've moved that option to the tegra-phy's Kconfig, see the previous
patch in the series ("Add Kconfig entry for Tegra PHY driver").

[0] https://marc.info/?l=linux-tegra&m=151307881119328
[1] https://marc.info/?l=linux-tegra&m=151294749618823

>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  drivers/usb/host/Kconfig | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index 6150bed7cfa8..5042e72c1b76 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -234,9 +234,6 @@ config USB_EHCI_TEGRA
>>         tristate "NVIDIA Tegra HCD support"
>>         depends on ARCH_TEGRA
>>         select USB_EHCI_ROOT_HUB_TT
>> -       select USB_PHY
>> -	select USB_ULPI
>> -	select USB_ULPI_VIEWPORT
> 
> Maybe you should add
> 
> 	select USB_TEGRA_PHY
> 
> here.  Also, what happened to USB_ULPI_VIEWPORT?  Is it still 
> important?  If not, then what changed?

USB_ULPI_VIEWPORT is selected by USB_ULPI, so we don't need to duplicate the
selection. See drivers/usb/phy/Kconfig.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 6150bed7cfa8..5042e72c1b76 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -234,9 +234,6 @@  config USB_EHCI_TEGRA
        tristate "NVIDIA Tegra HCD support"
        depends on ARCH_TEGRA
        select USB_EHCI_ROOT_HUB_TT
-       select USB_PHY
-	select USB_ULPI
-	select USB_ULPI_VIEWPORT
        help
          This driver enables support for the internal USB Host Controllers
          found in NVIDIA Tegra SoCs. The controllers are EHCI compliant.