Message ID | 20171216073417.29847-1-chen_han_xiao@126.com |
---|---|
State | New |
Headers | show |
Series | qga: unset frozen state if no mount points are frozen | expand |
At 2017-12-16 15:34:17, "Chen Hanxiao" <chen_han_xiao@126.com> wrote: >From: Chen Hanxiao <chenhanxiao@gmail.com> > >If we set mountpoints to qmp_guest_fsfreeze_freeze_list, >we may got nothing to freeze as all mountpoints are >not valid. >Call ga_unset_frozen in this senario. > >Cc: Michael Roth <mdroth@linux.vnet.ibm.com> >Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com> >--- > qga/commands-posix.c | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/qga/commands-posix.c b/qga/commands-posix.c >index e809e382eb..9fd51f1d7a 100644 >--- a/qga/commands-posix.c >+++ b/qga/commands-posix.c >@@ -1273,6 +1273,12 @@ int64_t qmp_guest_fsfreeze_freeze_list(bool has_mountpoints, > } > > free_fs_mount_list(&mounts); >+ /* We may not issue any FIFREEZE here when had mountpoints. >+ * Just unset ga_state here and ready for the next call. >+ */ >+ if (has_mountpoints && i == 0) { >+ ga_unset_frozen(ga_state); >+ } > return i; > > error: >-- Hi, Any comments? Regards, - Chen
diff --git a/qga/commands-posix.c b/qga/commands-posix.c index e809e382eb..9fd51f1d7a 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -1273,6 +1273,12 @@ int64_t qmp_guest_fsfreeze_freeze_list(bool has_mountpoints, } free_fs_mount_list(&mounts); + /* We may not issue any FIFREEZE here when had mountpoints. + * Just unset ga_state here and ready for the next call. + */ + if (has_mountpoints && i == 0) { + ga_unset_frozen(ga_state); + } return i; error: