[v2,1/2] iqvlinux: bump to version 1.2.0.3

Message ID 20171215153830.4864-1-casantos@datacom.ind.br
State New
Headers show
Series
  • [v2,1/2] iqvlinux: bump to version 1.2.0.3
Related show

Commit Message

Carlos Santos Dec. 15, 2017, 3:38 p.m.
This package is really annoying since the archive name doesn't contain
the version. Use a small trick to save it with a better name. Also add
hashes for license files.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
---
Changes v1->v2:
  - Move comment about the patch, in package/iqvlinux/Config.in, to the
    next commit.
  - Use a small trick to save the source file with a better name.
---
 package/iqvlinux/Config.in     |  2 +-
 package/iqvlinux/iqvlinux.hash |  9 +++++----
 package/iqvlinux/iqvlinux.mk   | 17 ++++++++++++++---
 3 files changed, 20 insertions(+), 8 deletions(-)

Comments

Thomas Petazzoni Dec. 16, 2017, 2:50 p.m. | #1
Hello,

On Fri, 15 Dec 2017 13:38:29 -0200, Carlos Santos wrote:
> This package is really annoying since the archive name doesn't contain
> the version. Use a small trick to save it with a better name. Also add
> hashes for license files.

Have you tried contacting upstreaming to see if they would be willing
to use a more regular tarball naming scheme ?

Thanks!

Thomas
Carlos Santos Dec. 16, 2017, 7:03 p.m. | #2
> From: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
> To: "Carlos Santos" <casantos@datacom.ind.br>
> Cc: buildroot@buildroot.org, "Romain Naour" <romain.naour@gmail.com>
> Sent: Saturday, December 16, 2017 12:50:53 PM
> Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3

> Hello,
> 
> On Fri, 15 Dec 2017 13:38:29 -0200, Carlos Santos wrote:
>> This package is really annoying since the archive name doesn't contain
>> the version. Use a small trick to save it with a better name. Also add
>> hashes for license files.
> 
> Have you tried contacting upstreaming to see if they would be willing
> to use a more regular tarball naming scheme ?

I will try it. Meanwhile we need a temporary solution.
Carlos Santos Dec. 16, 2017, 7:53 p.m. | #3
> From: "Carlos Santos" <casantos@datacom.ind.br>
> To: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
> Cc: "Romain Naour" <romain.naour@gmail.com>, buildroot@buildroot.org
> Sent: Saturday, December 16, 2017 5:03:08 PM
> Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3

>> From: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
>> To: "Carlos Santos" <casantos@datacom.ind.br>
>> Cc: buildroot@buildroot.org, "Romain Naour" <romain.naour@gmail.com>
>> Sent: Saturday, December 16, 2017 12:50:53 PM
>> Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3
> 
>> Hello,
>> 
>> On Fri, 15 Dec 2017 13:38:29 -0200, Carlos Santos wrote:
>>> This package is really annoying since the archive name doesn't contain
>>> the version. Use a small trick to save it with a better name. Also add
>>> hashes for license files.
>> 
>> Have you tried contacting upstreaming to see if they would be willing
>> to use a more regular tarball naming scheme ?
> 
> I will try it. Meanwhile we need a temporary solution.

BTW, I their current naming scheme is already reasonable, since each
release use a separate path. Those who download the file can save it
with a different name. That's not rocket science.
Thomas Petazzoni Dec. 17, 2017, 4:05 a.m. | #4
Hello,

On Sat, 16 Dec 2017 17:53:12 -0200 (BRST), Carlos Santos wrote:

> > I will try it. Meanwhile we need a temporary solution.  
> 
> BTW, I their current naming scheme is already reasonable, since each
> release use a separate path. Those who download the file can save it
> with a different name. That's not rocket science.

Except it's totally uncommon, and many people save tarballs in a single
folder. What they do is contrary to the practice of pretty much every
other open-source project.

Thomas
Thomas Petazzoni Jan. 9, 2018, 9:56 a.m. | #5
Hello Carlos,

On Sun, 17 Dec 2017 05:05:54 +0100, Thomas Petazzoni wrote:
> On Sat, 16 Dec 2017 17:53:12 -0200 (BRST), Carlos Santos wrote:
> 
> > > I will try it. Meanwhile we need a temporary solution.    
> > 
> > BTW, I their current naming scheme is already reasonable, since each
> > release use a separate path. Those who download the file can save it
> > with a different name. That's not rocket science.  
> 
> Except it's totally uncommon, and many people save tarballs in a single
> folder. What they do is contrary to the practice of pretty much every
> other open-source project.

In the end, did you get the chance to raise the issue of the tarball
name with the upstream developers ?

Thanks!

Thomas
Carlos Santos Jan. 10, 2018, 1:56 a.m. | #6
> From: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
> To: "Carlos Santos" <casantos@datacom.ind.br>
> Cc: "Romain Naour" <romain.naour@gmail.com>, buildroot@buildroot.org
> Sent: Tuesday, January 9, 2018 7:56:28 AM
> Subject: Re: [Buildroot] [PATCH v2 1/2] iqvlinux: bump to version 1.2.0.3

> Hello Carlos,
> 
> On Sun, 17 Dec 2017 05:05:54 +0100, Thomas Petazzoni wrote:
>> On Sat, 16 Dec 2017 17:53:12 -0200 (BRST), Carlos Santos wrote:
>> 
>> > > I will try it. Meanwhile we need a temporary solution.
>> > 
>> > BTW, I their current naming scheme is already reasonable, since each
>> > release use a separate path. Those who download the file can save it
>> > with a different name. That's not rocket science.
>> 
>> Except it's totally uncommon, and many people save tarballs in a single
>> folder. What they do is contrary to the practice of pretty much every
>> other open-source project.
> 
> In the end, did you get the chance to raise the issue of the tarball
> name with the upstream developers ?

Thanks for reminding me of this issue. I just submitted a ticket:

    https://sourceforge.net/p/e1000/bugs/589/

Patch

diff --git a/package/iqvlinux/Config.in b/package/iqvlinux/Config.in
index 8959955745..09502d141e 100644
--- a/package/iqvlinux/Config.in
+++ b/package/iqvlinux/Config.in
@@ -12,7 +12,7 @@  config BR2_PACKAGE_IQVLINUX
 	  Note: This driver requires PCI support to be enabled
 	  (i.e. CONFIG_PCI).
 
-	  http://sourceforge.net/projects/e1000/files/iqvlinux/
+	  https://sourceforge.net/projects/e1000/files/iqvlinux/
 
 comment "iqvlinux needs a Linux kernel to be built"
 	depends on !BR2_LINUX_KERNEL
diff --git a/package/iqvlinux/iqvlinux.hash b/package/iqvlinux/iqvlinux.hash
index ddf57b712c..20d612ddc5 100644
--- a/package/iqvlinux/iqvlinux.hash
+++ b/package/iqvlinux/iqvlinux.hash
@@ -1,5 +1,6 @@ 
-# From http://sourceforge.net/projects/e1000/files/iqvlinux/1.1.5.3/
-sha1	bd94416e4364015dbbd78a22e51080bf7ea81fac	iqvlinux.tar.gz
-md5	fb6a2a4dc122d39070fcb06985c97a05	iqvlinux.tar.gz
 # locally computed
-sha256	8cb19f3bfe040100a13bb2d05cb2b54f2b259e55cef23f8cc5aa6f2f31e98bec	iqvlinux.tar.gz
+sha256	4020a661940ba6d50f24654b90a41280eb8eccf00061fe6d105c654d3d97d551  iqvlinux-1.2.0.3.tar.gz
+sha256	386086e232db4708770f717595d4f83188f776aa6e7313cd12fb039e869f494b  COPYING
+sha256	beded926a8f18aad5d911daf581759e2b25697588034d2b29033ae1a929506ff  src/linux/driver/files.txt
+sha256	ecf93b9b739fc82f7b87b34f8c6411dfdd271234af2fe45212293d9df2b654b3  inc/linux/files.txt
+sha256	0a309350c1b32be72479e8fe08f7f6bbbad2e8c3d9a1cbcad3d482ea48a236ad  inc/files.txt
diff --git a/package/iqvlinux/iqvlinux.mk b/package/iqvlinux/iqvlinux.mk
index 165c7c4687..a00f85c0bc 100644
--- a/package/iqvlinux/iqvlinux.mk
+++ b/package/iqvlinux/iqvlinux.mk
@@ -4,9 +4,8 @@ 
 #
 ################################################################################
 
-IQVLINUX_VERSION = 1.1.5.3
-IQVLINUX_SITE = http://sourceforge.net/projects/e1000/files/iqvlinux/$(IQVLINUX_VERSION)
-IQVLINUX_SOURCE = iqvlinux.tar.gz
+IQVLINUX_VERSION = 1.2.0.3
+IQVLINUX_SITE = https://downloads.sourceforge.net/project/e1000/iqvlinux/$(IQVLINUX_VERSION)
 
 IQVLINUX_LICENSE = GPL-2.0, BSD-3-Clause
 IQVLINUX_LICENSE_FILES = \
@@ -17,5 +16,17 @@  IQVLINUX_MODULE_MAKE_OPTS = NALDIR=$(@D) KSRC=$(LINUX_DIR) CC=$(TARGET_CC)
 
 IQVLINUX_MODULE_SUBDIRS = src/linux/driver
 
+# This package is really annoying since the archive name doesn't contain the
+# version. Use a small trick to save it with a better name.
+define IQVLINUX_DOWNLOAD
+	$(EXTRA_ENV) $(DL_WRAPPER) -b wget \
+		-o $(DL_DIR)/$(IQVLINUX_SOURCE) \
+		-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \
+		-- \
+		$(IQVLINUX_SITE)/iqvlinux.tar.gz
+endef
+
+IQVLINUX_PRE_DOWNLOAD_HOOKS = IQVLINUX_DOWNLOAD
+
 $(eval $(kernel-module))
 $(eval $(generic-package))