From patchwork Tue Mar 1 09:49:42 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 84921 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DEC6EB714D for ; Tue, 1 Mar 2011 20:52:56 +1100 (EST) Received: from localhost ([127.0.0.1]:57502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuMGD-0002Gv-VZ for incoming@patchwork.ozlabs.org; Tue, 01 Mar 2011 04:52:54 -0500 Received: from [140.186.70.92] (port=46453 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuMBK-0000EH-31 for qemu-devel@nongnu.org; Tue, 01 Mar 2011 04:47:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuMBI-0002P4-G2 for qemu-devel@nongnu.org; Tue, 01 Mar 2011 04:47:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuMBI-0002Oj-7B for qemu-devel@nongnu.org; Tue, 01 Mar 2011 04:47:48 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p219lloa005589 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 1 Mar 2011 04:47:47 -0500 Received: from dhcp-5-188.str.redhat.com (vpn2-10-246.ams2.redhat.com [10.36.10.246]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p219liWx014084; Tue, 1 Mar 2011 04:47:45 -0500 From: Kevin Wolf To: qemu-devel@nongnu.org Date: Tue, 1 Mar 2011 10:49:42 +0100 Message-Id: <1298972982-7609-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com Subject: [Qemu-devel] [PATCH] Add error message for loading snapshot without VM state X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It already fails, but it didn't tell the user why. Signed-off-by: Kevin Wolf Reviewed-by: Juan Quintela --- savevm.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index a50fd31..6e026a8 100644 --- a/savevm.c +++ b/savevm.c @@ -1996,6 +1996,8 @@ int load_vmstate(const char *name) if (ret < 0) { return ret; } else if (sn.vm_state_size == 0) { + error_report("This is a disk-only snapshot. Revert to it offline " + "using qemu-img."); return -EINVAL; }