| Message ID | 20171215081455.11941-1-bsingharora@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 04b9c96eae72d862726f2f4bfcec2078240c33c5 |
| Headers | show |
| Series | [v4,1/2] powerpc/crash: Remove the test for cpu_online in the IPI callback | expand |
On Fri, 15 Dec 2017 19:14:54 +1100 Balbir Singh <bsingharora@gmail.com> wrote: > Our check was extra cautious, we've audited crash_send_ipi > and it sends an IPI only to online CPU's. Removal of this > check should have not functional impact on crash kdump. > Reviewed-by: Nicholas Piggin <npiggin@gmail.com> > Signed-off-by: Balbir Singh <bsingharora@gmail.com> > --- > arch/powerpc/kernel/crash.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c > index cbabb5adccd9..29c56ca2ddfd 100644 > --- a/arch/powerpc/kernel/crash.c > +++ b/arch/powerpc/kernel/crash.c > @@ -69,9 +69,6 @@ static void crash_ipi_callback(struct pt_regs *regs) > > int cpu = smp_processor_id(); > > - if (!cpu_online(cpu)) > - return; > - > hard_irq_disable(); > if (!cpumask_test_cpu(cpu, &cpus_state_saved)) { > crash_save_cpu(regs, cpu);
On Fri, 2017-12-15 at 08:14:54 UTC, Balbir Singh wrote: > Our check was extra cautious, we've audited crash_send_ipi > and it sends an IPI only to online CPU's. Removal of this > check should have not functional impact on crash kdump. > > Signed-off-by: Balbir Singh <bsingharora@gmail.com> > Reviewed-by: Nicholas Piggin <npiggin@gmail.com> Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/04b9c96eae72d862726f2f4bfcec20 cheers
diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c index cbabb5adccd9..29c56ca2ddfd 100644 --- a/arch/powerpc/kernel/crash.c +++ b/arch/powerpc/kernel/crash.c @@ -69,9 +69,6 @@ static void crash_ipi_callback(struct pt_regs *regs) int cpu = smp_processor_id(); - if (!cpu_online(cpu)) - return; - hard_irq_disable(); if (!cpumask_test_cpu(cpu, &cpus_state_saved)) { crash_save_cpu(regs, cpu);
Our check was extra cautious, we've audited crash_send_ipi and it sends an IPI only to online CPU's. Removal of this check should have not functional impact on crash kdump. Signed-off-by: Balbir Singh <bsingharora@gmail.com> --- arch/powerpc/kernel/crash.c | 3 --- 1 file changed, 3 deletions(-)