| Message ID | 20171215061332.42133-1-qiang.zhao@nxp.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: phy: marvell: enable a errata for 88E1145 | expand |
From: Zhao Qiang <qiang.zhao@nxp.com> Date: Fri, 15 Dec 2017 14:13:32 +0800 > The patch below > commit f2899788353c ("net: phy: marvell: Limit errata to 88m1101") > limit a errata's scope to 88E1101. > However, 88E1145 also need this errata, set config_aneg to > m88e1101_config_aneg for 88E1145 > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> The proper way to say that a patch fixes a particular commit it to reference it in a "Fixes: " tag, like this: ==================== Fixes: f2899788353c ("net: phy: marvell: Limit errata to 88m1101") Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> ==================== And then you don't need to reference it explicitly in your commit message, you can just instead say: Limit 88m1101 autoneg errata to 88E1145 as well. Please fix up your submission like this and resubmit. Thank you.
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 4d02b27..a3f456b 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -2069,7 +2069,7 @@ static int m88e1510_probe(struct phy_device *phydev) .flags = PHY_HAS_INTERRUPT, .probe = marvell_probe, .config_init = &m88e1145_config_init, - .config_aneg = &marvell_config_aneg, + .config_aneg = &m88e1101_config_aneg, .read_status = &genphy_read_status, .ack_interrupt = &marvell_ack_interrupt, .config_intr = &marvell_config_intr,
The patch below commit f2899788353c ("net: phy: marvell: Limit errata to 88m1101") limit a errata's scope to 88E1101. However, 88E1145 also need this errata, set config_aneg to m88e1101_config_aneg for 88E1145 Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> --- drivers/net/phy/marvell.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)