Message ID | 20171214171004.25058-1-cohuck@redhat.com |
---|---|
State | New |
Headers | show |
Contains the following commit:
- pc-bios/s390-ccw: zero out bss section
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
pc-bios/s390-ccw.img | Bin 26416 -> 26416 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img
index 7415f1a3e797a17ce4ede0ee39034288b4ecae86..97155d2638eebc1220a63287fcada21df65b3a77 100644
GIT binary patch
delta 1426
zcmYLJT}%{L6h3EISr;e_umTG#4$C6lg0Qj{s)*giwU!p@@?*uHs7*v4G`d>q4@s-7
z)J99qb`Nb6YjwrwSo^YYX>@&Pr)n)}6KY6Qd}vCtnwr?3p&?qeWqa??)cY{=-S3|J
zoipD#ndk^cM=*5L5&~nb3w=2Lb>`6Yrse-PMe(e4_sPjmZjJ4GHTXeN^_h}64V`-}
ze%dN+!66!xmhq>O^q%VvO$Jbojaqe82JH?&#^IO=`USGuH3eXCk->WCT2h6S0W_7=
zjPt0;R5E)?9Hd_nL9-tj_$z@+Y6Qj}I%0aG@p_g+?MVz8r*X9sQ0;-74kcuyDl!!8
z4@3<3MNHaKL+x8bq1?bHjk~L;X~v3u2i3{MfWbBk7XCEwY9m51@D2m#3+xCRG2>>l
zrUQOv6<m!=a|0f4jio|$Oac$jYg6kIiF-?6CZuu3&p$qkvzD6)8D#LunV>F9JQjDs
zZ1uYpP$#D@-sDHzE$$q+=<bZtvN@w>jQ+>u4Gzk14|IUizJK&&167%)%zTkMc?o_=
zUCA-*ph|OD?lN_f>l!Pr>wCb-%Y#LwwAH*4U3A6lLM#1l{=xQ^>H=AOPJS~ts|!x&
z^=l!3H9Ki^CgIbx$+C9lx`$enQ_1wbr4uicJ7otRrv8+A+)m>hS5s?heWphX0yM}0
zc>@T6h60MDG8|y-X-SAxtm7#gVn5rNUWS-VM>D+XD}Rg2dStq=mA}y4j5Qb|zg&)|
zSWu254p4hm37()mS=(_l-OYL#TWEf^3)j-RY@2<#sCibOs2Q8I2%n}GxWUh8`#EZ)
zzU-?~{ZF*kYR3`QZGC|DeqnU`3DxF>@Hy^vIUktZ#NWb|_C7k2a~j`d^K+{ZKc|g(
zZJF<@Hh_45-!W-kfVRCfoOcSjeYO(JrjYIJVpGfl7qvTy!~+XY91fq0fcga&JwGkl
zdWov@ci299qT`F|5uw$3fLoqSuQ+npX#N_+D^yunf`imrScON~JB0;^X>{DKNP)*p
zv(G@>LsyGDxQRU~dKd9i+OMp@Ub>+yFL;p;?d9nnYXR;?ulgJmirLv-N8aKExRAPw
zyQOX8bf0g2Cbz?em*^#j$1-G|5@B<q?4V;-5|*-KrLSRCmoUS5D4;|uR2xDV+@RJ?
z+oY~S5VbqI)dg@{Sm}J7Rg_&vT+JlcfP_dx<y(-EQn44kbhM&3zv1DitdA+cn|uwN
zad#vYLL#Z7iM(@Lu!x1{HY09k<CP~c^FTODALNl2_&7uXeM>3izFc7A%osR*vVNbV
zae*d)Cr9rMwr$>e#9cH}-Ds}m?Z@Y*sK{gIqrJ#;tL}m?H~~Io!p#j41q|~76g|qt
zWx)DxME&VG@u;qGJ}8p%4#o_XP8OKogVLhE=*F`@;zc@BQ_Lq~xW>o3kWyRB2eG2I
z96i)gYey&BRr{TU+i3B^0{ob*UYM6F4cum3ExRS$z<zBTPGP3?yqiNz*>K*3XK8F>
eWs0A>D3;$#a%ZjO$$vG#cfskiwjc|2M(|(tW7}&0
delta 1349
zcmYLJZ%kEX7=ND2h06tn!@mm`xNz<tU<AT7NI?E{uQ(kA>moQwoLJ#%83G&4XwDI%
z`GxSt!?c;&4W+}h+LgDZl-Ws~7;Z{z8B{hB{SaC^7-=60df&sA?}u}K@AE$A_dM_K
z_v{3(WAHlqe=vJMUpqbT&VC)!yt1kN|4l(0j(_iDbXH5tQ{Q&aZ#?*?rSRpA-yHv)
zUNh{$W|}r^=1)1~VD`8w0mvOw@tPumdKV!2#Ze;+3KaL3Dg#uc>Cs4<49PV_P190H
z4VtOi=uE#U4x)~Ur1U8r9~RgdB{1%wKI7|EpTs(pp5+n!^h+fVQ0W0ngY4H!rRfZ|
z8zKibikww8o$a{J5TfHw{oA!v9lCY%PGxcVtRBq}QJB#2lLD{)TgO#8eju>pRXyjt
z$)sw4$K#d7rCZ{%kVS=I8BW)f34{E~B4QaCk>DO^02u@SYGFFcH!V?DSS8+~%VDF~
zMF&h-iB-xXfJt9-n)U{`R5w6b4P7v8!&-_D&&D#U2)}0iNXZ6CR8Owqck6(mq(RjW
z(0G&_W<no*Zr%~zWLJYclt;-CyYU`%MYQ7xJ%}jBBjk>3$L%y2Ssv4<wgGG?_DQ=y
z5NxO<Et263JGCkVaT^<6ZAF}5m!h%|^JqTW6V;F~CuxC|#u}ojSZc&yX+X-sYfP2q
z5NGIAtP{uSYHTYWqT;w`v6Fh@vayFgjkDVJiJlV%M9)~Q2Dtfq`7k`8c5&2BcjB%X
zDnjYwcpE-s6Y-DGrt4onu2?<Le_945hx?nj{Etwj{sR4C8NwmflbDbA9etKm7sC`Q
zz?@G8FsdGax(_MIdJ?&ORwtIyto1E>?x-2QQ131;KQi;e{r#r{pq$~P=T=C!%u{!A
zyY;KbJl>!d5L{c%aLL2ygu}udDUFEt=|HLzf26_Ge7wY_Qd1BM=?|N1sC6<aEfg_8
zmh=MbW6z|&jW|Y=@>cAlO#5>wZG6VYRy<aHT#a6(7*fTQw7x`sdkJ@V!v3bAHJmm%
zO1QRN4lB;nQAdIKXVa2M%baF69SI>=!|rFifceLS7_PHEIhd<h5&FRmO6iJB%JT@K
zch{g&0(Zp7y548|v%W{{W?Qn)8ZeuTxqI*@YRm1!S7<)BH@VV2C27+#aFZv&HRldQ
zf?pJMbdY~dEpB4B*VG^$V($D8Fy>5utTw_k&+~Bz0(x6$);*Tu<&kM{c_r;3N3#Mg
z056W7C3bOb6XFR<E2uIxar@DeNqY-ye6)KDW=dzhZ42O)7u;MB(ZE&SfUE^Mxdd4L
zo9I8vG8fcT9&Zyxxr3vE<>_}=ps)uG<uYZiyMedq;W|5?h@>JfcVT;xoe$#vq8x0b
z;UXJWvnxg820ToC>r?O|JH0+B(J)fTF4yieV33v7UyY!^P9HNiaYvh(yz8718)&*Y
eFQQTdeN}2C?JhDu{uTQ8j`t>3oy`2Z1Na|Pug>TI
On 14 December 2017 at 17:09, Cornelia Huck <cohuck@redhat.com> wrote: > The following changes since commit 0ef0583d5adceb9138bdb47494dabd1549ac5b6d: > > Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20171214' into staging (2017-12-14 15:32:32 +0000) > > are available in the git repository at: > > git://github.com/cohuck/qemu tags/s390x-20171214 > > for you to fetch changes up to a9e3065c6579df8652ce38502276ac0a13180d6f: > > s390-ccw-virtio: allow for systems larger that 7.999TB (2017-12-14 17:56:54 +0100) > > ---------------------------------------------------------------- > s390x changes for 2.12: > - Lots of tcg improvements: ccw hotplug is now working and we can run > a Linux kernel built for z12 under tcg > - zPCI improvements to get virtio-pci working > - get rid of the cssid restrictions for virtual and non-virtual channel > devices > - we now support 8TB+ systems > - 2.12 compat machine > - fixes and cleanups > > ---------------------------------------------------------------- Hi; I'm afraid this fails to build on 32-bit: In file included from /usr/lib/arm-linux-gnueabihf/glib-2.0/include/glibconfig.h:9:0, from /usr/include/glib-2.0/glib/gtypes.h:32, from /usr/include/glib-2.0/glib/galloca.h:32, from /usr/include/glib-2.0/glib.h:30, from /home/peter.maydell/qemu/include/glib-compat.h:19, from /home/peter.maydell/qemu/include/qemu/osdep.h:107, from /home/peter.maydell/qemu/hw/s390x/s390-virtio-ccw.c:13: /home/peter.maydell/qemu/hw/s390x/s390-virtio-ccw.c: In function 's390_memory_init': /usr/include/glib-2.0/glib/gmacros.h:291:26: error: comparison is always true due to limited range of data type [-Werror=type-limits] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ /home/peter.maydell/qemu/hw/s390x/s390-virtio-ccw.c:177:17: note: in expansion of macro 'MIN' chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES); ^ (ram_addr_t can be a 32-bit type). thanks -- PMM
On 12/14/2017 08:05 PM, Peter Maydell wrote: > On 14 December 2017 at 17:09, Cornelia Huck <cohuck@redhat.com> wrote: >> The following changes since commit 0ef0583d5adceb9138bdb47494dabd1549ac5b6d: >> >> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20171214' into staging (2017-12-14 15:32:32 +0000) >> >> are available in the git repository at: >> >> git://github.com/cohuck/qemu tags/s390x-20171214 >> >> for you to fetch changes up to a9e3065c6579df8652ce38502276ac0a13180d6f: >> >> s390-ccw-virtio: allow for systems larger that 7.999TB (2017-12-14 17:56:54 +0100) >> >> ---------------------------------------------------------------- >> s390x changes for 2.12: >> - Lots of tcg improvements: ccw hotplug is now working and we can run >> a Linux kernel built for z12 under tcg >> - zPCI improvements to get virtio-pci working >> - get rid of the cssid restrictions for virtual and non-virtual channel >> devices >> - we now support 8TB+ systems >> - 2.12 compat machine >> - fixes and cleanups >> >> ---------------------------------------------------------------- > > Hi; I'm afraid this fails to build on 32-bit: > > In file included from > /usr/lib/arm-linux-gnueabihf/glib-2.0/include/glibconfig.h:9:0, > from /usr/include/glib-2.0/glib/gtypes.h:32, > from /usr/include/glib-2.0/glib/galloca.h:32, > from /usr/include/glib-2.0/glib.h:30, > from /home/peter.maydell/qemu/include/glib-compat.h:19, > from /home/peter.maydell/qemu/include/qemu/osdep.h:107, > from /home/peter.maydell/qemu/hw/s390x/s390-virtio-ccw.c:13: > /home/peter.maydell/qemu/hw/s390x/s390-virtio-ccw.c: In function > 's390_memory_init': > /usr/include/glib-2.0/glib/gmacros.h:291:26: error: comparison is > always true due to limited range of data type [-Werror=type-limits] > #define MIN(a, b) (((a) < (b)) ? (a) : (b)) > ^ > /home/peter.maydell/qemu/hw/s390x/s390-virtio-ccw.c:177:17: note: in > expansion of macro 'MIN' > chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES); > ^ > > (ram_addr_t can be a 32-bit type). gcc seems to be extra clever, even a cast does not work. Something like this seems to work. diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 80e753a5ef..9abb8de9f9 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_t mem_size) name = g_strdup_printf("s390.ram"); while (mem_size) { MemoryRegion *ram = g_new(MemoryRegion, 1); + unsigned long long size = mem_size; /* KVM does not allow memslots >= 8 TB */ - chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES); + chunk = MIN(size, KVM_SLOT_MAX_BYTES); memory_region_allocate_system_memory(ram, NULL, name, chunk); memory_region_add_subregion(sysmem, offset, ram); mem_size -= chunk;
On Fri, 15 Dec 2017 09:35:10 +0100 Christian Borntraeger <borntraeger@de.ibm.com> wrote: > On 12/14/2017 08:05 PM, Peter Maydell wrote: > > On 14 December 2017 at 17:09, Cornelia Huck <cohuck@redhat.com> wrote: > >> The following changes since commit 0ef0583d5adceb9138bdb47494dabd1549ac5b6d: > >> > >> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20171214' into staging (2017-12-14 15:32:32 +0000) > >> > >> are available in the git repository at: > >> > >> git://github.com/cohuck/qemu tags/s390x-20171214 > >> > >> for you to fetch changes up to a9e3065c6579df8652ce38502276ac0a13180d6f: > >> > >> s390-ccw-virtio: allow for systems larger that 7.999TB (2017-12-14 17:56:54 +0100) > >> > >> ---------------------------------------------------------------- > >> s390x changes for 2.12: > >> - Lots of tcg improvements: ccw hotplug is now working and we can run > >> a Linux kernel built for z12 under tcg > >> - zPCI improvements to get virtio-pci working > >> - get rid of the cssid restrictions for virtual and non-virtual channel > >> devices > >> - we now support 8TB+ systems > >> - 2.12 compat machine > >> - fixes and cleanups > >> > >> ---------------------------------------------------------------- > > > > Hi; I'm afraid this fails to build on 32-bit: > > > > In file included from > > /usr/lib/arm-linux-gnueabihf/glib-2.0/include/glibconfig.h:9:0, > > from /usr/include/glib-2.0/glib/gtypes.h:32, > > from /usr/include/glib-2.0/glib/galloca.h:32, > > from /usr/include/glib-2.0/glib.h:30, > > from /home/peter.maydell/qemu/include/glib-compat.h:19, > > from /home/peter.maydell/qemu/include/qemu/osdep.h:107, > > from /home/peter.maydell/qemu/hw/s390x/s390-virtio-ccw.c:13: > > /home/peter.maydell/qemu/hw/s390x/s390-virtio-ccw.c: In function > > 's390_memory_init': > > /usr/include/glib-2.0/glib/gmacros.h:291:26: error: comparison is > > always true due to limited range of data type [-Werror=type-limits] > > #define MIN(a, b) (((a) < (b)) ? (a) : (b)) > > ^ > > /home/peter.maydell/qemu/hw/s390x/s390-virtio-ccw.c:177:17: note: in > > expansion of macro 'MIN' > > chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES); > > ^ > > > > (ram_addr_t can be a 32-bit type). This a 32 bit host, isn't it? I don't have regular access to one... > > gcc seems to be extra clever, even a cast does not work. > Something like this seems to work. > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 80e753a5ef..9abb8de9f9 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_t mem_size) > name = g_strdup_printf("s390.ram"); > while (mem_size) { > MemoryRegion *ram = g_new(MemoryRegion, 1); > + unsigned long long size = mem_size; > > /* KVM does not allow memslots >= 8 TB */ > - chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES); > + chunk = MIN(size, KVM_SLOT_MAX_BYTES); > memory_region_allocate_system_memory(ram, NULL, name, chunk); > memory_region_add_subregion(sysmem, offset, ram); > mem_size -= chunk; > Will see how I can test this and then merge it.
On 15 December 2017 at 09:11, Cornelia Huck <cohuck@redhat.com> wrote: > On Fri, 15 Dec 2017 09:35:10 +0100 > Christian Borntraeger <borntraeger@de.ibm.com> wrote: > >> On 12/14/2017 08:05 PM, Peter Maydell wrote: >> > (ram_addr_t can be a 32-bit type). > > This a 32 bit host, isn't it? I don't have regular access to one... Yes. Win32 cross compiler also gives this error. >> >> gcc seems to be extra clever, even a cast does not work. >> Something like this seems to work. >> >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >> index 80e753a5ef..9abb8de9f9 100644 >> --- a/hw/s390x/s390-virtio-ccw.c >> +++ b/hw/s390x/s390-virtio-ccw.c >> @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_t mem_size) >> name = g_strdup_printf("s390.ram"); >> while (mem_size) { >> MemoryRegion *ram = g_new(MemoryRegion, 1); >> + unsigned long long size = mem_size; >> >> /* KVM does not allow memslots >= 8 TB */ >> - chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES); >> + chunk = MIN(size, KVM_SLOT_MAX_BYTES); >> memory_region_allocate_system_memory(ram, NULL, name, chunk); >> memory_region_add_subregion(sysmem, offset, ram); >> mem_size -= chunk; >> > > Will see how I can test this and then merge it. I would suggest uint64_t rather than unsigned long long. thanks -- PMM
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 80e753a5ef..9abb8de9f9 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_t mem_size) > name = g_strdup_printf("s390.ram"); > while (mem_size) { > MemoryRegion *ram = g_new(MemoryRegion, 1); > + unsigned long long size = mem_size; > > /* KVM does not allow memslots >= 8 TB */ > - chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES); > + chunk = MIN(size, KVM_SLOT_MAX_BYTES); directly cast inline? > memory_region_allocate_system_memory(ram, NULL, name, chunk); > memory_region_add_subregion(sysmem, offset, ram); > mem_size -= chunk; >
On 12/15/2017 10:53 AM, David Hildenbrand wrote: > >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >> index 80e753a5ef..9abb8de9f9 100644 >> --- a/hw/s390x/s390-virtio-ccw.c >> +++ b/hw/s390x/s390-virtio-ccw.c >> @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_t mem_size) >> name = g_strdup_printf("s390.ram"); >> while (mem_size) { >> MemoryRegion *ram = g_new(MemoryRegion, 1); >> + unsigned long long size = mem_size; >> >> /* KVM does not allow memslots >= 8 TB */ >> - chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES); >> + chunk = MIN(size, KVM_SLOT_MAX_BYTES); > > directly cast inline? As I said, this still triggers the warning. gcc 7 is too clever.
On 15.12.2017 10:53, Christian Borntraeger wrote: > > > On 12/15/2017 10:53 AM, David Hildenbrand wrote: >> >>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >>> index 80e753a5ef..9abb8de9f9 100644 >>> --- a/hw/s390x/s390-virtio-ccw.c >>> +++ b/hw/s390x/s390-virtio-ccw.c >>> @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_t mem_size) >>> name = g_strdup_printf("s390.ram"); >>> while (mem_size) { >>> MemoryRegion *ram = g_new(MemoryRegion, 1); >>> + unsigned long long size = mem_size; >>> >>> /* KVM does not allow memslots >= 8 TB */ >>> - chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES); >>> + chunk = MIN(size, KVM_SLOT_MAX_BYTES); >> >> directly cast inline? > As I said, this still triggers the warning. gcc 7 is too clever. Whoops missed that.
On Fri, 15 Dec 2017 09:51:32 +0000 Peter Maydell <peter.maydell@linaro.org> wrote: > On 15 December 2017 at 09:11, Cornelia Huck <cohuck@redhat.com> wrote: > > On Fri, 15 Dec 2017 09:35:10 +0100 > > Christian Borntraeger <borntraeger@de.ibm.com> wrote: > > > >> On 12/14/2017 08:05 PM, Peter Maydell wrote: > >> > (ram_addr_t can be a 32-bit type). > > > > This a 32 bit host, isn't it? I don't have regular access to one... > > Yes. Win32 cross compiler also gives this error. Hm, my mingw build on Fedora did not catch this. Setting up a 32bit vm. > > >> > >> gcc seems to be extra clever, even a cast does not work. > >> Something like this seems to work. > >> > >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > >> index 80e753a5ef..9abb8de9f9 100644 > >> --- a/hw/s390x/s390-virtio-ccw.c > >> +++ b/hw/s390x/s390-virtio-ccw.c > >> @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_t mem_size) > >> name = g_strdup_printf("s390.ram"); > >> while (mem_size) { > >> MemoryRegion *ram = g_new(MemoryRegion, 1); > >> + unsigned long long size = mem_size; > >> > >> /* KVM does not allow memslots >= 8 TB */ > >> - chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES); > >> + chunk = MIN(size, KVM_SLOT_MAX_BYTES); > >> memory_region_allocate_system_memory(ram, NULL, name, chunk); > >> memory_region_add_subregion(sysmem, offset, ram); > >> mem_size -= chunk; > >> > > > > Will see how I can test this and then merge it. > > I would suggest uint64_t rather than unsigned long long. Will try how that works.
On 15 December 2017 at 10:21, Cornelia Huck <cohuck@redhat.com> wrote: > On Fri, 15 Dec 2017 09:51:32 +0000 > Peter Maydell <peter.maydell@linaro.org> wrote: > >> On 15 December 2017 at 09:11, Cornelia Huck <cohuck@redhat.com> wrote: >> > On Fri, 15 Dec 2017 09:35:10 +0100 >> > Christian Borntraeger <borntraeger@de.ibm.com> wrote: >> > >> >> On 12/14/2017 08:05 PM, Peter Maydell wrote: >> >> > (ram_addr_t can be a 32-bit type). >> > >> > This a 32 bit host, isn't it? I don't have regular access to one... >> >> Yes. Win32 cross compiler also gives this error. > > Hm, my mingw build on Fedora did not catch this. Setting up a 32bit vm. Maybe your mingw build is mingw-w64 rather than -w32 ? thanks -- PMM
On Fri, 15 Dec 2017 10:33:28 +0000 Peter Maydell <peter.maydell@linaro.org> wrote: > On 15 December 2017 at 10:21, Cornelia Huck <cohuck@redhat.com> wrote: > > On Fri, 15 Dec 2017 09:51:32 +0000 > > Peter Maydell <peter.maydell@linaro.org> wrote: > > > >> On 15 December 2017 at 09:11, Cornelia Huck <cohuck@redhat.com> wrote: > >> > On Fri, 15 Dec 2017 09:35:10 +0100 > >> > Christian Borntraeger <borntraeger@de.ibm.com> wrote: > >> > > >> >> On 12/14/2017 08:05 PM, Peter Maydell wrote: > >> >> > (ram_addr_t can be a 32-bit type). > >> > > >> > This a 32 bit host, isn't it? I don't have regular access to one... > >> > >> Yes. Win32 cross compiler also gives this error. > > > > Hm, my mingw build on Fedora did not catch this. Setting up a 32bit vm. > > Maybe your mingw build is mingw-w64 rather than -w32 ? It's mingw32-w64 so it seems it's actually w64. Confusing naming. Anyway, I now have a 32 bit build machine, and the uint64_t cast seems to work. I'll send an updated pull request (OK if I don't send the other 45 patches again?)