From patchwork Mon Feb 28 19:59:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Likely X-Patchwork-Id: 84863 X-Patchwork-Delegate: benh@kernel.crashing.org Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id E155B10080A for ; Tue, 1 Mar 2011 06:59:49 +1100 (EST) Received: from mail-iy0-f179.google.com (mail-iy0-f179.google.com [209.85.210.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id B9BA1B70A3 for ; Tue, 1 Mar 2011 06:59:37 +1100 (EST) Received: by iym7 with SMTP id 7so3562958iym.38 for ; Mon, 28 Feb 2011 11:59:34 -0800 (PST) Received: by 10.42.108.72 with SMTP id g8mr5573275icp.26.1298923174766; Mon, 28 Feb 2011 11:59:34 -0800 (PST) Received: from angua (S01060002b3d79728.cg.shawcable.net [70.72.87.49]) by mx.google.com with ESMTPS id uf10sm1699339icb.5.2011.02.28.11.59.33 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Feb 2011 11:59:34 -0800 (PST) Received: from localhost6.localdomain6 (unknown [IPv6:::1]) by angua (Postfix) with ESMTP id 94C713C00DB; Mon, 28 Feb 2011 12:59:31 -0700 (MST) Subject: [PATCH] powerpc/macintosh: Fix __devexit annotation in rack-meter.c From: Grant Likely Date: Mon, 28 Feb 2011 12:59:31 -0700 Message-ID: <20110228195931.2044.69345.stgit@localhost6.localdomain6> User-Agent: StGit/0.15 MIME-Version: 1.0 Cc: linuxppc-dev@lists.ozlabs.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org The following warning was seen building rack-meter.c WARNING: drivers/built-in.o(.text+0xac784): Section mismatch in reference from the function rackmeter_shutdown() to the function .devexit.text:rackmeter_stop_cpu_sniffer() The function rackmeter_shutdown() references a function in an exit section. Often the function rackmeter_stop_cpu_sniffer() has valid usage outside the exit section and the fix is to remove the __devexit annotation of rackmeter_stop_cpu_sniffer. This patch resolves the warning by removing the __devexit annotation from rackmeter_stop_cpu_sniffer(). Signed-off-by: Grant Likely Cc: linuxppc-dev@lists.ozlabs.org Cc: Benjamin Herrenschmidt --- drivers/macintosh/rack-meter.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c index 39f660b..2637c13 100644 --- a/drivers/macintosh/rack-meter.c +++ b/drivers/macintosh/rack-meter.c @@ -283,7 +283,7 @@ static void __devinit rackmeter_init_cpu_sniffer(struct rackmeter *rm) } } -static void __devexit rackmeter_stop_cpu_sniffer(struct rackmeter *rm) +static void rackmeter_stop_cpu_sniffer(struct rackmeter *rm) { cancel_delayed_work_sync(&rm->cpu[0].sniffer); cancel_delayed_work_sync(&rm->cpu[1].sniffer);