diff mbox series

pinctrl: axp209: add missing Kconfig dependencies

Message ID 20171214094335.899-1-quentin.schulz@free-electrons.com
State New
Headers show
Series pinctrl: axp209: add missing Kconfig dependencies | expand

Commit Message

Quentin Schulz Dec. 14, 2017, 9:43 a.m. UTC
This fixes some compilation issues.

GENERIC_PINCONF and OF at least for pinconf_generic_dt_*, PINMUX at
least for pinmux_ops and GPIOLIB for at least gpio_chip.

Fixes: 23f75d7dfa92 ("pinctrl: axp209: add pinctrl features")

Reported-by: Randy Dunlab <rdunlap@infradead.org>
Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
---
 drivers/pinctrl/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Randy Dunlap Dec. 14, 2017, 6:22 p.m. UTC | #1
On 12/14/2017 01:43 AM, Quentin Schulz wrote:
> This fixes some compilation issues.
> 
> GENERIC_PINCONF and OF at least for pinconf_generic_dt_*, PINMUX at
> least for pinmux_ops and GPIOLIB for at least gpio_chip.
> 
> Fixes: 23f75d7dfa92 ("pinctrl: axp209: add pinctrl features")
> 
> Reported-by: Randy Dunlab <rdunlap@infradead.org>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/pinctrl/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index ce126955212c..1dd445116432 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -66,6 +66,10 @@ config PINCTRL_AS3722
>  config PINCTRL_AXP209
>  	tristate "X-Powers AXP209 PMIC pinctrl and GPIO Support"
>  	depends on MFD_AXP20X
> +	depends on OF
> +	select PINMUX
> +	select GENERIC_PINCONF
> +	select GPIOLIB
>  	help
>  	  AXP PMICs provides multiple GPIOs that can be muxed for different
>  	  functions. This driver bundles a pinctrl driver to select the function
>
Linus Walleij Dec. 20, 2017, 8:14 a.m. UTC | #2
On Thu, Dec 14, 2017 at 10:43 AM, Quentin Schulz
<quentin.schulz@free-electrons.com> wrote:

> This fixes some compilation issues.
>
> GENERIC_PINCONF and OF at least for pinconf_generic_dt_*, PINMUX at
> least for pinmux_ops and GPIOLIB for at least gpio_chip.
>
> Fixes: 23f75d7dfa92 ("pinctrl: axp209: add pinctrl features")
>
> Reported-by: Randy Dunlab <rdunlap@infradead.org>

Fixed that name.

> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

Patch applied with Randy's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index ce126955212c..1dd445116432 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -66,6 +66,10 @@  config PINCTRL_AS3722
 config PINCTRL_AXP209
 	tristate "X-Powers AXP209 PMIC pinctrl and GPIO Support"
 	depends on MFD_AXP20X
+	depends on OF
+	select PINMUX
+	select GENERIC_PINCONF
+	select GPIOLIB
 	help
 	  AXP PMICs provides multiple GPIOs that can be muxed for different
 	  functions. This driver bundles a pinctrl driver to select the function