[05/26] sdcard: rename sd_set_mode() -> sd_update_mode()

Message ID	20171213232025.24503-6-f4bug@amsat.org
State	Superseded, archived
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org> To: Alistair Francis <alistair.francis@xilinx.com>, "Edgar E . Iglesias" <edgar.iglesias@xilinx.com>, Peter Maydell <peter.maydell@linaro.org>, Andrew Baumann <Andrew.Baumann@microsoft.com>, Prasad J Pandit <pjp@fedoraproject.org>, Clement Deschamps <clement.deschamps@antfield.fr> Date: Wed, 13 Dec 2017 20:20:04 -0300 Message-Id: <20171213232025.24503-6-f4bug@amsat.org> In-Reply-To: <20171213232025.24503-1-f4bug@amsat.org> References: <20171213232025.24503-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 05/26] sdcard: rename sd_set_mode() -> sd_update_mode() Precedence: list Cc: Sai Pavan Boddu <saipava@xilinx.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	SDCard housekeeping \| expand [00/26] SDCard housekeeping [RFC,02/26] sdcard: add a Python qtest [03/26] sdcard: use ldst API [04/26] sdcard: replace fprintf() -> qemu_log_mask() [05/26] sdcard: rename sd_set_mode() -> sd_update_mode() [06/26] sdcard: add sd_set_mode() [07/26] sdcard: add sdcard_set_mode() trace event [08/26] sdcard: add sd_set_state() [09/26] sdcard: add a sdcard_set_state() trace event [10/26] sdcard: use more detailled state/mode trace events [11/26] sdcard: use warn_report() instead of fprintf() [12/26] sdcard: replace DPRINTF() by trace events [13/26] sdcard: add more trace events [RFC,14/26] sdcard: use qemu_hexbuf_strdup() to trace command response [15/26] sdcard: use PW_LEN define instead of '16' magic [16/26] sdcard: let cmd_valid_while_locked() returns a bool [17/26] sdcard: rename sd_set_REG() functions called by sd_reset() as sd_reset_REG() [18/26] sdcard: move Memory Card registers together [19/26] sdcard: add DSR register [20/26] sdcard: add/use SD_CMD_MAX to check valid SD commands [21/26] sdcard: add sd_cmd_abbreviation() to resolve the SD command id [22/26] sdcard: reduce sd_cmd traces [23/26] sdcard: add ACMD trace events [24/26] sdcard: use a 16-bit type for the 16-bit RCA register [25/26] sdcard: add/use a SDCardCommandClass enum instead of magic numbers [26/26] sdcard: add/use a ccc_spi enum for the commands supported in SPI mode

Message ID

20171213232025.24503-6-f4bug@amsat.org

State

Superseded, archived

Headers

From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>
To: Alistair Francis <alistair.francis@xilinx.com>,
	"Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Andrew Baumann <Andrew.Baumann@microsoft.com>,
	Prasad J Pandit <pjp@fedoraproject.org>,
	Clement Deschamps <clement.deschamps@antfield.fr>
Date: Wed, 13 Dec 2017 20:20:04 -0300
Message-Id: <20171213232025.24503-6-f4bug@amsat.org>
In-Reply-To: <20171213232025.24503-1-f4bug@amsat.org>
References: <20171213232025.24503-1-f4bug@amsat.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PATCH 05/26] sdcard: rename sd_set_mode() ->
	sd_update_mode()
Precedence: list
Cc: Sai Pavan Boddu <saipava@xilinx.com>, Peter Crosthwaite
	<crosthwaite.peter@gmail.com>, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=
	<f4bug@amsat.org>, 	qemu-devel@nongnu.org
Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Sender: "Qemu-devel"
	<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>

Series

SDCard housekeeping | expand

Commit Message

Philippe Mathieu-Daudé Dec. 13, 2017, 11:20 p.m. UTC

This will ease to trace mode changes (in the following patchs).

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/sd/sd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 6227a3518b..f63459d2c0 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -128,7 +128,7 @@  struct SDState {
     bool enable;
 };
 
-static void sd_set_mode(SDState *sd)
+static void sd_update_mode(SDState *sd)
 {
     switch (sd->state) {
     case sd_inactive_state:
@@ -1470,7 +1470,7 @@  int sd_do_command(SDState *sd, SDRequest *req, uint8_t *response)
     }
 
     last_state = sd->state;
-    sd_set_mode(sd);
+    sd_update_mode(sd);
 
     if (sd->expecting_acmd) {
         sd->expecting_acmd = false;

[05/26] sdcard: rename sd_set_mode() -> sd_update_mode()

Commit Message

Patch