| Message ID | 20171213140918.22500-1-p.zabel@pengutronix.de |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2] media: dt-bindings: coda: Add compatible for CodaHx4 on i.MX51 | expand |
Hi Philipp, On Wed, Dec 13, 2017 at 03:09:17PM +0100, Philipp Zabel wrote: > Add a compatible for the CodaHx4 VPU used on i.MX51. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > --- > Documentation/devicetree/bindings/media/coda.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/coda.txt b/Documentation/devicetree/bindings/media/coda.txt > index 2865d04e40305..660f5ecf2a23b 100644 > --- a/Documentation/devicetree/bindings/media/coda.txt > +++ b/Documentation/devicetree/bindings/media/coda.txt > @@ -7,6 +7,7 @@ called VPU (Video Processing Unit). > Required properties: > - compatible : should be "fsl,<chip>-src" for i.MX SoCs: > (a) "fsl,imx27-vpu" for CodaDx6 present in i.MX27 > + (a) "fsl,imx51-vpu" for CodaHx4 present in i.MX51 Renumbering the strings might be useful. > (b) "fsl,imx53-vpu" for CODA7541 present in i.MX53 > (c) "fsl,imx6q-vpu" for CODA960 present in i.MX6q > - reg: should be register base and length as documented in the baruch
Hi Baruch, On Wed, 2017-12-13 at 16:21 +0200, Baruch Siach wrote: > Hi Philipp, > > On Wed, Dec 13, 2017 at 03:09:17PM +0100, Philipp Zabel wrote: > > Add a compatible for the CodaHx4 VPU used on i.MX51. > > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > > --- > > Documentation/devicetree/bindings/media/coda.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/media/coda.txt b/Documentation/devicetree/bindings/media/coda.txt > > index 2865d04e40305..660f5ecf2a23b 100644 > > --- a/Documentation/devicetree/bindings/media/coda.txt > > +++ b/Documentation/devicetree/bindings/media/coda.txt > > @@ -7,6 +7,7 @@ called VPU (Video Processing Unit). > > Required properties: > > - compatible : should be "fsl,<chip>-src" for i.MX SoCs: > > (a) "fsl,imx27-vpu" for CodaDx6 present in i.MX27 > > + (a) "fsl,imx51-vpu" for CodaHx4 present in i.MX51 > > Renumbering the strings might be useful. yes, thank you. I should probably add the generic "cnm,coda<variant>" compatibles as well. I'll send a fixed version. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Philipp, On 13/12/17 15:09, Philipp Zabel wrote: > Add support for the CodaHx4 VPU used on i.MX51. > > Decoding h.264, MPEG-4, and MPEG-2 video works, as well as encoding > h.264. MPEG-4 encoding is not enabled, it currently produces visual > artifacts. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > --- > drivers/media/platform/coda/coda-bit.c | 45 ++++++++++++++++++++++--------- > drivers/media/platform/coda/coda-common.c | 44 +++++++++++++++++++++++++++--- > drivers/media/platform/coda/coda.h | 1 + > 3 files changed, 74 insertions(+), 16 deletions(-) > <snip> > + [CODA_IMX51] = { > + .firmware = { > + "vpu_fw_imx51.bin", > + "vpu/vpu_fw_imx51.bin", > + "v4l-codahx4-imx51.bin" > + }, > + .product = CODA_HX4, > + .codecs = codahx4_codecs, > + .num_codecs = ARRAY_SIZE(codahx4_codecs), > + .vdevs = codahx4_video_devices, > + .num_vdevs = ARRAY_SIZE(codahx4_video_devices), > + .workbuf_size = 128 * 1024, > + .tempbuf_size = 304 * 1024, > + .iram_size = 0x14000, > + }, What's the status of the firmware? Is it going to be available in some firmware repository? I remember when testing other imx devices that it was a bit tricky to get hold of the firmware. And googling v4l-codahx4-imx51.bin doesn't find anything other than this patch. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Hans, On Fri, 2017-12-15 at 15:22 +0100, Hans Verkuil wrote: > Hi Philipp, > > On 13/12/17 15:09, Philipp Zabel wrote: > > Add support for the CodaHx4 VPU used on i.MX51. > > > > Decoding h.264, MPEG-4, and MPEG-2 video works, as well as encoding > > h.264. MPEG-4 encoding is not enabled, it currently produces visual > > artifacts. > > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > > --- > > drivers/media/platform/coda/coda-bit.c | 45 ++++++++++++++++++++++--------- > > drivers/media/platform/coda/coda-common.c | 44 +++++++++++++++++++++++++++--- > > drivers/media/platform/coda/coda.h | 1 + > > 3 files changed, 74 insertions(+), 16 deletions(-) > > > > <snip> > > > + [CODA_IMX51] = { > > + .firmware = { > > + "vpu_fw_imx51.bin", > > + "vpu/vpu_fw_imx51.bin", > > + "v4l-codahx4-imx51.bin" > > + }, > > + .product = CODA_HX4, > > + .codecs = codahx4_codecs, > > + .num_codecs = ARRAY_SIZE(codahx4_codecs), > > + .vdevs = codahx4_video_devices, > > + .num_vdevs = ARRAY_SIZE(codahx4_video_devices), > > + .workbuf_size = 128 * 1024, > > + .tempbuf_size = 304 * 1024, > > + .iram_size = 0x14000, > > + }, > > What's the status of the firmware? Is it going to be available in some firmware > repository? I remember when testing other imx devices that it was a bit tricky > to get hold of the firmware. And googling v4l-codahx4-imx51.bin doesn't find > anything other than this patch. As far as I am aware, so far all efforts to get these firmware binaries relicensed in a way that makes them redistributable in linux-firmware have not succeeded. They are distributed by NXP directly in the firmware-imx package. The http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/ repository contains links to the latest version: wget http://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-5.4.bin dd if=firmware-imx-5.4.bin bs=34087 skip=1 | tar xj cat firmware-imx-5.4/COPYING regards Philipp -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Dec 13, 2017 at 03:09:17PM +0100, Philipp Zabel wrote: > Add a compatible for the CodaHx4 VPU used on i.MX51. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > --- > Documentation/devicetree/bindings/media/coda.txt | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/media/coda.txt b/Documentation/devicetree/bindings/media/coda.txt index 2865d04e40305..660f5ecf2a23b 100644 --- a/Documentation/devicetree/bindings/media/coda.txt +++ b/Documentation/devicetree/bindings/media/coda.txt @@ -7,6 +7,7 @@ called VPU (Video Processing Unit). Required properties: - compatible : should be "fsl,<chip>-src" for i.MX SoCs: (a) "fsl,imx27-vpu" for CodaDx6 present in i.MX27 + (a) "fsl,imx51-vpu" for CodaHx4 present in i.MX51 (b) "fsl,imx53-vpu" for CODA7541 present in i.MX53 (c) "fsl,imx6q-vpu" for CODA960 present in i.MX6q - reg: should be register base and length as documented in the
Add a compatible for the CodaHx4 VPU used on i.MX51. Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- Documentation/devicetree/bindings/media/coda.txt | 1 + 1 file changed, 1 insertion(+)