| Message ID | 1513160272-15921-1-git-send-email-christian.ehrhardt@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | qemu-guest-agent: freeze-hook to ignore dpkg files as well | expand |
Hi, maybe I missed a formal thing on this submission, but I don't see it right away. So for now just a ping on any updates in regard to accept this? On Wed, Dec 13, 2017 at 11:17 AM, Christian Ehrhardt <christian.ehrhardt@canonical.com> wrote: > The hook already skips a set of rpm upgrade artifacts. > Do the same with such files that might be created by dpkg. > > Fixes: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1484990 > > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> > --- > scripts/qemu-guest-agent/fsfreeze-hook | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/qemu-guest-agent/fsfreeze-hook b/scripts/qemu-guest-agent/fsfreeze-hook > index c27b29f..13aafd4 100755 > --- a/scripts/qemu-guest-agent/fsfreeze-hook > +++ b/scripts/qemu-guest-agent/fsfreeze-hook > @@ -13,7 +13,7 @@ FSFREEZE_D=$(dirname -- "$0")/fsfreeze-hook.d > # Check whether file $1 is a backup or rpm-generated file and should be ignored > is_ignored_file() { > case "$1" in > - *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | *.sample) > + *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | *.sample | *.dpkg-old | *.dpkg-new | *.dpkg-tmp | *.dpkg-dist | *.dpkg-bak | *.dpkg-backup | *.dpkg-remove) > return 0 ;; > esac > return 1 > -- > 2.7.4 >
Re-Ping for consideration? On Mon, Jan 22, 2018 at 3:03 PM, Christian Ehrhardt < christian.ehrhardt@canonical.com> wrote: > Hi, > maybe I missed a formal thing on this submission, but I don't see it right > away. > So for now just a ping on any updates in regard to accept this? > > On Wed, Dec 13, 2017 at 11:17 AM, Christian Ehrhardt > <christian.ehrhardt@canonical.com> wrote: > > The hook already skips a set of rpm upgrade artifacts. > > Do the same with such files that might be created by dpkg. > > > > Fixes: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1484990 > > > > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> > > --- > > scripts/qemu-guest-agent/fsfreeze-hook | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/qemu-guest-agent/fsfreeze-hook > b/scripts/qemu-guest-agent/fsfreeze-hook > > index c27b29f..13aafd4 100755 > > --- a/scripts/qemu-guest-agent/fsfreeze-hook > > +++ b/scripts/qemu-guest-agent/fsfreeze-hook > > @@ -13,7 +13,7 @@ FSFREEZE_D=$(dirname -- "$0")/fsfreeze-hook.d > > # Check whether file $1 is a backup or rpm-generated file and should be > ignored > > is_ignored_file() { > > case "$1" in > > - *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | > *.sample) > > + *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | > *.sample | *.dpkg-old | *.dpkg-new | *.dpkg-tmp | *.dpkg-dist | *.dpkg-bak > | *.dpkg-backup | *.dpkg-remove) > > return 0 ;; > > esac > > return 1 > > -- > > 2.7.4 > > > > > > -- > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd >
Hi Christian, On 04/09/2018 04:18 AM, Christian Ehrhardt wrote: > Re-Ping for consideration? > > On Mon, Jan 22, 2018 at 3:03 PM, Christian Ehrhardt < > christian.ehrhardt@canonical.com> wrote: > >> Hi, >> maybe I missed a formal thing on this submission, but I don't see it right >> away. You missed to Cc the maintainer of this file: $ ./scripts/get_maintainer.pl -f scripts/qemu-guest-agent/fsfreeze-hook Michael Roth <mdroth@linux.vnet.ibm.com> (maintainer:QEMU Guest Agent) (I Cc'ed him). See https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer >> So for now just a ping on any updates in regard to accept this? >> >> On Wed, Dec 13, 2017 at 11:17 AM, Christian Ehrhardt >> <christian.ehrhardt@canonical.com> wrote: >>> The hook already skips a set of rpm upgrade artifacts. >>> Do the same with such files that might be created by dpkg. >>> >>> Fixes: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1484990 >>> >>> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>> --- >>> scripts/qemu-guest-agent/fsfreeze-hook | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/scripts/qemu-guest-agent/fsfreeze-hook >> b/scripts/qemu-guest-agent/fsfreeze-hook >>> index c27b29f..13aafd4 100755 >>> --- a/scripts/qemu-guest-agent/fsfreeze-hook >>> +++ b/scripts/qemu-guest-agent/fsfreeze-hook >>> @@ -13,7 +13,7 @@ FSFREEZE_D=$(dirname -- "$0")/fsfreeze-hook.d >>> # Check whether file $1 is a backup or rpm-generated file and should be >> ignored >>> is_ignored_file() { >>> case "$1" in >>> - *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | >> *.sample) >>> + *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | >> *.sample | *.dpkg-old | *.dpkg-new | *.dpkg-tmp | *.dpkg-dist | *.dpkg-bak >> | *.dpkg-backup | *.dpkg-remove) >>> return 0 ;; >>> esac >>> return 1 >>> -- >>> 2.7.4
Hi Paolo, On 04/24/2018 10:01 PM, Philippe Mathieu-Daudé wrote: > Hi Christian, > > On 04/09/2018 04:18 AM, Christian Ehrhardt wrote: >> Re-Ping for consideration? >> >> On Mon, Jan 22, 2018 at 3:03 PM, Christian Ehrhardt < >> christian.ehrhardt@canonical.com> wrote: >> >>> Hi, >>> maybe I missed a formal thing on this submission, but I don't see it right >>> away. > > You missed to Cc the maintainer of this file: > > $ ./scripts/get_maintainer.pl -f scripts/qemu-guest-agent/fsfreeze-hook > Michael Roth <mdroth@linux.vnet.ibm.com> (maintainer:QEMU Guest Agent) > > (I Cc'ed him). > > See https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer > >>> So for now just a ping on any updates in regard to accept this? >>> >>> On Wed, Dec 13, 2017 at 11:17 AM, Christian Ehrhardt >>> <christian.ehrhardt@canonical.com> wrote: >>>> The hook already skips a set of rpm upgrade artifacts. >>>> Do the same with such files that might be created by dpkg. >>>> >>>> Fixes: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1484990 >>>> >>>> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> > > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Can you take this patch via your MISC tree? >>>> --- >>>> scripts/qemu-guest-agent/fsfreeze-hook | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/scripts/qemu-guest-agent/fsfreeze-hook >>> b/scripts/qemu-guest-agent/fsfreeze-hook >>>> index c27b29f..13aafd4 100755 >>>> --- a/scripts/qemu-guest-agent/fsfreeze-hook >>>> +++ b/scripts/qemu-guest-agent/fsfreeze-hook >>>> @@ -13,7 +13,7 @@ FSFREEZE_D=$(dirname -- "$0")/fsfreeze-hook.d >>>> # Check whether file $1 is a backup or rpm-generated file and should be >>> ignored >>>> is_ignored_file() { >>>> case "$1" in >>>> - *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | >>> *.sample) >>>> + *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | >>> *.sample | *.dpkg-old | *.dpkg-new | *.dpkg-tmp | *.dpkg-dist | *.dpkg-bak >>> | *.dpkg-backup | *.dpkg-remove) >>>> return 0 ;; >>>> esac >>>> return 1 >>>> -- >>>> 2.7.4
On Thu, May 10, 2018 at 8:47 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > Hi Paolo, > > On 04/24/2018 10:01 PM, Philippe Mathieu-Daudé wrote: > > Hi Christian, > > > > On 04/09/2018 04:18 AM, Christian Ehrhardt wrote: > >> Re-Ping for consideration? > >> > >> On Mon, Jan 22, 2018 at 3:03 PM, Christian Ehrhardt < > >> christian.ehrhardt@canonical.com> wrote: > >> > >>> Hi, > >>> maybe I missed a formal thing on this submission, but I don't see it > right > >>> away. > > > > You missed to Cc the maintainer of this file: > > > > $ ./scripts/get_maintainer.pl -f scripts/qemu-guest-agent/fsfreeze-hook > > Michael Roth <mdroth@linux.vnet.ibm.com> (maintainer:QEMU Guest Agent) > > > > (I Cc'ed him). > > > > See > https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer > > > >>> So for now just a ping on any updates in regard to accept this? > >>> > >>> On Wed, Dec 13, 2017 at 11:17 AM, Christian Ehrhardt > >>> <christian.ehrhardt@canonical.com> wrote: > >>>> The hook already skips a set of rpm upgrade artifacts. > >>>> Do the same with such files that might be created by dpkg. > >>>> > >>>> Fixes: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1484990 > >>>> > >>>> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> > > > > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > Can you take this patch via your MISC tree? > Even after Philippe back then helped to make sure CCs are better nothing happened. Therefore kindly re-ping for this to be included. > > >>>> --- > >>>> scripts/qemu-guest-agent/fsfreeze-hook | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/scripts/qemu-guest-agent/fsfreeze-hook > >>> b/scripts/qemu-guest-agent/fsfreeze-hook > >>>> index c27b29f..13aafd4 100755 > >>>> --- a/scripts/qemu-guest-agent/fsfreeze-hook > >>>> +++ b/scripts/qemu-guest-agent/fsfreeze-hook > >>>> @@ -13,7 +13,7 @@ FSFREEZE_D=$(dirname -- "$0")/fsfreeze-hook.d > >>>> # Check whether file $1 is a backup or rpm-generated file and should > be > >>> ignored > >>>> is_ignored_file() { > >>>> case "$1" in > >>>> - *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | > >>> *.sample) > >>>> + *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | > >>> *.sample | *.dpkg-old | *.dpkg-new | *.dpkg-tmp | *.dpkg-dist | > *.dpkg-bak > >>> | *.dpkg-backup | *.dpkg-remove) > >>>> return 0 ;; > >>>> esac > >>>> return 1 > >>>> -- > >>>> 2.7.4 >
On 20/08/2018 12:54, Christian Ehrhardt wrote: > > > On Thu, May 10, 2018 at 8:47 PM Philippe Mathieu-Daudé <f4bug@amsat.org > <mailto:f4bug@amsat.org>> wrote: > > Hi Paolo, > > On 04/24/2018 10:01 PM, Philippe Mathieu-Daudé wrote: > > Hi Christian, > > > > On 04/09/2018 04:18 AM, Christian Ehrhardt wrote: > >> Re-Ping for consideration? > >> > >> On Mon, Jan 22, 2018 at 3:03 PM, Christian Ehrhardt < > >> christian.ehrhardt@canonical.com > <mailto:christian.ehrhardt@canonical.com>> wrote: > >> > >>> Hi, > >>> maybe I missed a formal thing on this submission, but I don't > see it right > >>> away. > > > > You missed to Cc the maintainer of this file: > > > > $ ./scripts/get_maintainer.pl <http://get_maintainer.pl> -f > scripts/qemu-guest-agent/fsfreeze-hook > > Michael Roth <mdroth@linux.vnet.ibm.com > <mailto:mdroth@linux.vnet.ibm.com>> (maintainer:QEMU Guest Agent) > > > > (I Cc'ed him). > > > > See > https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer > > > >>> So for now just a ping on any updates in regard to accept this? > >>> > >>> On Wed, Dec 13, 2017 at 11:17 AM, Christian Ehrhardt > >>> <christian.ehrhardt@canonical.com > <mailto:christian.ehrhardt@canonical.com>> wrote: > >>>> The hook already skips a set of rpm upgrade artifacts. > >>>> Do the same with such files that might be created by dpkg. > >>>> > >>>> Fixes: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1484990 > >>>> > >>>> Signed-off-by: Christian Ehrhardt > <christian.ehrhardt@canonical.com > <mailto:christian.ehrhardt@canonical.com>> > > > > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org > <mailto:f4bug@amsat.org>> > > Can you take this patch via your MISC tree? > > > Even after Philippe back then helped to make sure CCs are better nothing > happened. > Therefore kindly re-ping for this to be included. Queued, thanks. Paolo
diff --git a/scripts/qemu-guest-agent/fsfreeze-hook b/scripts/qemu-guest-agent/fsfreeze-hook index c27b29f..13aafd4 100755 --- a/scripts/qemu-guest-agent/fsfreeze-hook +++ b/scripts/qemu-guest-agent/fsfreeze-hook @@ -13,7 +13,7 @@ FSFREEZE_D=$(dirname -- "$0")/fsfreeze-hook.d # Check whether file $1 is a backup or rpm-generated file and should be ignored is_ignored_file() { case "$1" in - *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | *.sample) + *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | *.sample | *.dpkg-old | *.dpkg-new | *.dpkg-tmp | *.dpkg-dist | *.dpkg-bak | *.dpkg-backup | *.dpkg-remove) return 0 ;; esac return 1
The hook already skips a set of rpm upgrade artifacts. Do the same with such files that might be created by dpkg. Fixes: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1484990 Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> --- scripts/qemu-guest-agent/fsfreeze-hook | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)