Message ID | 1513159273-14739-1-git-send-email-baijiaju1990@gmail.com |
---|---|
State | Rejected, archived |
Delegated to: | David Miller |
Headers | show |
Series | [1/2] qla3xxx: Fix a possible sleep-in-atomic bug in ql_sem_spinlock | expand |
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c index 9e5264d..8ad3e24 100644 --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c @@ -115,7 +115,7 @@ static int ql_sem_spinlock(struct ql3_adapter *qdev, value = readl(&port_regs->CommonRegs.semaphoreReg); if ((value & (sem_mask >> 16)) == sem_bits) return 0; - ssleep(1); + mdelay(1000); } while (--seconds); return -1; }
The driver may sleep under a spinlock. The function call paths are: ql_get_full_dup (acquire the spinlock) ql_sem_spinlock ssleep --> may sleep ql_get_auto_cfg_status (acquire the spinlock) ql_sem_spinlock ssleep --> may sleep To fix it, ssleep is replaced with mdelay. This bug is found by my static analysis tool(DSAC) and checked by my code review. Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> --- drivers/net/ethernet/qlogic/qla3xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)