| Message ID | E1eP3Ev-0000ZJ-1L@rmk-PC.armlinux.org.uk |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88e151x | expand |
On Wed, Dec 13, 2017 at 09:22:09AM +0000, Russell King wrote: > Observed on the 88e1512 in SGMII-to-Copper mode, negotiating pause > is unreliable. While the pause bits can be set in the advertisment > register, they clear shortly after negotiation with a link partner > commences irrespective of the cause of the negotiation. > > While these bits may be correctly conveyed to the link partner on the > first negotiation, a subsequent negotiation (eg, due to negotiation > restart by the link partner, or reconnection of the cable) will result > in the link partner seeing these bits as zero, while the kernel > believes that it has advertised pause modes. > > This leads to the local kernel evaluating (eg) symmetric pause mode, > while the remote end evaluates that we have no pause mode capability. > > Since we can't guarantee the advertisment, disable pause mode support > with this PHY when used in SGMII-to-Copper mode. > > The 88e1510 in RGMII-to-Copper mode appears to behave correctly. > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Russell King <rmk+kernel@armlinux.org.uk> Date: Wed, 13 Dec 2017 09:22:09 +0000 > @@ -924,6 +924,16 @@ static int m88e1510_config_init(struct phy_device *phydev) > err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); > if (err < 0) > return err; > + > + /* There appears to be a bug in the 88e1512 when used in > + * SGMII to copper mode, where the AN advertisment register > + * clears the pause bits each time a negotiation occurs. > + * This means we can never be truely sure what was advertised, > + * so disable Pause support. > + */ > + pause = SUPPORTED_Pause | SUPPORTED_Asym_Pause; > + phydev->supported &= ~pause; > + phydev->advertising &= ~pause; > } > This function doesn't have a local 'pause' variable in any of my trees. I wonder what you generated this against, and even more importantly, what tree the reviewers were considering when looking at this patch :)
On Wed, Dec 13, 2017 at 04:14:23PM -0500, David Miller wrote: > From: Russell King <rmk+kernel@armlinux.org.uk> > Date: Wed, 13 Dec 2017 09:22:09 +0000 > > > @@ -924,6 +924,16 @@ static int m88e1510_config_init(struct phy_device *phydev) > > err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); > > if (err < 0) > > return err; > > + > > + /* There appears to be a bug in the 88e1512 when used in > > + * SGMII to copper mode, where the AN advertisment register > > + * clears the pause bits each time a negotiation occurs. > > + * This means we can never be truely sure what was advertised, > > + * so disable Pause support. > > + */ > > + pause = SUPPORTED_Pause | SUPPORTED_Asym_Pause; > > + phydev->supported &= ~pause; > > + phydev->advertising &= ~pause; > > } > > > > This function doesn't have a local 'pause' variable in any of my trees. > > I wonder what you generated this against, and even more importantly, what > tree the reviewers were considering when looking at this patch :) Sorry about that, not quite sure how that happened, but here's a replacement patch. I assume patchwork will do the right thing by including the patch in this mail... 8<==== From: Russell King <rmk+kernel@armlinux.org.uk> Subject: [PATCH] net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88e151x Observed on the 88e1512 in SGMII-to-Copper mode, negotiating pause is unreliable. While the pause bits can be set in the advertisment register, they clear shortly after negotiation with a link partner commences irrespective of the cause of the negotiation. While these bits may be correctly conveyed to the link partner on the first negotiation, a subsequent negotiation (eg, due to negotiation restart by the link partner, or reconnection of the cable) will result in the link partner seeing these bits as zero, while the kernel believes that it has advertised pause modes. This leads to the local kernel evaluating (eg) symmetric pause mode, while the remote end evaluates that we have no pause mode capability. Since we can't guarantee the advertisment, disable pause mode support with this PHY when used in SGMII-to-Copper mode. The 88e1510 in RGMII-to-Copper mode appears to behave correctly. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> --- drivers/net/phy/marvell.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index b5a8f750e433..2510acc0feb0 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -879,6 +879,8 @@ static int m88e1510_config_init(struct phy_device *phydev) /* SGMII-to-Copper mode initialization */ if (phydev->interface == PHY_INTERFACE_MODE_SGMII) { + u32 pause; + /* Select page 18 */ err = marvell_set_page(phydev, 18); if (err < 0) @@ -902,6 +904,16 @@ static int m88e1510_config_init(struct phy_device *phydev) err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); if (err < 0) return err; + + /* There appears to be a bug in the 88e1512 when used in + * SGMII to copper mode, where the AN advertisment register + * clears the pause bits each time a negotiation occurs. + * This means we can never be truely sure what was advertised, + * so disable Pause support. + */ + pause = SUPPORTED_Pause | SUPPORTED_Asym_Pause; + phydev->supported &= ~pause; + phydev->advertising &= ~pause; } return m88e1121_config_init(phydev);
> Sorry about that, not quite sure how that happened, but here's a > replacement patch. I assume patchwork will do the right thing by > including the patch in this mail... Hi Russell No, it does not. You need to submit a whole new patch. Andrew
From: Russell King - ARM Linux <linux@armlinux.org.uk> Date: Fri, 15 Dec 2017 15:45:40 +0000 > Sorry about that, not quite sure how that happened, but here's a > replacement patch. I assume patchwork will do the right thing by > including the patch in this mail... Please use fresh patch postings when posting a new or fixed version of a patch. Otherwsie I have to manually edit what ends up in patchwork in order to get rid of the quoted discussion text and other irrelevant material in the commit message. Thank you.
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 710110ead6ad..f4d25ac85e30 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -924,6 +924,16 @@ static int m88e1510_config_init(struct phy_device *phydev) err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); if (err < 0) return err; + + /* There appears to be a bug in the 88e1512 when used in + * SGMII to copper mode, where the AN advertisment register + * clears the pause bits each time a negotiation occurs. + * This means we can never be truely sure what was advertised, + * so disable Pause support. + */ + pause = SUPPORTED_Pause | SUPPORTED_Asym_Pause; + phydev->supported &= ~pause; + phydev->advertising &= ~pause; } return m88e1121_config_init(phydev);
Observed on the 88e1512 in SGMII-to-Copper mode, negotiating pause is unreliable. While the pause bits can be set in the advertisment register, they clear shortly after negotiation with a link partner commences irrespective of the cause of the negotiation. While these bits may be correctly conveyed to the link partner on the first negotiation, a subsequent negotiation (eg, due to negotiation restart by the link partner, or reconnection of the cable) will result in the link partner seeing these bits as zero, while the kernel believes that it has advertised pause modes. This leads to the local kernel evaluating (eg) symmetric pause mode, while the remote end evaluates that we have no pause mode capability. Since we can't guarantee the advertisment, disable pause mode support with this PHY when used in SGMII-to-Copper mode. The 88e1510 in RGMII-to-Copper mode appears to behave correctly. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> --- drivers/net/phy/marvell.c | 10 ++++++++++ 1 file changed, 10 insertions(+)