diff mbox series

[ovs-dev,2/2] travis: Install libnuma dependency for DPDK.

Message ID 1513067560-9464-3-git-send-email-i.maximets@samsung.com
State Accepted
Delegated to: Ian Stokes
Headers show
Series travis: Fix DPDK build. | expand

Commit Message

Ilya Maximets Dec. 12, 2017, 8:32 a.m. UTC
libnuma is a default dependency for DPDK 17.11 because
CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES and CONFIG_RTE_LIBRTE_VHOST_NUMA
are enabled by default for most architectures.
libnuma-dev package installation fixes the DPDK build:

	eal_memory.c:56:18: fatal error:
		numa.h: No such file or directory

CC: Mark Kavanagh <mark.b.kavanagh@intel.com>
Fixes: 5e925ccc2a6f ("netdev-dpdk: DPDK v17.11 upgrade")
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
 .travis.yml | 1 +
 1 file changed, 1 insertion(+)

Comments

Stokes, Ian Dec. 12, 2017, 2:44 p.m. UTC | #1
> libnuma is a default dependency for DPDK 17.11 because
> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES and CONFIG_RTE_LIBRTE_VHOST_NUMA are
> enabled by default for most architectures.
> libnuma-dev package installation fixes the DPDK build:
> 
> 	eal_memory.c:56:18: fatal error:
> 		numa.h: No such file or directory
> 
> CC: Mark Kavanagh <mark.b.kavanagh@intel.com>
> Fixes: 5e925ccc2a6f ("netdev-dpdk: DPDK v17.11 upgrade")
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
>  .travis.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index f217840..48acc8e 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -15,6 +15,7 @@ addons:
>        - llvm-dev
>        - libjemalloc1
>        - libjemalloc-dev
> +      - libnuma-dev
>        - python-sphinx
> 
>  before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh


Verified with travis on my side.

As with part 1 of the patch set set I'm thinking it's better to merge this to master instead of dpdk_merge branch so as to enable the travis builds for dpdk?

Acked-by: Ian Stokes <ian.stokes@intel.com>
Tested-by: Ian Stokes <ian.stokes@intel.com>

> --
> 2.7.4
Ben Pfaff Dec. 13, 2017, 5:34 p.m. UTC | #2
On Tue, Dec 12, 2017 at 02:44:41PM +0000, Stokes, Ian wrote:
> > libnuma is a default dependency for DPDK 17.11 because
> > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES and CONFIG_RTE_LIBRTE_VHOST_NUMA are
> > enabled by default for most architectures.
> > libnuma-dev package installation fixes the DPDK build:
> > 
> > 	eal_memory.c:56:18: fatal error:
> > 		numa.h: No such file or directory
> > 
> > CC: Mark Kavanagh <mark.b.kavanagh@intel.com>
> > Fixes: 5e925ccc2a6f ("netdev-dpdk: DPDK v17.11 upgrade")
> > Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> > ---
> >  .travis.yml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/.travis.yml b/.travis.yml
> > index f217840..48acc8e 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -15,6 +15,7 @@ addons:
> >        - llvm-dev
> >        - libjemalloc1
> >        - libjemalloc-dev
> > +      - libnuma-dev
> >        - python-sphinx
> > 
> >  before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh
> 
> 
> Verified with travis on my side.
> 
> As with part 1 of the patch set set I'm thinking it's better to merge this to master instead of dpdk_merge branch so as to enable the travis builds for dpdk?
> 
> Acked-by: Ian Stokes <ian.stokes@intel.com>
> Tested-by: Ian Stokes <ian.stokes@intel.com>

Thanks a lot, I applied both of these to master.
diff mbox series

Patch

diff --git a/.travis.yml b/.travis.yml
index f217840..48acc8e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,6 +15,7 @@  addons:
       - llvm-dev
       - libjemalloc1
       - libjemalloc-dev
+      - libnuma-dev
       - python-sphinx
 
 before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh