diff mbox series

[U-Boot,11/16] configs: sun50i: add usb-otg support for bananapi-m64

Message ID 1513061911-30076-12-git-send-email-jagan@amarulasolutions.com
State Deferred
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series sun50i: a64: add support for axp803, musb | expand

Commit Message

Jagan Teki Dec. 12, 2017, 6:58 a.m. UTC
USB-OTG require MUSB driver along with PHY#0 id(PH9) and/or
vbus pin through AXP_GPIO driver.

This patch add support for it.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 configs/bananapi_m64_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Maxime Ripard Dec. 12, 2017, 8:04 a.m. UTC | #1
On Tue, Dec 12, 2017 at 12:28:26PM +0530, Jagan Teki wrote:
> USB-OTG require MUSB driver along with PHY#0 id(PH9) and/or
> vbus pin through AXP_GPIO driver.
> 
> This patch add support for it.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  configs/bananapi_m64_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
> index 461567f..55feafe 100644
> --- a/configs/bananapi_m64_defconfig
> +++ b/configs/bananapi_m64_defconfig
> @@ -4,6 +4,8 @@ CONFIG_MACH_SUN50I=y
>  CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y
>  CONFIG_MMC0_CD_PIN="PH13"
>  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> +CONFIG_USB0_ID_DET="PH9"
> +CONFIG_AXP_GPIO=y
>  CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>  CONFIG_SPL=y
> @@ -14,4 +16,5 @@ CONFIG_SPL=y
>  # CONFIG_SPL_EFI_PARTITION is not set
>  CONFIG_SUN8I_EMAC=y
>  CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_MUSB_GADGET=y

Did you test the host mode as well?

Maxime
Jagan Teki Dec. 12, 2017, 9:13 a.m. UTC | #2
On Tue, Dec 12, 2017 at 1:34 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Dec 12, 2017 at 12:28:26PM +0530, Jagan Teki wrote:
>> USB-OTG require MUSB driver along with PHY#0 id(PH9) and/or
>> vbus pin through AXP_GPIO driver.
>>
>> This patch add support for it.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>>  configs/bananapi_m64_defconfig | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
>> index 461567f..55feafe 100644
>> --- a/configs/bananapi_m64_defconfig
>> +++ b/configs/bananapi_m64_defconfig
>> @@ -4,6 +4,8 @@ CONFIG_MACH_SUN50I=y
>>  CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y
>>  CONFIG_MMC0_CD_PIN="PH13"
>>  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
>> +CONFIG_USB0_ID_DET="PH9"
>> +CONFIG_AXP_GPIO=y
>>  CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
>>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>>  CONFIG_SPL=y
>> @@ -14,4 +16,5 @@ CONFIG_SPL=y
>>  # CONFIG_SPL_EFI_PARTITION is not set
>>  CONFIG_SUN8I_EMAC=y
>>  CONFIG_USB_EHCI_HCD=y
>> +CONFIG_USB_MUSB_GADGET=y
>
> Did you test the host mode as well?

No, I've not tried host mode yet.

thanks!
Maxime Ripard Dec. 13, 2017, 8:17 a.m. UTC | #3
On Tue, Dec 12, 2017 at 02:43:38PM +0530, Jagan Teki wrote:
> On Tue, Dec 12, 2017 at 1:34 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Tue, Dec 12, 2017 at 12:28:26PM +0530, Jagan Teki wrote:
> >> USB-OTG require MUSB driver along with PHY#0 id(PH9) and/or
> >> vbus pin through AXP_GPIO driver.
> >>
> >> This patch add support for it.
> >>
> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> >> ---
> >>  configs/bananapi_m64_defconfig | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
> >> index 461567f..55feafe 100644
> >> --- a/configs/bananapi_m64_defconfig
> >> +++ b/configs/bananapi_m64_defconfig
> >> @@ -4,6 +4,8 @@ CONFIG_MACH_SUN50I=y
> >>  CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y
> >>  CONFIG_MMC0_CD_PIN="PH13"
> >>  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> >> +CONFIG_USB0_ID_DET="PH9"
> >> +CONFIG_AXP_GPIO=y
> >>  CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
> >>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> >>  CONFIG_SPL=y
> >> @@ -14,4 +16,5 @@ CONFIG_SPL=y
> >>  # CONFIG_SPL_EFI_PARTITION is not set
> >>  CONFIG_SUN8I_EMAC=y
> >>  CONFIG_USB_EHCI_HCD=y
> >> +CONFIG_USB_MUSB_GADGET=y
> >
> > Did you test the host mode as well?
> 
> No, I've not tried host mode yet.

Then you didn't test that at least the ID pin and the VBUS control was
working :)

Maxime
diff mbox series

Patch

diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
index 461567f..55feafe 100644
--- a/configs/bananapi_m64_defconfig
+++ b/configs/bananapi_m64_defconfig
@@ -4,6 +4,8 @@  CONFIG_MACH_SUN50I=y
 CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y
 CONFIG_MMC0_CD_PIN="PH13"
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_USB0_ID_DET="PH9"
+CONFIG_AXP_GPIO=y
 CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL=y
@@ -14,4 +16,5 @@  CONFIG_SPL=y
 # CONFIG_SPL_EFI_PARTITION is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_MUSB_GADGET=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y