Message ID | 20171211131849.GA35836@intel.com |
---|---|
State | New |
Headers | show |
Series | string: Replace = with += in CFLAGS-tst-xbzero-opt.c | expand |
On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote: > Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile > to define CFLAGS-tst-xbzero-opt.c. > > Any comments? > > H.J. > * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=. I think that should be done for all such assignments. Andreas.
On Mon, Dec 11, 2017 at 5:32 AM, Andreas Schwab <schwab@suse.de> wrote: > On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote: > >> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile >> to define CFLAGS-tst-xbzero-opt.c. >> >> Any comments? >> >> H.J. >> * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=. > > I think that should be done for all such assignments. > By "all", did you mean CFLAGS-xxx in */Makefile or CFLAGS-xxx in string/Makefile?
On Dez 11 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote: > On Mon, Dec 11, 2017 at 5:32 AM, Andreas Schwab <schwab@suse.de> wrote: >> On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote: >> >>> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile >>> to define CFLAGS-tst-xbzero-opt.c. >>> >>> Any comments? >>> >>> H.J. >>> * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=. >> >> I think that should be done for all such assignments. >> > > By "all", did you mean CFLAGS-xxx in */Makefile or CFLAGS-xxx in > string/Makefile? Everywhere, if you like to work on that. Andreas.
On Mon, Dec 11, 2017 at 5:39 AM, Andreas Schwab <schwab@suse.de> wrote: > On Dez 11 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote: > >> On Mon, Dec 11, 2017 at 5:32 AM, Andreas Schwab <schwab@suse.de> wrote: >>> On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote: >>> >>>> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile >>>> to define CFLAGS-tst-xbzero-opt.c. >>>> >>>> Any comments? >>>> >>>> H.J. >>>> * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=. >>> >>> I think that should be done for all such assignments. >>> >> >> By "all", did you mean CFLAGS-xxx in */Makefile or CFLAGS-xxx in >> string/Makefile? > > Everywhere, if you like to work on that. I am checking in this patch to cover string/Makefile. I will submit a separate patch for */Makefile.
diff --git a/string/Makefile b/string/Makefile index d7e90a38a5..618b737b13 100644 --- a/string/Makefile +++ b/string/Makefile @@ -75,7 +75,7 @@ CFLAGS-tst-strlen.c = -fno-builtin CFLAGS-stratcliff.c = -fno-builtin CFLAGS-test-ffs.c = -fno-builtin CFLAGS-tst-inlcall.c = -fno-builtin -CFLAGS-tst-xbzero-opt.c = -O3 +CFLAGS-tst-xbzero-opt.c += -O3 # BZ 21006: Resolve all functions but at least explicit_bzero at startup. # Otherwise the test fails on s390x as the memcpy in prepare_test_buffer is # done by loading r4 / r5 with the test_pattern and using store multiple