| Message ID | 1512989626-4303-2-git-send-email-tien.fong.chee@intel.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Generic firmware loader | expand |
On 12/11/2017 11:53 AM, tien.fong.chee@intel.com wrote: > From: Tien Fong Chee <tien.fong.chee@intel.com> So the tags would imply this has a lot to do with SoCFPGA, but this is not touching any file in the SoCFPGA. The tags are thus completely bogus. > This patch removes the static declation on spl_mmc_find_device_function > so this function is accessible by the caller from other file. This patch > is required for later patch. > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > --- > common/spl/spl_mmc.c | 2 +- > include/spl.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c > index b57e0b0..183d05a 100644 > --- a/common/spl/spl_mmc.c > +++ b/common/spl/spl_mmc.c > @@ -114,7 +114,7 @@ static int spl_mmc_get_device_index(u32 boot_device) > return -ENODEV; > } > > -static int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device) > +int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device) > { > #if CONFIG_IS_ENABLED(DM_MMC) > struct udevice *dev; > diff --git a/include/spl.h b/include/spl.h > index 308ce7b..912983a 100644 > --- a/include/spl.h > +++ b/include/spl.h > @@ -10,6 +10,7 @@ > /* Platform-specific defines */ > #include <linux/compiler.h> > #include <asm/spl.h> > +#include <mmc.h> > > /* Value in r0 indicates we booted from U-Boot */ > #define UBOOT_NOT_LOADED_FROM_SPL 0x13578642 > @@ -72,6 +73,7 @@ void preloader_console_init(void); > u32 spl_boot_device(void); > u32 spl_boot_mode(const u32 boot_device); > void spl_set_bd(void); > +int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device); > > /** > * spl_set_header_raw_uboot() - Set up a standard SPL image structure >
On Isn, 2017-12-11 at 12:03 +0100, Marek Vasut wrote: > On 12/11/2017 11:53 AM, tien.fong.chee@intel.com wrote: > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > So the tags would imply this has a lot to do with SoCFPGA, but this > is > not touching any file in the SoCFPGA. The tags are thus completely > bogus. > Opps...sorry, i forgot to remove the socfpga tag. I would fix it. > > > > This patch removes the static declation on > > spl_mmc_find_device_function > > so this function is accessible by the caller from other file. This > > patch > > is required for later patch. > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > --- > > common/spl/spl_mmc.c | 2 +- > > include/spl.h | 2 ++ > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c > > index b57e0b0..183d05a 100644 > > --- a/common/spl/spl_mmc.c > > +++ b/common/spl/spl_mmc.c > > @@ -114,7 +114,7 @@ static int spl_mmc_get_device_index(u32 > > boot_device) > > return -ENODEV; > > } > > > > -static int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device) > > +int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device) > > { > > #if CONFIG_IS_ENABLED(DM_MMC) > > struct udevice *dev; > > diff --git a/include/spl.h b/include/spl.h > > index 308ce7b..912983a 100644 > > --- a/include/spl.h > > +++ b/include/spl.h > > @@ -10,6 +10,7 @@ > > /* Platform-specific defines */ > > #include <linux/compiler.h> > > #include <asm/spl.h> > > +#include <mmc.h> > > > > /* Value in r0 indicates we booted from U-Boot */ > > #define UBOOT_NOT_LOADED_FROM_SPL 0x13578642 > > @@ -72,6 +73,7 @@ void preloader_console_init(void); > > u32 spl_boot_device(void); > > u32 spl_boot_mode(const u32 boot_device); > > void spl_set_bd(void); > > +int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device); > > > > /** > > * spl_set_header_raw_uboot() - Set up a standard SPL image > > structure > > >
diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c index b57e0b0..183d05a 100644 --- a/common/spl/spl_mmc.c +++ b/common/spl/spl_mmc.c @@ -114,7 +114,7 @@ static int spl_mmc_get_device_index(u32 boot_device) return -ENODEV; } -static int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device) +int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device) { #if CONFIG_IS_ENABLED(DM_MMC) struct udevice *dev; diff --git a/include/spl.h b/include/spl.h index 308ce7b..912983a 100644 --- a/include/spl.h +++ b/include/spl.h @@ -10,6 +10,7 @@ /* Platform-specific defines */ #include <linux/compiler.h> #include <asm/spl.h> +#include <mmc.h> /* Value in r0 indicates we booted from U-Boot */ #define UBOOT_NOT_LOADED_FROM_SPL 0x13578642 @@ -72,6 +73,7 @@ void preloader_console_init(void); u32 spl_boot_device(void); u32 spl_boot_mode(const u32 boot_device); void spl_set_bd(void); +int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device); /** * spl_set_header_raw_uboot() - Set up a standard SPL image structure