diff mbox series

[U-Boot] gpio/hsdk: Depend on DM_GPIO instead of simple DM

Message ID 1512928544-25682-1-git-send-email-abrodkin@synopsys.com
State Accepted
Commit d5fbcd57ed7cdcbaddf54a45e85b465bb85bfec5
Delegated to: Alexey Brodkin
Headers show
Series [U-Boot] gpio/hsdk: Depend on DM_GPIO instead of simple DM | expand

Commit Message

Alexey Brodkin Dec. 10, 2017, 5:55 p.m. UTC
This driver really is DM GPIO one and so we need to have a correct
dependency, because DM alone doesn't provide required for CMD_GPIO
call and we're seeing build failures like this:
---------------------->8---------------------
cmd/built-in.o: In function 'do_gpio':
.../cmd/gpio.c:188: undefined reference to 'gpio_request'
...
---------------------->8---------------------

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Eugeniy Paltsev <paltsev@synopsys.com>
Cc: Simon Glass <sjg@chromium.org>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Dec. 12, 2017, 4:38 a.m. UTC | #1
On 10 December 2017 at 10:55, Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
> This driver really is DM GPIO one and so we need to have a correct
> dependency, because DM alone doesn't provide required for CMD_GPIO
> call and we're seeing build failures like this:
> ---------------------->8---------------------
> cmd/built-in.o: In function 'do_gpio':
> .../cmd/gpio.c:188: undefined reference to 'gpio_request'
> ...
> ---------------------->8---------------------
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Eugeniy Paltsev <paltsev@synopsys.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  drivers/gpio/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 2acb33bb51bc..b4e859e40cfe 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -82,7 +82,7 @@  config IMX_RGPIO2P
 
 config HSDK_CREG_GPIO
 	bool "HSDK CREG GPIO griver"
-	depends on DM
+	depends on DM_GPIO
 	default n
 	help
 	  This driver supports CREG GPIOs on Synopsys HSDK SOC.