diff mbox series

[v2] gdb: prevent installation of libbfd.so and libopcode.so

Message ID 20171208212952.20366-1-ps.report@gmx.net
State Accepted
Headers show
Series [v2] gdb: prevent installation of libbfd.so and libopcode.so | expand

Commit Message

Peter Seiderer Dec. 8, 2017, 9:29 p.m. UTC
The gdb install target installs dynamic versions of libbfd and
libopcode, accidentally overwriting the binutils provided versions
(gdb itself links against the bundled static ones to avoid
version problems, so the dynamic ones are un-needed).

Prevent the installation by using the '--disable-install-libbfd'
configure option.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
  - enhance commit log (suggested by Thomas Petazzoni)
  - use --disable-install-libbfd instead of --disable-shared
---
 package/gdb/gdb.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni Dec. 17, 2017, 9:19 a.m. UTC | #1
Hello,

On Fri,  8 Dec 2017 22:29:52 +0100, Peter Seiderer wrote:
> The gdb install target installs dynamic versions of libbfd and
> libopcode, accidentally overwriting the binutils provided versions
> (gdb itself links against the bundled static ones to avoid
> version problems, so the dynamic ones are un-needed).
> 
> Prevent the installation by using the '--disable-install-libbfd'
> configure option.
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
>   - enhance commit log (suggested by Thomas Petazzoni)
>   - use --disable-install-libbfd instead of --disable-shared
> ---
>  package/gdb/gdb.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Thanks a lot for the much clearer explanation, now everything is clear.
Patch applied, thanks a lot!

Thomas
Peter Korsgaard Dec. 27, 2017, 4:35 p.m. UTC | #2
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > The gdb install target installs dynamic versions of libbfd and
 > libopcode, accidentally overwriting the binutils provided versions
 > (gdb itself links against the bundled static ones to avoid
 > version problems, so the dynamic ones are un-needed).

 > Prevent the installation by using the '--disable-install-libbfd'
 > configure option.

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
 > ---
 > Changes v1 -> v2:
 >   - enhance commit log (suggested by Thomas Petazzoni)
 >   - use --disable-install-libbfd instead of --disable-shared

Committed to 2017.11.x, thanks.
Peter Korsgaard Dec. 30, 2017, 11:06 p.m. UTC | #3
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > The gdb install target installs dynamic versions of libbfd and
 > libopcode, accidentally overwriting the binutils provided versions
 > (gdb itself links against the bundled static ones to avoid
 > version problems, so the dynamic ones are un-needed).

 > Prevent the installation by using the '--disable-install-libbfd'
 > configure option.

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
 > ---
 > Changes v1 -> v2:
 >   - enhance commit log (suggested by Thomas Petazzoni)
 >   - use --disable-install-libbfd instead of --disable-shared

Committed to 2017.02.x, thanks.
diff mbox series

Patch

diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
index 7e86ba0c7e..0f3846687e 100644
--- a/package/gdb/gdb.mk
+++ b/package/gdb/gdb.mk
@@ -55,9 +55,11 @@  endif
 
 # When gdb sources are fetched from the binutils-gdb repository, they
 # also contain the binutils sources, but binutils shouldn't be built,
-# so we disable it.
+# so we disable it (additional the option --disable-install-libbfd
+# prevents the un-wanted installation of libobcodes.so and libbfd.so).
 GDB_DISABLE_BINUTILS_CONF_OPTS = \
 	--disable-binutils \
+	--disable-install-libbfd \
 	--disable-ld \
 	--disable-gas