| Message ID | 1512733191-32545-1-git-send-email-jagan@amarulasolutions.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [U-Boot] sunxi: OLinuXino: Drop FASTBOOT_FLASH | expand |
On Fri, Dec 08, 2017 at 05:09:51PM +0530, Jagan Teki wrote: > FASTBOOT_FLASH is auto select for sunxi platform now, > so drop explicit addition. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> There's far more boards than these three, maybe we should do all of them? Maxime
On Fri, Dec 8, 2017 at 5:26 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Fri, Dec 08, 2017 at 05:09:51PM +0530, Jagan Teki wrote: >> FASTBOOT_FLASH is auto select for sunxi platform now, >> so drop explicit addition. >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > There's far more boards than these three, maybe we should do all of > them? True, but this is because I've tested these.
On Fri, Dec 08, 2017 at 05:30:45PM +0530, Jagan Teki wrote: > On Fri, Dec 8, 2017 at 5:26 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Fri, Dec 08, 2017 at 05:09:51PM +0530, Jagan Teki wrote: > >> FASTBOOT_FLASH is auto select for sunxi platform now, > >> so drop explicit addition. > >> > >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > > There's far more boards than these three, maybe we should do all of > > them? > > True, but this is because I've tested these. Still, running moveconfig -s is pretty safe here. You just want to make sure that the config is the same, and it will be. Maxime
diff --git a/configs/A13-OLinuXino_defconfig b/configs/A13-OLinuXino_defconfig index 3c2a6f8..4e65698 100644 --- a/configs/A13-OLinuXino_defconfig +++ b/configs/A13-OLinuXino_defconfig @@ -16,7 +16,6 @@ CONFIG_DEFAULT_DEVICE_TREE="sun5i-a13-olinuxino" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y CONFIG_SPL_I2C_SUPPORT=y -CONFIG_FASTBOOT_FLASH=y CONFIG_CMD_DFU=y # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set diff --git a/configs/A20-OLinuXino-Lime2-eMMC_defconfig b/configs/A20-OLinuXino-Lime2-eMMC_defconfig index cd1fa64..2f2b5d1 100644 --- a/configs/A20-OLinuXino-Lime2-eMMC_defconfig +++ b/configs/A20-OLinuXino-Lime2-eMMC_defconfig @@ -13,7 +13,6 @@ CONFIG_AHCI=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y CONFIG_SPL_I2C_SUPPORT=y -CONFIG_FASTBOOT_FLASH=y CONFIG_CMD_DFU=y # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set diff --git a/configs/A20-OLinuXino-Lime2_defconfig b/configs/A20-OLinuXino-Lime2_defconfig index 4a90ab6..9492cae 100644 --- a/configs/A20-OLinuXino-Lime2_defconfig +++ b/configs/A20-OLinuXino-Lime2_defconfig @@ -12,7 +12,6 @@ CONFIG_AHCI=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y CONFIG_SPL_I2C_SUPPORT=y -CONFIG_FASTBOOT_FLASH=y CONFIG_CMD_DFU=y # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set
FASTBOOT_FLASH is auto select for sunxi platform now, so drop explicit addition. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- configs/A13-OLinuXino_defconfig | 1 - configs/A20-OLinuXino-Lime2-eMMC_defconfig | 1 - configs/A20-OLinuXino-Lime2_defconfig | 1 - 3 files changed, 3 deletions(-)