| Message ID | 20171208042654.10910-3-peterx@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] intel_iommu: remove X86_IOMMU_PCI_DEVFN_MAX | expand |
Looks good. Reviewed-by: Liu, Yi L <yi.l.liu@intel.com> On Fri, Dec 08, 2017 at 12:26:54PM +0800, Peter Xu wrote: > It should be caching-mode. It may confuse people when it pops up. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > hw/i386/intel_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index c1fa08d205..fe15d3ba84 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -2327,7 +2327,7 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu, > IntelIOMMUNotifierNode *next_node = NULL; > > if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) { > - error_report("We need to set cache_mode=1 for intel-iommu to enable " > + error_report("We need to set caching-mode=1 for intel-iommu to enable " > "device assignment with IOMMU protection."); > exit(1); > } > -- > 2.14.3 > >
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index c1fa08d205..fe15d3ba84 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2327,7 +2327,7 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu, IntelIOMMUNotifierNode *next_node = NULL; if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) { - error_report("We need to set cache_mode=1 for intel-iommu to enable " + error_report("We need to set caching-mode=1 for intel-iommu to enable " "device assignment with IOMMU protection."); exit(1); }
It should be caching-mode. It may confuse people when it pops up. Signed-off-by: Peter Xu <peterx@redhat.com> --- hw/i386/intel_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)