From patchwork Thu Dec 7 21:30:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 845856 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JM6cl0Ty"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yt7z51Qgwz9sBW for ; Fri, 8 Dec 2017 08:34:09 +1100 (AEDT) Received: from localhost ([::1]:34414 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3nz-0000iH-6g for incoming@patchwork.ozlabs.org; Thu, 07 Dec 2017 16:34:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3kS-0005YV-Ob for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN3kO-0001uV-Eb for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:27 -0500 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:37619) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN3kO-0001tP-85 for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:24 -0500 Received: by mail-pf0-x243.google.com with SMTP id n6so5653091pfa.4 for ; Thu, 07 Dec 2017 13:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WTeBqdQtfRYcWqJwQfs3vBs8+Sgu29U16AqBLX3IgL8=; b=JM6cl0TyX0niGQoWXZaEibpniA5XEaKtzdjXv1E+cXKQPvy7YAL/oDwH6rvJISKvm5 NeQ+wFIwdWLBZCvxLS9+q5kscwyad9L8ZLMKuaKbHR1/rDl/LLWb4ckeLQdL1iPAcl8I X2RG2AeFh4nJx8R9kT/PWGRD6H7aFFxyhrIGaV5pQnF942zyC0V3Rgw86vRUqzLQ3QEi ZKGty75rslsOo/O08VVaoTh4rRvRTClgHFlTlIwW0t0cgRoDthUDwy836YtI/pY1nHNK 60Q3I/gE+IHIIQc3T3wBjq3Amopgf9lve9iVC0A5cG7/Gs+sI8Zy0nOv+f5lrn6FEbZ5 /LYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=WTeBqdQtfRYcWqJwQfs3vBs8+Sgu29U16AqBLX3IgL8=; b=U7oLmWVdjJkUTFZN8DxqIUrgpOVHDaxeGSeN06zEG2EWjmG7LDtZ/2q2Yh2UBWaaXs lxMZs9xmCbi3AEfLVoMAQgmNaGIeFRkRH43Khe7bWXbH6rMM28q9AHEVjV1mFNGtMOsp cqilOmkzaiaxKtIoTMX/J3jWQyHWMhCFTpkJuni4qfMT9wdtNnKKVw+GEOHlaLSqX45O KoQ3g5shZaksRgEEmzyjYPIsKk1TVnxQca4q14tWpyc4wFFE128gBoEmbiFfD1WIQMVL zeGIH/o6TUPaXu/2xIiQMJn6wLv3CPsyq44QYRnW1iPDLK8/BvG2VK30y6eyzG8xUiHI gVSw== X-Gm-Message-State: AJaThX6ORSOrNZHROCiMJYT4mu8Mb40eFGrNvsl+6tw0VGbYYSh/8rNk oWkNO6osaLfJ6k0HeBaSbA== X-Google-Smtp-Source: AGs4zMZbCxkR29OyK0htWJ2YhP7ITAIQmB1XWvfGyoj1W/d4IUxiXoQtdvNGQf1nuHuBtVJ7OemhxQ== X-Received: by 10.84.133.111 with SMTP id 102mr27485178plf.136.1512682223080; Thu, 07 Dec 2017 13:30:23 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id k80sm12678231pfh.30.2017.12.07.13.30.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:30:22 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 09DAB96; Thu, 7 Dec 2017 15:30:19 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id A787430007F; Thu, 7 Dec 2017 15:30:17 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:30:06 -0600 Message-Id: <1512682213-4354-2-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512682213-4354-1-git-send-email-minyard@acm.org> References: <1512682213-4354-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH 1/8] ipmi: Fix SEL get/set time commands X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard The minimum message size was on the wrong commands, for getting the time it's zero and for setting the time it's 6. Signed-off-by: Corey Minyard Reviewed-by: Cédric Le Goater Reviewed-by: Marc-André Lureau --- hw/ipmi/ipmi_bmc_sim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 277c28c..cc068f2 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -1802,8 +1802,8 @@ static const IPMICmdHandler storage_cmds[] = { [IPMI_CMD_GET_SEL_ENTRY] = { get_sel_entry, 8 }, [IPMI_CMD_ADD_SEL_ENTRY] = { add_sel_entry, 18 }, [IPMI_CMD_CLEAR_SEL] = { clear_sel, 8 }, - [IPMI_CMD_GET_SEL_TIME] = { get_sel_time, 6 }, - [IPMI_CMD_SET_SEL_TIME] = { set_sel_time }, + [IPMI_CMD_GET_SEL_TIME] = { get_sel_time }, + [IPMI_CMD_SET_SEL_TIME] = { set_sel_time, 6 }, }; static const IPMINetfn storage_netfn = {