[PATH,net,2/4] tcp: always evaluate losses in RACK upon undo

Message ID 20171207193333.59039-3-ycheng@google.com
State Accepted
Delegated to: David Miller
Headers show
  • tcp: RACK loss recovery bug fixes
Related show

Commit Message

Yuchung Cheng Dec. 7, 2017, 7:33 p.m.
When sender detects spurious retransmission, all packets
marked lost are remarked to be in-flight. However some may
be considered lost based on its timestamps in RACK. This patch
forces RACK to re-evaluate, which may be skipped previously if
the ACK does not advance RACK timestamp.

Signed-off-by: Yuchung Cheng <ycheng@google.com>
Reviewed-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Priyaranjan Jha <priyarjha@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
 net/ipv4/tcp_input.c | 1 +
 1 file changed, 1 insertion(+)


diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 734cfc8ff76e..5a240f9d208b 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -2326,6 +2326,7 @@  static void tcp_undo_cwnd_reduction(struct sock *sk, bool unmark_loss)
 	tp->snd_cwnd_stamp = tcp_jiffies32;
 	tp->undo_marker = 0;
+	tp->rack.advanced = 1; /* Force RACK to re-exam losses */
 static inline bool tcp_may_undo(const struct tcp_sock *tp)