From patchwork Thu Dec 7 16:44:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Manoil X-Patchwork-Id: 845670 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yt1Y30Xpfz9s72 for ; Fri, 8 Dec 2017 03:44:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753767AbdLGQob (ORCPT ); Thu, 7 Dec 2017 11:44:31 -0500 Received: from mail-sn1nam02on0075.outbound.protection.outlook.com ([104.47.36.75]:44821 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753241AbdLGQo2 (ORCPT ); Thu, 7 Dec 2017 11:44:28 -0500 Received: from BLUPR0301CA0041.namprd03.prod.outlook.com (10.162.113.179) by CO2PR03MB2357.namprd03.prod.outlook.com (10.166.93.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Thu, 7 Dec 2017 16:44:26 +0000 Received: from BL2FFO11FD049.protection.gbl (2a01:111:f400:7c09::142) by BLUPR0301CA0041.outlook.office365.com (2a01:111:e400:5259::51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Thu, 7 Dec 2017 16:44:26 +0000 Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD049.mail.protection.outlook.com (10.173.161.211) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.239.4 via Frontend Transport; Thu, 7 Dec 2017 16:44:28 +0000 Received: from fsr-ub1664-016.ea.freescale.net (fsr-ub1664-016.ea.freescale.net [10.171.71.216]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vB7GiNax024403; Thu, 7 Dec 2017 09:44:24 -0700 From: Claudiu Manoil To: CC: Andrew Lunn , "David S . Miller" , Shaohui Xie Subject: [PATCH net] gianfar: Disable EEE autoneg by default Date: Thu, 7 Dec 2017 18:44:23 +0200 Message-ID: <1512665063-1680-1-git-send-email-claudiu.manoil@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20171128062901.22210-1-yangbo.lu@nxp.com> References: <20171128062901.22210-1-yangbo.lu@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131571386689738779; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(336005)(346002)(376002)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(189003)(199004)(54906003)(68736007)(50466002)(316002)(97736004)(48376002)(2906002)(104016004)(86362001)(8656006)(51416003)(36756003)(76176011)(4326008)(53936002)(105606002)(47776003)(81156014)(33646002)(305945005)(50226002)(81166006)(356003)(8936002)(2351001)(5660300001)(2950100002)(77096006)(498600001)(16586007)(8676002)(106466001)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2357; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD049; 1:98wKUYtMHBKCtMujiFmrRp83c17dWqiqWng2AkPFElfEqdrn/bLmvsaBPko+9+wZIbWx/MSzfQOBZtIfMd2pviFY2I4eH7GcQNDO/F1+7yUlUlivz3ehq382dyfHABhv MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1caff52a-d6ea-4fe4-581b-08d53d91c8b6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603286); SRVR:CO2PR03MB2357; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2357; 3:x/5REMXBLXlzr1lFZS9DAmc3xDdn5Q+vrZOlnEdu1b16Y5EMnTcSo09dSbkvayjsHrIusXsjxjp7sLxEpJ/RTGVep4Pe3gOdb14ihRMe99WXiT56nozIlytJgGMVfRWBcshFTlUZz+B5Ll8uP41iR2GtBGF6jJumbvEnirpPZz9t9joV/skzeCp80F4tmLWG66Ct3/o6vVqR4aKzRdPZVM16N+YLlqXAcXRtLo1hE19piKO3MrfX4Dq6tS6FN9vW2FxlOBr1oLgOTBkxeCnEpJdKX3F+AWPWmhkys+Hh7/20pDBbvzHaoBJ+a8vb9Et/EvkGoHQ8/yn7hDJzHdmr/k5pcxxS+CQ20We/Y1XP/Mc=; 25:DJRNTnW+wtASo6kXaUxE003OGoj//WKDPXlH39s9eolMrV3yWXp30VY4nuVdIf2rQDr/+H1fjLMsVsNaFP0WVeBmBNGm+xd1MvCRX4h3lVHDmCbUXeXGHUu3IuNzEOczUpfo8erQS14CWivLvj14IaTklIXs8rj9/yBYYSdIuRDn6+YTYhXGkncvORCnBjki8vxjDW9cI86xYS1sq5jDTagkWfyEbdB+Ohf9ZUZTBZRFdgixLf6IbeId6877UKF+FsUUSkAf5lpR3VCU5xI37Rhke8RMngq+TSGq2tJ/DOsw+WS818OV9lYSgD1p4XJXfjUYCmBSWG6e6VTFrf6LRw== X-MS-TrafficTypeDiagnostic: CO2PR03MB2357: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2357; 31:GLqwuq6xAhvaM2NhFva7bvsp7KMfED3AkFrKPvNNHDfLHFbhoZmk7AtTsAm+/466ToYvdyyUYT6rHkfRon5uxp14zMLM4J1uslI2hXGN5st+4aGSWetheOeRmeFf1lXLr2cfrb9p+oCTZpLtSn49A5zoIi9vljmIAvfI3QYnJFqw241Y5UCLe9gd/RsemqCXV0PQYmK9JdDFkoFwWjMcyAvkeWV8/KTdKYuSqoEwxfk=; 4:1P0DTw8cXg/UtD+OTD5yFS89m4MyIVu4qenkNoAN74oVr6YCOACCul1abn7D9URfcQRpJo4FbDPe0z4s4k74ktWi+HiDVyWslpprAWQa/Oad51tedJZSM5PkCZ+h1MSbuMWI3ELbbBcQaL8qcBJItKyExk+hmCP684Ee4Wed7P45wVwrmG6CFyP6+OrSNHMLCTaZdJj9sTWhfRRCoW/tT3++vlMG7ZtJXLN0F2vZB6f1vwgDgiDcTEc0uKx3mpdPg55FBwMoqTVsBMPtCQl3gCv3G9FUmtd3t4S0JWJh8R2J5NdAT9IWY4frAzVFbI4EZjwDWTHOXhLpiG+To4TnknhELDVCcSr+t9+c3vt0D88= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(21532816269658); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231022)(10201501046)(6055026)(6096035)(20161123563025)(20161123559100)(20161123556025)(20161123561025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123565025)(201708071742011); SRVR:CO2PR03MB2357; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CO2PR03MB2357; X-Forefront-PRVS: 05143A8241 X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2357; 23:CVE8JWi+GTc8ty5l2n6Z3ThkVGNeC2UTy5tQzUrlmpgLfdpLW6Ti2TGNucYs806pZkC5POrA3tZ6YKopJph2BTDoM3TAyC5BjtgsSLWXbyw8pZsHfKZv5FIKlK0XYFidI7qfrVI9a/zy5qPKulADUMFAsfju5D76SK/Zt0sqncPSH6EarL9Wevg190Nm1SanhoUIkJax4QtW3CU7/nIa6UgRu3aSST2MPVG6kM69YcxNSZOl05ReMD21TwNxRI8d89+Rh4mW2mf4no7JOwFHUHEA/nVj5okQNN/Wix73O6eUJ3MHaavRW94jF6TQa6g94fSMkK/3/ssh/y9fI3XHcIDvimqvx3EwuS/+M5Bs61lBvBEVPU9k7SMBglgW5b5l+8Kxh4tgxD2kYmkjKyCAlbTH+oKLV5XNDWfrarq8vJjVGL5cb3JDvOezdPGLl3MqMUDi7GfgbWOv1v7v5F6nzBYLJqj8AVBH16sN8aTrCB2KaqDBSh5lt3kYS/DZ4xGvbFJKOxC3MboM+PhzPiCTN67hS4nysTrIBdk6fVl3IH3DDfurg7TPszfqzGc0iR3spzHr3F259GRCt/NakO5qWKTMR6KziO4n3N/fZKrh1NZ7pfel7VoDtr0W1uAlCWfVpnrG3/0IeFZJiQWAb7i6ns9qC59oJdheFQN2HPPU4iROx1OBCeKYxurkZbDWA/9TO/DzVJzUtU4NDRDOnJr40kC0xHk3hYYi3lUU8NrypSpbauUcjGfotta+Y9Y6MF60Q0LhVl1ALCoHlLv39x1Uod2ZgLKHY9vVQLX+wY13MmBLggDt0ZHmA0vTiVsV/6JsB+VAvTwdyj7OKMBzYJ1K9ghL2TX2KCagY6OAC+lTx+asU9kJ4zuCKPFkHOG4fk1XbjPuxcPxR4JA94AnlYyAU7TtvhQZG0tucicnrTOLgxDtZrGG5YeY3P3aPGt6X0Ft07GcjDZukb/9+a6JfF5C9pdgkvP/dckrRjAqxLrSTVbmMcJRC2UJDiYdxgDbOe8guTzSsy+PDLdoPnhpcWUH/F3xX73ocPOb8IqDbljCiqo= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2357; 6:4KandYGTC65iii5ZkbKKzMcgnqKkBc+3plDCUY8R2MgunUYlDX3Q51nb/998QtT5da/tZAfHX1UsPmsCDtHKxQ1lMNyb0/2zh7kjs+kDluyZBTGGvaqaDGuIY0U93AXErfClRc7hWbHc+uxIqtl72HdTWzDqU4GIAqpk5IDWOcXksxlumN5kcjrmbNuMtVsXMBPum2WULEB/oRs9nI8Hd9GN6c1YElokuXOmoRM13pMP/u93rrfSPy73gTvUhDHNFnnImqQddvJeI5IUoeHzQSJOByoDYxdBHG85S2E5YOK/bcSJ4JELqkF0MIvPcRzYbhW8ZMoDvvm11pHFxgRtCZZ7UKudUptaBF4izXnVK8U=; 5:pXQfV1QPkK6mJUAxYT9RQ1Zt8oz0899HnfMCGofH5qj9uS+/lO6qeWAJg2IQCCfQWRnHYqfVtI+V0L4yviQsRnwWngMwILEy5A4nJsO4uO/X3vVs0cN7Yyjo6/myD3jOJoNVF8d1RgUeIdpaYzn4EfGVoxcJbZ/vamsNG2pVA+k=; 24:y4m40g1Ft6yeWtUgg9PuAP0PDudzlIerPFusLFhaMG7jfhFEyJx1459VuERQ320zYQYTMx/Qz9YhTl8lxB5r9bFNzFISBDl0aWdeAXYPE1I=; 7:3Q5iicZ0g7JgbEtr+uaaQnS2GxWfpcjlxDtH/0ipG0Oqcsuugiz9H0S6aqWXQl/Sbe+DcXwbkkfjQqj8GPV8J6HK7ggS7ToEbJhPPK6nG8OQemRqVJADuaYVv9cQPpZikg3HJRxxXMKI/tdon26tGv1zfXsVyE20kxLCUYNWYUWW53KbJt2O7d9Y8cGlk3bvw59JR3bGHn+lV/lUzNk+8yzvstEC+LY96rRR/leu7r7TrDHziFlFonbRnMyTXdkS SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2017 16:44:28.8022 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1caff52a-d6ea-4fe4-581b-08d53d91c8b6 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2357 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This controller does not support EEE, but it may connect to a PHY which supports EEE and advertises EEE by default, while its link partner also advertises EEE. If this happens, the PHY enters low power mode when the traffic rate is low and causes packet loss. This patch disables EEE advertisement by default for any PHY that gianfar connects to, to prevent the above unwanted outcome. Signed-off-by: Shaohui Xie Tested-by: Yangbo Lu Signed-off-by: Claudiu Manoil Reviewed-by: Andrew Lunn --- drivers/net/ethernet/freescale/gianfar.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index 81a73af..7f83700 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1792,6 +1792,7 @@ static int init_phy(struct net_device *dev) GFAR_SUPPORTED_GBIT : 0; phy_interface_t interface; struct phy_device *phydev; + struct ethtool_eee edata; priv->oldlink = 0; priv->oldspeed = 0; @@ -1816,6 +1817,10 @@ static int init_phy(struct net_device *dev) /* Add support for flow control, but don't advertise it by default */ phydev->supported |= (SUPPORTED_Pause | SUPPORTED_Asym_Pause); + /* disable EEE autoneg, EEE not supported by eTSEC */ + memset(&edata, 0, sizeof(struct ethtool_eee)); + phy_ethtool_set_eee(phydev, &edata); + return 0; }