[5/6] ARM: dts: aspeed: peci-hwmon: Add Aspeed PECI hwmon

Message ID 20171206210323.7185-1-jae.hyun.yoo@linux.intel.com
State Changes Requested, archived
Headers show
Series
  • Add Aspeed PECI support
Related show

Commit Message

Jae Hyun Yoo Dec. 6, 2017, 9:03 p.m.
This commit adds Aspeed PECI hwmon node into aspeed-g4 and
aspeed-g5.

Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
 arch/arm/boot/dts/aspeed-g4.dtsi | 64 ++++++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/aspeed-g5.dtsi | 64 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 128 insertions(+)

Comments

Andrew Jeffery Dec. 7, 2017, 12:44 a.m. | #1
On Thu, 7 Dec 2017, at 07:33, Jae Hyun Yoo wrote:
> This commit adds Aspeed PECI hwmon node into aspeed-g4 and
> aspeed-g5.
> 
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 64
>  ++++++++++++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/aspeed-g5.dtsi | 64
>  ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 128 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi
> b/arch/arm/boot/dts/aspeed-g4.dtsi
> index d45f6b67fecc..f9904c2ee5d9 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -250,6 +250,70 @@
>  				clk-div = <0>;
>  				cmd-timeout-ms = <1000>;
>  				status = "disabled";
> +
> +                               peci_hwmon0: peci-hwmon-cpu0 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <0>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon1: peci-hwmon-cpu1 {

I feel like this is all better left to the platform dts rather than
describing then disabling host topology in the SoC dtsi. This applies to
the g5 dtsi as well.

Cheers,

Andrew

> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <1>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon2: peci-hwmon-cpu2 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <2>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon3: peci-hwmon-cpu3 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <3>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon4: peci-hwmon-cpu4 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <4>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon5: peci-hwmon-cpu5 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <5>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon6: peci-hwmon-cpu6 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <6>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon7: peci-hwmon-cpu7 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <7>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
>  			};
>  
>  			timer: timer@1e782000 {
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi
> b/arch/arm/boot/dts/aspeed-g5.dtsi
> index c75998ef759c..749ed252f71e 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -301,6 +301,70 @@
>  				clk-div = <0>;
>  				cmd-timeout-ms = <1000>;
>  				status = "disabled";
> +
> +                               peci_hwmon0: peci-hwmon-cpu0 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <0>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon1: peci-hwmon-cpu1 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <1>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon2: peci-hwmon-cpu2 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <2>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon3: peci-hwmon-cpu3 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <3>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon4: peci-hwmon-cpu4 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <4>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon5: peci-hwmon-cpu5 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <5>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon6: peci-hwmon-cpu6 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <6>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon7: peci-hwmon-cpu7 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <7>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
>  			};
>  
>  			timer: timer@1e782000 {
> -- 
> 2.15.1
>
Jae Hyun Yoo Dec. 7, 2017, 10:10 p.m. | #2
On 12/6/2017 4:44 PM, Andrew Jeffery wrote:
> 
> 
> On Thu, 7 Dec 2017, at 07:33, Jae Hyun Yoo wrote:
>> This commit adds Aspeed PECI hwmon node into aspeed-g4 and
>> aspeed-g5.
>>
>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>> ---
>>   arch/arm/boot/dts/aspeed-g4.dtsi | 64
>>   ++++++++++++++++++++++++++++++++++++++++
>>   arch/arm/boot/dts/aspeed-g5.dtsi | 64
>>   ++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 128 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi
>> b/arch/arm/boot/dts/aspeed-g4.dtsi
>> index d45f6b67fecc..f9904c2ee5d9 100644
>> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
>> @@ -250,6 +250,70 @@
>>   				clk-div = <0>;
>>   				cmd-timeout-ms = <1000>;
>>   				status = "disabled";
>> +
>> +                               peci_hwmon0: peci-hwmon-cpu0 {
>> +                                       compatible =
>> "aspeed,ast2400-peci-hwmon";
>> +                                       cpu-id = <0>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon1: peci-hwmon-cpu1 {
> 
> I feel like this is all better left to the platform dts rather than
> describing then disabling host topology in the SoC dtsi. This applies to
> the g5 dtsi as well.
> 
> Cheers,
> 
> Andrew
> 

Agreed. It is already described in a documentation as an example. I'll
remove these default disabled settings from g4 and g5 so that each
platform can selectively enable these.

Thanks,

Jae

>> +                                       compatible =
>> "aspeed,ast2400-peci-hwmon";
>> +                                       cpu-id = <1>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon2: peci-hwmon-cpu2 {
>> +                                       compatible =
>> "aspeed,ast2400-peci-hwmon";
>> +                                       cpu-id = <2>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon3: peci-hwmon-cpu3 {
>> +                                       compatible =
>> "aspeed,ast2400-peci-hwmon";
>> +                                       cpu-id = <3>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon4: peci-hwmon-cpu4 {
>> +                                       compatible =
>> "aspeed,ast2400-peci-hwmon";
>> +                                       cpu-id = <4>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon5: peci-hwmon-cpu5 {
>> +                                       compatible =
>> "aspeed,ast2400-peci-hwmon";
>> +                                       cpu-id = <5>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon6: peci-hwmon-cpu6 {
>> +                                       compatible =
>> "aspeed,ast2400-peci-hwmon";
>> +                                       cpu-id = <6>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon7: peci-hwmon-cpu7 {
>> +                                       compatible =
>> "aspeed,ast2400-peci-hwmon";
>> +                                       cpu-id = <7>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>>   			};
>>   
>>   			timer: timer@1e782000 {
>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi
>> b/arch/arm/boot/dts/aspeed-g5.dtsi
>> index c75998ef759c..749ed252f71e 100644
>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
>> @@ -301,6 +301,70 @@
>>   				clk-div = <0>;
>>   				cmd-timeout-ms = <1000>;
>>   				status = "disabled";
>> +
>> +                               peci_hwmon0: peci-hwmon-cpu0 {
>> +                                       compatible =
>> "aspeed,ast2500-peci-hwmon";
>> +                                       cpu-id = <0>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon1: peci-hwmon-cpu1 {
>> +                                       compatible =
>> "aspeed,ast2500-peci-hwmon";
>> +                                       cpu-id = <1>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon2: peci-hwmon-cpu2 {
>> +                                       compatible =
>> "aspeed,ast2500-peci-hwmon";
>> +                                       cpu-id = <2>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon3: peci-hwmon-cpu3 {
>> +                                       compatible =
>> "aspeed,ast2500-peci-hwmon";
>> +                                       cpu-id = <3>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon4: peci-hwmon-cpu4 {
>> +                                       compatible =
>> "aspeed,ast2500-peci-hwmon";
>> +                                       cpu-id = <4>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon5: peci-hwmon-cpu5 {
>> +                                       compatible =
>> "aspeed,ast2500-peci-hwmon";
>> +                                       cpu-id = <5>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon6: peci-hwmon-cpu6 {
>> +                                       compatible =
>> "aspeed,ast2500-peci-hwmon";
>> +                                       cpu-id = <6>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>> +
>> +                               peci_hwmon7: peci-hwmon-cpu7 {
>> +                                       compatible =
>> "aspeed,ast2500-peci-hwmon";
>> +                                       cpu-id = <7>;
>> +                                       show-core = <1>;
>> +                                       dimm-nums = <16>;
>> +                                       status = "disabled";
>> +                               };
>>   			};
>>   
>>   			timer: timer@1e782000 {
>> -- 
>> 2.15.1
>>

Patch

diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index d45f6b67fecc..f9904c2ee5d9 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -250,6 +250,70 @@ 
 				clk-div = <0>;
 				cmd-timeout-ms = <1000>;
 				status = "disabled";
+
+				peci_hwmon0: peci-hwmon-cpu0 {
+					compatible = "aspeed,ast2400-peci-hwmon";
+					cpu-id = <0>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon1: peci-hwmon-cpu1 {
+					compatible = "aspeed,ast2400-peci-hwmon";
+					cpu-id = <1>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon2: peci-hwmon-cpu2 {
+					compatible = "aspeed,ast2400-peci-hwmon";
+					cpu-id = <2>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon3: peci-hwmon-cpu3 {
+					compatible = "aspeed,ast2400-peci-hwmon";
+					cpu-id = <3>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon4: peci-hwmon-cpu4 {
+					compatible = "aspeed,ast2400-peci-hwmon";
+					cpu-id = <4>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon5: peci-hwmon-cpu5 {
+					compatible = "aspeed,ast2400-peci-hwmon";
+					cpu-id = <5>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon6: peci-hwmon-cpu6 {
+					compatible = "aspeed,ast2400-peci-hwmon";
+					cpu-id = <6>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon7: peci-hwmon-cpu7 {
+					compatible = "aspeed,ast2400-peci-hwmon";
+					cpu-id = <7>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
 			};
 
 			timer: timer@1e782000 {
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index c75998ef759c..749ed252f71e 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -301,6 +301,70 @@ 
 				clk-div = <0>;
 				cmd-timeout-ms = <1000>;
 				status = "disabled";
+
+				peci_hwmon0: peci-hwmon-cpu0 {
+					compatible = "aspeed,ast2500-peci-hwmon";
+					cpu-id = <0>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon1: peci-hwmon-cpu1 {
+					compatible = "aspeed,ast2500-peci-hwmon";
+					cpu-id = <1>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon2: peci-hwmon-cpu2 {
+					compatible = "aspeed,ast2500-peci-hwmon";
+					cpu-id = <2>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon3: peci-hwmon-cpu3 {
+					compatible = "aspeed,ast2500-peci-hwmon";
+					cpu-id = <3>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon4: peci-hwmon-cpu4 {
+					compatible = "aspeed,ast2500-peci-hwmon";
+					cpu-id = <4>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon5: peci-hwmon-cpu5 {
+					compatible = "aspeed,ast2500-peci-hwmon";
+					cpu-id = <5>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon6: peci-hwmon-cpu6 {
+					compatible = "aspeed,ast2500-peci-hwmon";
+					cpu-id = <6>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
+
+				peci_hwmon7: peci-hwmon-cpu7 {
+					compatible = "aspeed,ast2500-peci-hwmon";
+					cpu-id = <7>;
+					show-core = <1>;
+					dimm-nums = <16>;
+					status = "disabled";
+				};
 			};
 
 			timer: timer@1e782000 {