From patchwork Wed Dec 6 17:39:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 845277 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ysQtC2sV9z9ryT for ; Thu, 7 Dec 2017 04:42:27 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3ysQtC1403zDrpd for ; Thu, 7 Dec 2017 04:42:27 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=permerror (mailfrom) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=benh@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ysQqv15BHzDrpN for ; Thu, 7 Dec 2017 04:40:26 +1100 (AEDT) Received: from pasglop.austin.ibm.com (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id vB6HdhvW020901; Wed, 6 Dec 2017 11:39:46 -0600 From: Benjamin Herrenschmidt To: skiboot@lists.ozlabs.org Date: Wed, 6 Dec 2017 11:39:26 -0600 Message-Id: <20171206173928.25628-4-benh@kernel.crashing.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171206173928.25628-1-benh@kernel.crashing.org> References: <20171206173928.25628-1-benh@kernel.crashing.org> Subject: [Skiboot] [PATCH 4/6] xive: Use io_complete() when changing the ESB mask bits X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Thus ensuring that the load has completed before anything else is done (ie, the interrupt is actually masked). Signed-off-by: Benjamin Herrenschmidt Tested-by: Oliver O'Halloran --- hw/xive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xive.c b/hw/xive.c index 76939b79..104e1e85 100644 --- a/hw/xive.c +++ b/hw/xive.c @@ -2451,7 +2451,7 @@ static void xive_update_irq_mask(struct xive_src *s, uint32_t idx, bool masked) if (s->flags & XIVE_SRC_SHIFT_BUG) offset <<= 4; - in_be64(mmio_base + offset); + in_complete(in_be64(mmio_base + offset)); } static int64_t xive_sync(struct xive *x)