| Message ID | 7884b866cbeba808b63d9de871ace53970561f41.1512542267.git.joe@perches.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | xen-netback: Fix logging message with spurious period after newline | expand |
> -----Original Message----- > From: Joe Perches [mailto:joe@perches.com] > Sent: 06 December 2017 06:40 > To: Wei Liu <wei.liu2@citrix.com>; Paul Durrant <Paul.Durrant@citrix.com> > Cc: xen-devel@lists.xenproject.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH] xen-netback: Fix logging message with spurious period > after newline > > Using a period after a newline causes bad output. > > Signed-off-by: Joe Perches <joe@perches.com> Reviewed-by: Paul Durrant <paul.durrant@citrix.com> > --- > drivers/net/xen-netback/interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen- > netback/interface.c > index d6dff347f896..78ebe494fef0 100644 > --- a/drivers/net/xen-netback/interface.c > +++ b/drivers/net/xen-netback/interface.c > @@ -186,7 +186,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct > net_device *dev) > /* Obtain the queue to be used to transmit this packet */ > index = skb_get_queue_mapping(skb); > if (index >= num_queues) { > - pr_warn_ratelimited("Invalid queue %hu for packet on > interface %s\n.", > + pr_warn_ratelimited("Invalid queue %hu for packet on > interface %s\n", > index, vif->dev->name); > index %= num_queues; > } > -- > 2.15.0
From: Joe Perches <joe@perches.com> Date: Tue, 5 Dec 2017 22:40:25 -0800 > Using a period after a newline causes bad output. > > Signed-off-by: Joe Perches <joe@perches.com> Applied.
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index d6dff347f896..78ebe494fef0 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -186,7 +186,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct net_device *dev) /* Obtain the queue to be used to transmit this packet */ index = skb_get_queue_mapping(skb); if (index >= num_queues) { - pr_warn_ratelimited("Invalid queue %hu for packet on interface %s\n.", + pr_warn_ratelimited("Invalid queue %hu for packet on interface %s\n", index, vif->dev->name); index %= num_queues; }
Using a period after a newline causes bad output. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/xen-netback/interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)